| 46b9b134 |
gatttool: Use bluetoothctl strategy to handle standard input
Use GSource id returned by g_io_add_watch() instead of raw GIOChannel to
handle stdin and glib main loop. |
Eder Ruiz Maria |
12 years ago |
1 file, +19, -7 |
| 4fe74261 |
gatttool: Remove connecting message from prompt
When trying to connect, the "connecting" message is not set as prompt
anymore. Instead, it is printed just like other status messages and the
prompt is kept, allowing the user to send commands while connection is
being established. |
Alvaro Silva |
12 years ago |
1 file, +7, -8 |
| e80e4bd1 |
gatttool: Show connection state using color
When device is connected, the Bluetooth address is shown in blue color. |
Alvaro Silva |
12 years ago |
1 file, +3, -3 |
| f952820e |
gatttool: Use bluetoothctl behavior when pressing Enter on empty prompt |
Eder Ruiz Maria |
12 years ago |
1 file, +1, -0 |
| cf192c49 |
gatttool: Replace more usages of printf() with rl_printf()
rl_printf() works better with readline than plain printf(), specially on
asynchronous callbacks. |
Eder Ruiz Maria |
12 years ago |
1 file, +84, -93 |
| 6a287262 |
gatttool: Fix issues with printf() and readline prompt
Use rl_printf() from bluetoothctl to consistently display messages. This
is specially important for asynchronous callbacks, where using printf()
may mess up the prompt created by readline. |
Eder Ruiz Maria |
12 years ago |
2 files, +7, -5 |
| 3dacf276 |
gatttool: Use GError to propage error messages to caller
Handle runtime errors outside gatt_connect(), using GError to propagate
error messages to caller. |
Eder Ruiz Maria |
12 years ago |
4 files, +20, -13 |
| 519fe630 |
monitor: Remove bogus entries from event mask table
The event mask is 64 bits so any bit offsets greater than that do not
make sense. |
Johan Hedberg |
12 years ago |
1 file, +0, -10 |
| 8f154c2e |
audio: Remove unused constants
Removes the never used constants AUDIO_SINK_INTERFACE and
AUDIO_SOURCE_INTERFACE which are defined to "org.bluez.AudioSink" and
"org.bluez.AudioSource", respectively. |
João Paulo Rechi Vita |
12 years ago |
2 files, +0, -4 |
| e0445712 |
audio: Remove unused function
Removes the never used function audio_device_is_active. |
João Paulo Rechi Vita |
12 years ago |
2 files, +0, -22 |
| 7f200ffa |
audio: Remove unused constant
Removes the never used constant AUDIO_INTERFACE which is defined to
"org.bluez.Audio". |
João Paulo Rechi Vita |
12 years ago |
1 file, +0, -2 |
| 4a9ce2ed |
Release 5.4 |
Marcel Holtmann |
12 years ago |
2 files, +9, -1 |
| 858283ea |
build: Update library version |
Marcel Holtmann |
12 years ago |
1 file, +1, -1 |
| eb1f591c |
lib: Update list of company identifiers |
Marcel Holtmann |
12 years ago |
1 file, +14, -0 |
| 518a51ad |
obexd: Automatically setup notification connection for MAP client
This automatically establishes the MNS connection when the MAS client
session is started and terminates the MNS connection when the MAS client
session is closed.
The MAP client controls the notification channel using the
SetNotificationRegistration function. The MSE will connect/disconnect
the MNS connection accordingly. |
Christian Fetzer |
12 years ago |
1 file, +32, -0 |
| eecf2d8c |
obexd: Enable MNS server |
Christian Fetzer |
12 years ago |
1 file, +2, -0 |
| ae130d6e |
build: Add support for building MNS server |
Christian Fetzer |
12 years ago |
1 file, +3, -0 |
| ef4b34eb |
obexd: Add Message Notification Service (MNS) server
This implements the server role of the MAP Message Notification Service
(MNS) which is part of the MAP Client Equipment (MCE) device.
After successful registration, the MNS will receive event reports,
notifying about state changes on the server side.
Possible events are: NewMessages, DeliverySuccess, SendingSuccess,
DeliveryFailure, SendingFailure, MemoryFull, MemoryAvailable,
MessageDeleted, MessageShift |
Christian Fetzer |
12 years ago |
3 files, +406, -0 |
| 6ede4362 |
profile: Add MNS server record
This adds the MNS server record to the profile default settings. |
Christian Fetzer |
12 years ago |
1 file, +55, -0 |
| 4dd429fc |
shared: Use gcc builtin instead of g_atomic
g_atomic_* end up using G_STATIC_ASSERT, causing gcc 4.8 to yell due to
-Wunused-local-typedefs.
/usr/include/glib-2.0/glib/gmacros.h:162:53: error: typedef ‘_GStaticAssertCompileTimeAssertion_2’ locally defined but not used [-Werror=unused-local-typedefs]
#define G_STATIC_ASSERT(expr) typedef char G_PASTE (_GStaticAssertCompileTimeAssertion_, __COUNTER__)[(expr) ? 1 : -1] |
Lucas De Marchi |
12 years ago |
1 file, +2, -2 |
| ee27640e |
obexd: Use gcc builtin instead of g_atomic
g_atomic_* end up using G_STATIC_ASSERT, causing gcc 4.8 to yell due to
-Wunused-local-typedefs.
/usr/include/glib-2.0/glib/gmacros.h:162:53: error: typedef ‘_GStaticAssertCompileTimeAssertion_2’ locally defined but not used [-Werror=unused-local-typedefs]
#define G_STATIC_ASSERT(expr) typedef char G_PASTE (_GStaticAssertCompileTimeAssertion_, __COUNTER__)[(expr) ? 1 : -1]
Most of the uses of atomic operations were wrong. They were fixed as
well. If we are using atomic operations, reading the variable again
later for logging is not an option, we should use the return of the
atomic function used to fetch the variable. |
Lucas De Marchi |
12 years ago |
1 file, +6, -6 |
| d073af52 |
gobex: Use gcc builtin instead of g_atomic
g_atomic_* end up using G_STATIC_ASSERT, causing gcc 4.8 to yell due to
-Wunused-local-typedefs.
/usr/include/glib-2.0/glib/gmacros.h:162:53: error: typedef ‘_GStaticAssertCompileTimeAssertion_2’ locally defined but not used [-Werror=unused-local-typedefs]
#define G_STATIC_ASSERT(expr) typedef char G_PASTE (_GStaticAssertCompileTimeAssertion_, __COUNTER__)[(expr) ? 1 : -1]
Most of the uses of atomic operations were wrong. They were fixed as
well. If we are using atomic operations, reading the variable again
later for logging is not an option, we should use the return of the
atomic function used to fetch the variable. |
Lucas De Marchi |
12 years ago |
1 file, +8, -6 |
| 1bd26421 |
attrib: Use gcc builtin instead of g_atomic
g_atomic_* end up using G_STATIC_ASSERT, causing gcc 4.8 to yell due to
-Wunused-local-typedefs.
/usr/include/glib-2.0/glib/gmacros.h:162:53: error: typedef ‘_GStaticAssertCompileTimeAssertion_2’ locally defined but not used [-Werror=unused-local-typedefs]
#define G_STATIC_ASSERT(expr) typedef char G_PASTE (_GStaticAssertCompileTimeAssertion_, __COUNTER__)[(expr) ? 1 : -1]
Most of the uses of atomic operations were wrong. They were fixed as
well. If we are using atomic operations, reading the variable again
later for logging is not an option, we should use the return of the
atomic function used to fetch the variable. |
Lucas De Marchi |
12 years ago |
2 files, +14, -12 |
| 38669d6e |
gdbus: Use gcc builtin instead of g_atomic
g_atomic_* end up using G_STATIC_ASSERT, causing gcc 4.8 to yell due to
-Wunused-local-typedefs.
gdbus/client.c: In function ‘g_dbus_client_ref’:
/usr/include/glib-2.0/glib/gmacros.h:162:53: error: typedef ‘_GStaticAssertCompileTimeAssertion_2’ locally defined but not used [-Werror=unused-local-typedefs]
#define G_STATIC_ASSERT(expr) typedef char G_PASTE (_GStaticAssertCompileTimeAssertion_, __COUNTER__)[(expr) ? 1 : -1] |
Lucas De Marchi |
12 years ago |
1 file, +6, -6 |
| 271bbdc8 |
gitignore: Ignore file generated by Automake 1.13
Automake >= 1.13 enables parallel-tests option which uses a test-driver
script (copied by automake). Ignore this file. |
Lucas De Marchi |
12 years ago |
1 file, +4, -0 |
| 189cc820 |
gatttool: Remove check for bluetooth address parameter on gatt_connect()
This check is more appropriate to be done by callers of gatt_connect().
This is already done on interactive mode in attrib/interactive.c and is
now also done in non-interactive mode. |
Eder Ruiz Maria |
12 years ago |
1 file, +0, -5 |
| 8f84a47e |
gatttool: Remote address is mandatory for non-interactive gatttool
For gatttool non-interactive mode, command line parameter with
bluetooth remote address is mandatory. |
Eder Ruiz Maria |
12 years ago |
1 file, +6, -0 |
| 58123ad7 |
gatttool: Fix memory leak after parsing input line
The callback is responsible for freeing input line buffer that comes
from rl_callback_handler_install(). |
Jefferson Delfes |
12 years ago |
1 file, +4, -1 |
| 972c9216 |
tools/hciattach: Fix TI firmware path
Change firmware path to /lib/firmware/ti-connectivity/ to be
conform with linux-firmware folder structure. All wl1xxx firmware
resides in ti-connectivity. See linux-firmware repository
https://git.kernel.org/cgit/linux/kernel/git/firmware/linux-firmware.git/
for reference. |
Yegor Yefremov |
12 years ago |
1 file, +1, -1 |
| bfe5f617 |
audio: Track connections to AVRCP roles separately
Currently the code assumes when one role connects the other must be
connected as well which is bogus and can create problems. |
Luiz Augusto von Dentz |
12 years ago |
4 files, +29, -14 |
| e63b0f90 |
lib: Fix invalid memory access in sdp_service_search_attr_req
Browsing services using sdptool can lead to writing to invalid heap
locations.
valgrind's output of exemplary call: sdptool browse local
==2203== HEAP SUMMARY:
==2203== in use at exit: 0 bytes in 0 blocks
==2203== total heap usage: 251 allocs, 251 frees, 140,156 bytes allocated
==2203==
==2203== All heap blocks were freed -- no leaks are possible
==2203==
==2203== ERROR SUMMARY: 6 errors from 2 contexts (suppressed: 0 from 0)
==2203==
==2203== 1 errors in context 1 of 2:
==2203== Invalid write of size 2
==2203== at 0x805B882: bt_put_be16 (in /home/xpu/gits/bluez.bin/bin/sdptool)
==2203== by 0x8062BD0: sdp_service_search_attr_req (in /home/xpu/gits/bluez.bin/bin/sdptool)
==2203== by 0x8052457: do_search (in /home/xpu/gits/bluez.bin/bin/sdptool)
==2203== by 0x80525AE: do_search (in /home/xpu/gits/bluez.bin/bin/sdptool)
==2203== by 0x805277F: cmd_browse (in /home/xpu/gits/bluez.bin/bin/sdptool)
==2203== by 0x8053199: main (in /home/xpu/gits/bluez.bin/bin/sdptool)
==2203== Address 0x4391359 is 7 bytes before a block of size 2,048 alloc'd
==2203== at 0x402B6A8: malloc (in /usr/lib/valgrind/vgpreload_memcheck-x86-linux.so)
==2203== by 0x8062B4B: sdp_service_search_attr_req (in /home/xpu/gits/bluez.bin/bin/sdptool)
==2203== by 0x8052457: do_search (in /home/xpu/gits/bluez.bin/bin/sdptool)
==2203== by 0x80525AE: do_search (in /home/xpu/gits/bluez.bin/bin/sdptool)
==2203== by 0x805277F: cmd_browse (in /home/xpu/gits/bluez.bin/bin/sdptool)
==2203== by 0x8053199: main (in /home/xpu/gits/bluez.bin/bin/sdptool)
==2203==
==2203==
==2203== 5 errors in context 2 of 2:
==2203== Invalid write of size 1
==2203== at 0x402D363: memcpy (in /usr/lib/valgrind/vgpreload_memcheck-x86-linux.so)
==2203== by 0x80613E7: gen_dataseq_pdu (in /home/xpu/gits/bluez.bin/bin/sdptool)
==2203== by 0x8061472: gen_attridseq_pdu (in /home/xpu/gits/bluez.bin/bin/sdptool)
==2203== by 0x8062C00: sdp_service_search_attr_req (in /home/xpu/gits/bluez.bin/bin/sdptool)
==2203== by 0x8052457: do_search (in /home/xpu/gits/bluez.bin/bin/sdptool)
==2203== by 0x80525AE: do_search (in /home/xpu/gits/bluez.bin/bin/sdptool)
==2203== by 0x805277F: cmd_browse (in /home/xpu/gits/bluez.bin/bin/sdptool)
==2203== by 0x8053199: main (in /home/xpu/gits/bluez.bin/bin/sdptool)
==2203== Address 0x439135b is 5 bytes before a block of size 2,048 alloc'd
==2203== at 0x402B6A8: malloc (in /usr/lib/valgrind/vgpreload_memcheck-x86-linux.so)
==2203== by 0x8062B4B: sdp_service_search_attr_req (in /home/xpu/gits/bluez.bin/bin/sdptool)
==2203== by 0x8052457: do_search (in /home/xpu/gits/bluez.bin/bin/sdptool)
==2203== by 0x80525AE: do_search (in /home/xpu/gits/bluez.bin/bin/sdptool)
==2203== by 0x805277F: cmd_browse (in /home/xpu/gits/bluez.bin/bin/sdptool)
==2203== by 0x8053199: main (in /home/xpu/gits/bluez.bin/bin/sdptool)
==2203==
==2203== ERROR SUMMARY: 6 errors from 2 contexts (suppressed: 0 from 0) |
Arkadiusz Lichwa |
12 years ago |
1 file, +5, -0 |
| 8c8cc51b |
attrib: Fix status on memory allocation failure
If memory allocation fails, ATT_ECODE_INSUFF_RESOURCES should be
reported to the callback. |
Anderson Lizardo |
12 years ago |
1 file, +3, -1 |
| 8b61564c |
attrib: Fix coding style in read_char_helper() |
Anderson Lizardo |
12 years ago |
1 file, +2, -3 |
| 03f2256f |
attrib: Fix memory leak on low memory condition
If g_try_new0() fails due to low memory condition, "list" should be
freed before returning from primary_all_cb(). |
Anderson Lizardo |
12 years ago |
1 file, +1, -0 |
| e39bad17 |
AVCTP: Add mapping for mandatory pass-through operations
This add mapping for mandatory pass-through operations for categories
supported and a few other operations considered useful. |
Luiz Augusto von Dentz |
12 years ago |
2 files, +36, -0 |
| a48a090c |
tools/mgmt-tester: Refine stop discovery test case
Add HCI test and discovering event test for stop discovery. |
Alvaro Silva |
12 years ago |
1 file, +8, -0 |
| 4f4b8ff9 |
tools/mgmt-tester: Refine start discovery test case
Add HCI command test and discovering event test for start discovery. |
Alvaro Silva |
12 years ago |
1 file, +8, -0 |
| 693f759c |
attrib: Fix use after free of attrib
If attrib is freed in cmd->func(), then it will be used if either
request or response queue has some data to send.
This patch moves calling wake_up_sender() which increases the ref
count of attrib so that it wont get freed in cmd->func(). |
Jaganath Kanakkassery |
12 years ago |
1 file, +4, -4 |
| f59bdb51 |
attrib: Remove norequests and noresponses variables
Passing NULL is fine to g_queue_is_empty(), so removing these
variables makes the code more readable |
Jaganath Kanakkassery |
12 years ago |
1 file, +2, -7 |
| 897e4866 |
core: Fix a double free on adapter_stop
The discovery_list list has the list of current discovery clients and is
removed on adapter_stop (for example due a "power off" command). The
g_slist_free_full will call discovery_free on every element of the list
and remove the nodes of the list, but discovery_destroy (called by
discovery_free) will not only free the element, but also remove it from
the list. This causes the list node to be freed twice, once by
g_slist_free_full and once by g_slist_remove.
This fix calls successively discovery_destroy and lets it remove the
list's elements one by one. |
Alex Deymo |
12 years ago |
1 file, +11, -13 |
| 6bce2421 |
core: Memory leak on device_free for eir_uuids field.
The eir_uuids list is usually freed by device_svc_resolved, but that
doesn't happen if the device is removed before a SDP browse ends.
This fix deletes the eir_uuids list on device_free. |
Alex Deymo |
12 years ago |
1 file, +3, -0 |
| 22f54625 |
sdptool: Fix mem leak in do_search |
Arkadiusz Lichwa |
12 years ago |
1 file, +2, -0 |
| 789f7e7b |
gatttool: fix parameter type/name from le to psm
The parameter le was changed to psm and its type was modified from
boolean to int, but header was unmodified. That change occurred in commit
0cc24599637ed6666469c68d55f4e42ff722e447. |
Jefferson Delfes |
12 years ago |
1 file, +1, -1 |
| 342f1aa1 |
client: Agent's RequestPasskey implementation
Implements the uint32 RequestPasskey(object device) method. |
Alex Deymo |
12 years ago |
1 file, +36, -0 |
| 4b300522 |
client: Agent's DisplayPasskey implementation
Implements the DisplayPasskey(object device, uint32 passkey, uint16 entered)
method. |
Alex Deymo |
12 years ago |
2 files, +31, -0 |
| d52e8994 |
client: Agent's DisplayPincode implementation
Implements the DisplayPinCode(object device, string pincode) method. |
Alex Deymo |
12 years ago |
1 file, +17, -0 |
| b776f041 |
client: "agent" command capability argument and autocompletion
This patch enables argument autocompletion for the agent command with
the list of capabilities an agent can have, adding also "on" (for the
default "") and "off". The command passes the argument (parsing and
verifying it) to the dbus method call. |
Alex Deymo |
12 years ago |
1 file, +70, -3 |
| 82e49df6 |
client: Right prompt management on agent input
Registering an agent shares the user input interface with the normal console
command interface. The way it is implemented (using rl_message, rl_save_prompt
and rl_restore_prompt) conflicts with the rl_printf calls that may appear
while waiting for user input, loosing the [bluetooth]# prompt.
This patch fixes this and makes clear if the expected input is a command or an
agent reply changing the color and text of the prompt. |
Alex Deymo |
12 years ago |
3 files, +62, -17 |
| f037e826 |
client: Add color modifiers to NEW, CHG and DEL events.
Events like [NEW], [CHG] and [DEL] can appear in the command console at
any time, even when the user is typing a command. The last line is kept
making the event line appear just before it, something that can be
unnoticed. This patch add meaningful colors for those three event to make
it easier to see them. |
Alex Deymo |
12 years ago |
2 files, +16, -7 |
| 4f7b4fd3 |
sdptool: Fix recursive search
When doing recursive SDP searches, we must not overwrite our own values
after we retrieved them from SDP. Otherwise, the UUID test will always we
false. |
David Herrmann |
12 years ago |
1 file, +3, -2 |