| de43400a |
tools/mgmt-tester: Fix invalid settings for power off test case
The test that's supposed to verify correct "power off" error response
shouldn't be powering on the adapter in the setup stage. |
Johan Hedberg |
10 years ago |
1 file, +1, -1 |
| 1d0934b5 |
core: Fix broken #ifdef around backtrace support |
Marcel Holtmann |
10 years ago |
1 file, +1, -5 |
| 4959c6d4 |
core: Initialize the backtracer early on at start |
Marcel Holtmann |
10 years ago |
3 files, +21, -2 |
| 98c97bd6 |
tools/valgrind: Add suppression for __btd_log_init
valgrind seems to treat every bind to PF_BLUETOOTH as an RFCOMM socket
causing the following false positives:
Syscall param socketcall.bind(my_addr.rc_bdaddr) points to uninitialised byte(s)
at 0x52728A7: bind (in /usr/lib64/libc-2.21.so)
by 0x4045B1: logging_open (log.c:76)
by 0x4045B1: __btd_log_init (log.c:298)
by 0x402823: main (test-avctp.c:278)
Address 0xffefffcb6 is on thread 1's stack
in frame #1, created by __btd_log_init (log.c:290)
Uninitialised value was created by a stack allocation
at 0x404490: __btd_log_init (log.c:290)
Syscall param socketcall.bind(my_addr.rc_channel) points to uninitialised byte(s)
at 0x52728A7: bind (in /usr/lib64/libc-2.21.so)
by 0x4045B1: logging_open (log.c:76)
by 0x4045B1: __btd_log_init (log.c:298)
by 0x402823: main (test-avctp.c:278)
Address 0xffefffcb8 is on thread 1's stack
in frame #1, created by __btd_log_init (log.c:290)
Uninitialised value was created by a stack allocation
at 0x404490: __btd_log_init (log.c:290) |
Luiz Augusto von Dentz |
10 years ago |
1 file, +13, -0 |
| bc4dbda3 |
core/profile: Fix possible crash when registering profiles
Profiles under ext_profiles are local and should no be mixed with other
external profiles since its type is different which can may cause invalid
memory when accessing member of ext_profile struct. |
Luiz Augusto von Dentz |
10 years ago |
1 file, +2, -12 |
| f1485b75 |
shared/queue: Remove reference count from queue_entry
Since the queue itself has support for reference and queue_foreach
actually make use of it to prevent crashes when queue_destroy is
called from the callback.
Note: The intention of reference count was to protect the entry itself
in queue_foreach, it may still be possible to have a crash if the next
entry if freed but that should be considered an implementation bug. |
Luiz Augusto von Dentz |
10 years ago |
2 files, +6, -31 |
| c5a49786 |
obexd/session: Fix crash when disconnecting
If session owner disconnect from the bus while g_obex_connect is pending
it may lead to a crash since it is never canceled connected_cb may still
be called after callback_data is freed. |
Luiz Augusto von Dentz |
10 years ago |
1 file, +13, -5 |
| 533fa76e |
core: Add missing HAVE_CONFIG_H for shared GATT code |
Marcel Holtmann |
10 years ago |
3 files, +12, -0 |
| 70960a14 |
core: Use local assert function where possible |
Marcel Holtmann |
10 years ago |
2 files, +7, -6 |
| 16669134 |
core: Add support for basic stack backtrace helper |
Marcel Holtmann |
10 years ago |
5 files, +175, -1 |
| 410f2282 |
core: Start SDP server only for BR/EDR or dual mode operation |
Marcel Holtmann |
10 years ago |
2 files, +13, -9 |
| ded2a5be |
monitor: Adjust colors for system note and user logging messages |
Marcel Holtmann |
10 years ago |
2 files, +4, -6 |
| d94a567c |
monitor: Add support --priority option to getopt parsing |
Marcel Holtmann |
10 years ago |
1 file, +1, -0 |
| 66870b76 |
core: Use constant for logging ident string and its length |
Marcel Holtmann |
10 years ago |
1 file, +8, -7 |
| 2b9a98e7 |
monitor: Use btsnoop priority constants for user logging |
Marcel Holtmann |
10 years ago |
1 file, +6, -6 |
| a34346dc |
btsnoop: Add constants for Bluetooth monitor fields |
Marcel Holtmann |
10 years ago |
1 file, +20, -0 |
| d433736e |
btsnoop: Update file format identifiers for trace files |
Marcel Holtmann |
10 years ago |
5 files, +47, -47 |
| 60824d67 |
monitor: Allow using "debug" string for setting priority level |
Marcel Holtmann |
10 years ago |
1 file, +7, -1 |
| 88727a38 |
monitor: Add support for user logging priority selection |
Marcel Holtmann |
10 years ago |
3 files, +15, -1 |
| b4c54f97 |
monitor: Do not abort user logging for invalid index messages |
Marcel Holtmann |
10 years ago |
1 file, +6, -3 |
| b153e8ba |
core: Use adapter->dev_id for adapter specific logging |
Marcel Holtmann |
10 years ago |
1 file, +223, -124 |
| dcfdc556 |
core: Add logging functions for controller specific messages |
Marcel Holtmann |
10 years ago |
2 files, +75, -15 |
| 1e95c542 |
monitor: Use cleaner decoding for system note and user logging packets |
Marcel Holtmann |
10 years ago |
3 files, +82, -74 |
| 11f685d4 |
core: Add support for user logging with ident information |
Marcel Holtmann |
10 years ago |
1 file, +12, -5 |
| 148a5a8e |
monitor: Add support for handling user logging with ident |
Marcel Holtmann |
10 years ago |
1 file, +14, -4 |
| 99089da7 |
monitor: Support obmission of label when printing packets |
Marcel Holtmann |
10 years ago |
1 file, +3, -2 |
| 690b2a90 |
obexd: Use common logging function for daemon version |
Marcel Holtmann |
10 years ago |
1 file, +1, -1 |
| b1cafe4f |
core: Use common logging function for daemon version |
Marcel Holtmann |
10 years ago |
1 file, +1, -1 |
| 002e0d0a |
core: Add support for logging output to HCI_CHANNEL_LOGGING |
Marcel Holtmann |
10 years ago |
1 file, +115, -4 |
| 3b8f3b74 |
lib: Add definition for HCI_CHANNEL_LOGGING |
Marcel Holtmann |
10 years ago |
1 file, +1, -0 |
| f4161d50 |
monitor: Add support for decoding user logging packets |
Marcel Holtmann |
10 years ago |
3 files, +62, -1 |
| 12abeb4e |
monitor: Add support for system note packet type |
Marcel Holtmann |
10 years ago |
3 files, +42, -20 |
| e13a5a41 |
shared/gatt-client: Fix use after free
This fixes the following crash which happens when a service changed
removes characteristics which have notification pending:
==42544== Invalid read of size 4
==42544== at 0x4939FA: enable_ccc_callback (gatt-client.c:1163)
==42544== by 0x490D37: handle_rsp (att.c:673)
==42544== by 0x490D37: can_read_data (att.c:845)
==42544== by 0x498ED4: watch_callback (io-glib.c:170)
==42544== by 0x4E7EE39: g_main_context_dispatch (in /usr/lib64/libglib-2.0.so.0.4600.1)
==42544== by 0x4E7F1CF: ??? (in /usr/lib64/libglib-2.0.so.0.4600.1)
==42544== by 0x4E7F4F1: g_main_loop_run (in /usr/lib64/libglib-2.0.so.0.4600.1)
==42544== by 0x40B12E: main (main.c:661)
==42544== Address 0x7e4eaa8 is 8 bytes inside a block of size 32 free'd
==42544== at 0x4C29D6A: free (in /usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so)
==42544== by 0x48C96D: queue_remove_all (queue.c:360)
==42544== by 0x491AA2: gatt_client_remove_notify_chrcs_in_range (gatt-client.c:331)
==42544== by 0x491AA2: process_service_changed (gatt-client.c:1398)
==42544== by 0x48C74D: queue_foreach (queue.c:239)
==42544== by 0x4936B2: notify_cb (gatt-client.c:1614)
==42544== by 0x490BC6: handle_notify (att.c:800)
==42544== by 0x490BC6: can_read_data (att.c:881)
==42544== by 0x498ED4: watch_callback (io-glib.c:170)
==42544== by 0x4E7EE39: g_main_context_dispatch (in /usr/lib64/libglib-2.0.so.0.4600.1)
==42544== by 0x4E7F1CF: ??? (in /usr/lib64/libglib-2.0.so.0.4600.1)
==42544== by 0x4E7F4F1: g_main_loop_run (in /usr/lib64/libglib-2.0.so.0.4600.1)
==42544== by 0x40B12E: main (main.c:661) |
Luiz Augusto von Dentz |
10 years ago |
1 file, +11, -11 |
| c11729bd |
btsnoop: Identify pklg vendor diagnostic packets |
Marcel Holtmann |
10 years ago |
1 file, +2, -0 |
| 3ba0a8b5 |
doc/test-coverage: Update mgmt-tester & l2cap-tester test counts |
Johan Hedberg |
10 years ago |
1 file, +3, -3 |
| 46fe6aea |
monitor: Fix L2CAP connection response code decoding
The Connect Response, LE Connect Response and Create Channel Response
PDUs have to some extent similar, but still different response code
meanings. Add dedicated decoding functions for these depending on the
context. |
Johan Hedberg |
10 years ago |
1 file, +81, -4 |
| 56821b7c |
tools/l2cap-tester: Add invalid LE SCID test case |
Johan Hedberg |
10 years ago |
1 file, +35, -0 |
| 6ada5d5b |
core/service: Fix failing to connect external profile
When initiating a connection to a external profile btd_service_connect
will be called which will change the service state to
BTD_SERVICE_STATE_CONNECTING but then once the connection completes
service_accept is called but since it now checks the state it would
return -EALREADY to prevent driver accept to be called more than once. |
Luiz Augusto von Dentz |
10 years ago |
1 file, +1, -1 |
| f5f2ec01 |
tools/mgmt-tester: Remove unnecessary define
There's no need to have a define for opcode 0 since all of the structs
needing this are declared static and will have the value set to 0 if
not explicitly mentioned. |
Johan Hedberg |
10 years ago |
1 file, +0, -4 |
| 15a77624 |
core: Remove dead code
This removes dead code due to memory allocation with new0 not being
able to fail. |
Szymon Janc |
10 years ago |
3 files, +0, -173 |
| 97075679 |
android: Remove dead code
This removes dead code due to memory allocation with new0 not being
able to fail. |
Szymon Janc |
10 years ago |
20 files, +67, -538 |
| 962285c7 |
shared: Remove dead code
This removes dead code due to memory allocation with new0 not being
able to fail. |
Szymon Janc |
10 years ago |
18 files, +1, -395 |
| 60ee57f8 |
shared: Make new0 abort on failure
New is used to allocate small (typically much less than 1 page) chunks
and if such allocation fails system is most likely in state where
recovery is unlikely. Also by default Linux follows an optimistic memory
allocation strategy with OOM killer.
Aborting on allocationg failure allows to significantly simplify error
paths (which were most likely never tested anyway) and thus makes code
easier to understand.
btd_malloc name is used as malloc wrapper so that it can be exported
by bluetoothd and used also in external plugins. |
Szymon Janc |
10 years ago |
2 files, +29, -1 |
| 39681eaf |
Release 5.36 |
Marcel Holtmann |
10 years ago |
2 files, +9, -1 |
| 0b0d4634 |
lib: Fix UTF-8 characters in company name |
Marcel Holtmann |
10 years ago |
1 file, +1, -1 |
| 7e239803 |
build: Update library version |
Marcel Holtmann |
10 years ago |
1 file, +1, -1 |
| 0b998b6c |
lib: Update company identifiers |
Marcel Holtmann |
10 years ago |
1 file, +56, -0 |
| b133254d |
monitor: Add support for handling SCM_CREDENTIALS if present |
Marcel Holtmann |
10 years ago |
4 files, +75, -51 |
| 2cdea86e |
tools/hciconfig: Fix hci_close_dev
It had been closed different file descriptor.
When has two or more interfaces, hciconfig -a exit after cmd_class
function. |
Kunio AKASHI |
10 years ago |
1 file, +1, -1 |
| da32a4dd |
unit: Fix gobex unit tests
/gobex/test_header_encode_connid test name was duplicated.
This results in Glib assert:
(unit/test-gobex-header:15356): GLib-ERROR **: duplicate test
case path: /gobex/test_header_encode_connid |
Szymon Janc |
10 years ago |
1 file, +1, -1 |