Commit: b72a3526a81779e1e807de53b8d7be0cefa3ad6d
Parent: 4560a956e9d0673310101370e99f0905af43b999
Author: Lucas De Marchi <lucas.demarchi@profusion.mobi>
Committer: Johan Hedberg <johan.hedberg@intel.com>
Date: 2011-06-30 22:52:28
Tree: 4c63e248d4907c5c9ffcb99b9f41012e0ddb9ba8

avrcp: return NOT_IMPLEMENTED on request for vendor dep command When a vendor dependent command is requested but target does not implement it, the correct return value is CTYPE_NOT_IMPLEMENTED instead of CTYPE_REJECTED. AVRCP 1.3 spec clearly says so on section 4.5.1: [ It is assumed that devices that do not support this metadata transfer related features shall return a response of NOT IMPLEMENTED as per AV/C protocol specification ] And AV/C General Specification, section 8.3.2 talks about legacy behavior and mandates that NOT_IMPLEMENTED is returned. Finally, in section 11.6.1 we see that VENDOR-DEPENDENT command frame depends on the company_ID. Therefore we can't assume it has the same format as the one specified for metadata transfer (in case the company ID is 0x001958)

Diffstat

M audio/control.c | 15 ++- - - - - - - - - - - - -

1 files changed, 2 insertions(+), 13 deletions(-)

View Full Diff | Patch