Commit: a86eae7fef9819317f591ee11b6e140c0c424f94
Parent: fb018899b65f98dc847c06a104e4350ef3ac4a23
Author: Arik Nemtsov <arik@wizery.com>
Committer: Johan Hedberg <johan.hedberg@intel.com>
Date: 2012-03-15 10:17:52
Tree: b127ccf60d878f3817270df919449dbd0ffbf2a5

Revert "core: Add provision for terminating an ATT connection" This reverts commit f89a77478af78d41c80ab7605662382b9e4e1c36. This is not needed and actually introduces a bug. When the "Disconnect" API of device is called device->attrib is unref-ed via a watch set on G_IO_HUP. The channel is shutdown when the last reference is removed. The code introduced here shuts down the channel and prevents the watch from getting called. This means we leak a reference to device->attrib. This can cause a number of bad things. For example, if the device is temporary, it will never be freed, and we won't be able to pair to it again.

Diffstat

M src/device.c | 8 - - - - - - - -

1 files changed, 0 insertions(+), 8 deletions(-)

View Full Diff | Patch