Commit: 923379409010602254233103689c8ed2ff2a6cc6
Parent: 8572f2430980ae75c9df9b51adf86cca9e2d85f0
Author: Marijn Suijten <marijn.suijten@somainline.org>
Committer: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
Date: 2024-10-21 22:42:21
Tree: 6a4bade9575d8f7074b806bab39a86fe7a489155

audio/avrcp: Guard SetAbsoluteVolume without target behind config value Commit 179ccb936 ("avrcp: Set volume if volume changed event is registered") invented a workaround that allows SetAbsoluteVolume to be sent to a remote device that does _not_ implement the AVRCP TG profile, as long as it previously registered for the EVENT_VOLUME_CHANGED notification. This is strange as the TG role is required to be able to send commands to the peer, but the commit must have been applied to the tree for a reason. We discussed in [1] that workarounds for dubious peers and software stacks should be guarded behind a config entry in main.conf, so this starts out by introducing a new [AVRCP] category that will later be extended with other workarounds. It guards the changed functionality behind a `VolumeWithoutTarget = false` boolean to disallow this obscure check. [1]: https://lore.kernel.org/linux-bluetooth/20211025210206.bkt5wovzmkmt6teg@SoMainline.org/

Diffstat

M profiles/audio/avrcp.c | 14 ++++++++++++- -
M src/btd.h | 5 +++++
M src/main.c | 16 ++++++++++++++++
M src/main.conf | 6 ++++++

4 files changed, 39 insertions(+), 2 deletions(-)

View Full Diff | Patch