Commit: 1de41786c1a22fe0d4f55805f3006ce66e5c65a6
Parent: 4a3f465a55c9e2159d363a5419f3a5dbb965036d
Author: Marijn Suijten <marijn.suijten@somainline.org>
Committer: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
Date: 2023-03-21 17:52:11
Tree: 6ac8b48f9b81aec331e8179320f0416c8ffb8eb5

audio/transport: Propagate errors from avrcp_set_volume to DBus Any error while setting absolute volume on the peer, or notifying the peer of changes was previously going completely unnoticed. Propagate it to the logs and back to the DBus "Volume" property setter so that they aren't misled into thinking that the AVRCP command succeeded. Note that an error is mostly harmless when the setter of the property is an audio sink and the peer the audio source: in this case we're only _notifying_ the peer of the change when it has already been applied on the sink. Also improve the other two error messages to more closely describe what was "invalid" about the argument.

Diffstat

M profiles/audio/transport.c | 34 +++++++++++++++++++++++- - - - - - - - - - -

1 files changed, 23 insertions(+), 11 deletions(-)

View Full Diff | Patch