From 5d16208cf70b8794cc525b2f2be8a4a3c00fe346 Mon Sep 17 00:00:00 2001
From: Luka Hietala <luka.hietala08@gmail.com>
Date: Mon, 8 Dec 2025 20:38:08 +0200
Subject: [PATCH] cleanup highlight py

---
 filters.py   |  8 ++---
 highlight.py | 88 ++++++++++++++++++++++++++--------------------------
 2 files changed, 48 insertions(+), 48 deletions(-)

diff --git a/filters.py b/filters.py
index 9a68276..e20a7c7 100644
--- a/filters.py
+++ b/filters.py
@@ -1,7 +1,7 @@
 from datetime import datetime
 
 
-# Filter to format datetime objects or timestamps as strings (2025-12-08 12:18:21 )
+# filter to format datetime objects or timestamps as strings (2025-12-08 12:18:21 )
 def datetime_filter(value, format="%Y-%m-%d %H:%M:%S"):
     if isinstance(value, datetime):
         return value.strftime(format)
@@ -11,7 +11,7 @@ def datetime_filter(value, format="%Y-%m-%d %H:%M:%S"):
     return value
 
 
-# Filter to display age in human-readable format (like "2 days ago", "3 hours ago")
+# filter to display age in human-readable format (like "2 days ago", "3 hours ago")
 def age_filter(value):
     if isinstance(value, (int, float)):
         dt = datetime.fromtimestamp(value)
@@ -38,7 +38,7 @@ def age_filter(value):
     return "just now"
 
 
-# Filter to display file sizes in human-readable format (bytes to KB, MB, GB)
+# filter to display file sizes in human-readable format (bytes to KB, MB, GB)
 def size_filter(value):
     if value is None:
         return ""
@@ -51,7 +51,7 @@ def size_filter(value):
     return f"{value / (1024 * 1024 * 1024):.1f} GB"
 
 
-# Register filters with Flask app
+# register filters with Flask app
 def register_filters(app):
     app.jinja_env.filters["datetime"] = datetime_filter
     app.jinja_env.filters["age"] = age_filter
diff --git a/highlight.py b/highlight.py
index afd7796..dc193ed 100644
--- a/highlight.py
+++ b/highlight.py
@@ -1,62 +1,62 @@
 from pygments import highlight
-from pygments.util import ClassNotFound
+from pygments.formatters import HtmlFormatter
+from pygments.lexers import DiffLexer
 from pygments.lexers import TextLexer
 from pygments.lexers import guess_lexer
 from pygments.lexers import guess_lexer_for_filename
-from pygments.lexers import DiffLexer
-from pygments.formatters import HtmlFormatter
+from pygments.util import ClassNotFound
+
+STYLE = "sas"
 
-# server-side syntax highlighting
 
 # reference: https://git.kernel.org/pub/scm/infra/cgit.git/tree/filters/syntax-highlighting.py?id=dbaee2672be14374acb17266477c19294c6155f3
-def highlight_code(data, filename):
-    formatter = HtmlFormatter(style='sas', nobackground=True, linenos=True)
+def _safe_lexer(content, filename):
     try:
-        lexer = guess_lexer_for_filename(filename, data)
+        return guess_lexer_for_filename(filename, content)
     except ClassNotFound:
-        if data.startswith('#!'):
-            lexer = guess_lexer(data)
-        else:
-            lexer = TextLexer()
+        if content.startswith("#!"):
+            return guess_lexer(content)
+        return TextLexer()
     except TypeError:
-        lexer = TextLexer()
-    css = formatter.get_style_defs('.highlight')
-    highlighted = highlight(data, lexer, formatter)
-    return f'<style>{css}</style>{highlighted}'
+        return TextLexer()
+
+
+def _formatter(*, linenos=False, cssclass=None, nowrap=False):
+    return HtmlFormatter(
+        style=STYLE,
+        nobackground=True,
+        linenos=linenos,
+        cssclass=cssclass,
+        nowrap=nowrap,
+    )
 
+
+# highlight code with filename-based lexer
+def highlight_code(data, filename):
+    formatter = _formatter(linenos=True)
+    css = formatter.get_style_defs(".highlight")
+    highlighted = highlight(data, _safe_lexer(data, filename), formatter)
+    return f"<style>{css}</style>{highlighted}"
+
+
+# get CSS styles for blame view
 def get_highlight_blame_style():
-    formatter = HtmlFormatter(style='sas', nobackground=True, cssclass='blame-code')
-    return formatter.get_style_defs('.blame-code')
+    formatter = _formatter(cssclass="blame-code")
+    return formatter.get_style_defs(".blame-code")
+
 
-# highlight a single line (for blame)
+# highlight a single line of code with filename-based lexer
 def highlight_line(line, filename):
-    formatter = HtmlFormatter(style='sas', nobackground=True, cssclass='blame-code')
-    try:
-        lexer = guess_lexer_for_filename(filename, line)
-    except ClassNotFound:
-        if line.startswith('#!'):
-            lexer = guess_lexer(line)
-        else:
-            lexer = TextLexer()
-    except TypeError:
-        lexer = TextLexer()
-    highlighted = highlight(line, lexer, formatter)
-    # remove the outer div and pre
-    # highlighted is <div class="blame-code"><pre>mirri</pre></div>
-    # extract inner
-    start = highlighted.find('<pre>') + 5 # length of <pre>, very hacky i know
-    end = highlighted.find('</pre>')
-    return highlighted[start:end]
+    # Use nowrap to avoid wrapping in <div><pre>...</pre></div>
+    formatter = _formatter(cssclass="blame-code", nowrap=True)
+    return highlight(line, _safe_lexer(line, filename), formatter)
+
 
-# bare diff highlighting
+# highlight diff with DiffLexer
 def highlight_diff(data):
-    formatter = HtmlFormatter(style='sas', nobackground=True)
-    lexer = DiffLexer()
-    highlighted = highlight(data, lexer, formatter)
-    # replace default pygments classes with custom ones
-    # classes are from pygments DiffLexer, generic tokens
-    # gd = general deleted, gi = general inserted, gh = general hunk, gu = hunk header?
-    # https://pygments.org/docs/tokens/
+    formatter = _formatter()
+    highlighted = highlight(data, DiffLexer(), formatter)
+    # gd = removed, gi = added, gh = hunk, gu = header
     highlighted = highlighted.replace('class="gd"', 'class="diff-removed"')
     highlighted = highlighted.replace('class="gi"', 'class="diff-added"')
     highlighted = highlighted.replace('class="gh"', 'class="diff-hunk"')
@@ -67,4 +67,4 @@ def highlight_diff(data):
     .diff-hunk { background-color: lightgray; }
     .diff-header { color: blue; font-weight: bold; }
     """
-    return f'<style>{css}</style>{highlighted}'
\ No newline at end of file
+    return f"<style>{css}</style>{highlighted}"
-- 
2.47.3