From ff418f11552e286e4f1bffe2cc3bfa12794eb386 Mon Sep 17 00:00:00 2001 From: Claudio Takahasi Date: Tue, 11 May 2010 18:27:12 -0300 Subject: [PATCH] obexd: Return Bad Request when search value is empty on PullvCardListing No matter the search attribute, search value can't be an empty string. OBEX error bad request is returned for this scenario. --- obexd/plugins/pbap.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/obexd/plugins/pbap.c b/obexd/plugins/pbap.c index 84f4a8ad7..36e520684 100644 --- a/obexd/plugins/pbap.c +++ b/obexd/plugins/pbap.c @@ -459,6 +459,9 @@ static struct apparam_field *parse_aparam(const guint8 *buffer, guint32 hlen) param->searchattrib = hdr->val[0]; break; case SEARCHVALUE_TAG: + if (hdr->len == 0) + goto failed; + param->searchval = g_try_malloc0(hdr->len + 1); if (param->searchval) memcpy(param->searchval, hdr->val, hdr->len); -- 2.47.3