From f8c3a38e4fe943eaed677a295663426cb7241e0e Mon Sep 17 00:00:00 2001 From: Luiz Augusto von Dentz Date: Tue, 30 Aug 2022 14:37:27 -0700 Subject: [PATCH] shared/shell: Fix scan-build error This fixes the following error: src/shared/shell.c:1135:19: warning: Null pointer passed to 1st parameter expecting 'nonnull' data.timeout = atoi(optarg); ^~~~~~~~~~~~ --- src/shared/shell.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/shared/shell.c b/src/shared/shell.c index 4658819a4..0639c786d 100644 --- a/src/shared/shell.c +++ b/src/shared/shell.c @@ -1101,6 +1101,7 @@ void bt_shell_init(int argc, char **argv, const struct bt_shell_opt *opt) struct option options[256]; char optstr[256]; size_t offset; + char *endptr = NULL; offset = sizeof(main_options) / sizeof(struct option); @@ -1132,7 +1133,11 @@ void bt_shell_init(int argc, char **argv, const struct bt_shell_opt *opt) data.mode = 1; goto done; case 't': - data.timeout = atoi(optarg); + if (optarg) + data.timeout = strtol(optarg, &endptr, 0); + + if (!endptr || *endptr != '\0') + printf("Unable to parse timeout\n"); break; case 'z': data.zsh = 1; -- 2.47.3