From f5222f068f6fba49e3d38d61731d32136b76f105 Mon Sep 17 00:00:00 2001 From: Szymon Janc Date: Sat, 28 Mar 2015 21:56:08 +0100 Subject: [PATCH] android/avrcp-lib: Fix not initializing attributes While parsing sttribute list attrs were not initialized with media item id. Conditional jump or move depends on uninitialised value(s) at 0x427850: handle_get_element_attributes_rsp (avrcp.c:1140) by 0x423DFC: get_element_attributes_rsp (avrcp-lib.c:2543) by 0x42039C: session_cb (avctp.c:789) by 0x36A7E492A5: g_main_context_dispatch (in /usr/lib64/ libglib-2.0.so.0.3800.2) by 0x36A7E49627: ??? (in /usr/lib64/libglib-2.0.so.0.3800.2) by 0x36A7E49A39: g_main_loop_run (in /usr/lib64/ libglib-2.0.so.0.3800.2) by 0x40ACB5: main (main.c:661) --- android/avrcp-lib.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/android/avrcp-lib.c b/android/avrcp-lib.c index e404494be..4edfd0e9b 100644 --- a/android/avrcp-lib.c +++ b/android/avrcp-lib.c @@ -2447,10 +2447,12 @@ static int parse_attribute_list(uint8_t *params, uint16_t params_len, if (item->len > 0) { text[i] = g_strndup(item->data, item->len); + attrs[i] = item->attr; params_len -= item->len; params += item->len; } else { text[i] = NULL; + attrs[i] = 0; } } -- 2.47.3