From e7caff69df6b761bc0ee94e3d392eb7c656550d1 Mon Sep 17 00:00:00 2001 From: Luiz Augusto von Dentz Date: Fri, 27 Mar 2015 10:47:37 +0200 Subject: [PATCH] unit: Replace use of g_malloc+memcpy with gmemdup This seems to fix problems of make check not working in 32 bit systems with gcc 5.0. --- unit/test-avctp.c | 3 +-- unit/test-avdtp.c | 3 +-- unit/test-avrcp.c | 3 +-- unit/test-gatt.c | 3 +-- unit/test-hfp.c | 6 ++---- unit/test-hog.c | 3 +-- unit/test-sdp.c | 3 +-- unit/test-uhid.c | 3 +-- 8 files changed, 9 insertions(+), 18 deletions(-) diff --git a/unit/test-avctp.c b/unit/test-avctp.c index 689a8253a..3bc35696d 100644 --- a/unit/test-avctp.c +++ b/unit/test-avctp.c @@ -77,8 +77,7 @@ struct context { }; \ static struct test_data data; \ data.test_name = g_strdup(name); \ - data.pdu_list = g_malloc(sizeof(pdus)); \ - memcpy(data.pdu_list, pdus, sizeof(pdus)); \ + data.pdu_list = g_memdup(pdus, sizeof(pdus)); \ tester_add(name, &data, NULL, function, NULL); \ } while (0) diff --git a/unit/test-avdtp.c b/unit/test-avdtp.c index 58628a77e..dd8aed73c 100644 --- a/unit/test-avdtp.c +++ b/unit/test-avdtp.c @@ -80,8 +80,7 @@ struct test_data { }; \ static struct test_data data; \ data.test_name = g_strdup(name); \ - data.pdu_list = g_malloc(sizeof(pdus)); \ - memcpy(data.pdu_list, pdus, sizeof(pdus)); \ + data.pdu_list = g_memdup(pdus, sizeof(pdus)); \ tester_add(name, &data, NULL, function, NULL); \ } while (0) diff --git a/unit/test-avrcp.c b/unit/test-avrcp.c index 024e38ed5..a610ad5d7 100644 --- a/unit/test-avrcp.c +++ b/unit/test-avrcp.c @@ -109,8 +109,7 @@ struct context { }; \ static struct test_data data; \ data.test_name = g_strdup(name); \ - data.pdu_list = g_malloc(sizeof(pdus)); \ - memcpy(data.pdu_list, pdus, sizeof(pdus)); \ + data.pdu_list = g_memdup(pdus, sizeof(pdus)); \ tester_add(name, &data, NULL, function, NULL); \ } while (0) diff --git a/unit/test-gatt.c b/unit/test-gatt.c index 92ab6dc42..5cb2e9f84 100644 --- a/unit/test-gatt.c +++ b/unit/test-gatt.c @@ -102,8 +102,7 @@ struct context { data.uuid = bt_uuid; \ data.step = test_step; \ data.source_db = db; \ - data.pdu_list = g_malloc(sizeof(pdus)); \ - memcpy(data.pdu_list, pdus, sizeof(pdus)); \ + data.pdu_list = g_memdup(pdus, sizeof(pdus)); \ tester_add(name, &data, NULL, function, NULL); \ } while (0) diff --git a/unit/test-hfp.c b/unit/test-hfp.c index face9a4c5..66966ce5e 100644 --- a/unit/test-hfp.c +++ b/unit/test-hfp.c @@ -95,9 +95,8 @@ struct test_data { }; \ static struct test_data data; \ data.test_name = g_strdup(name); \ - data.pdu_list = g_malloc(sizeof(pdus)); \ + data.pdu_list = g_memdup(pdus, sizeof(pdus)); \ data.result_func = result_function; \ - memcpy(data.pdu_list, pdus, sizeof(pdus)); \ g_test_add_data_func(name, &data, function); \ data.test_handler = test_handler; \ } while (0) @@ -110,10 +109,9 @@ struct test_data { }; \ static struct test_data data; \ data.test_name = g_strdup(name); \ - data.pdu_list = g_malloc(sizeof(pdus)); \ + data.pdu_list = g_memdup(pdus, sizeof(pdus)); \ data.hf_result_func = result_func; \ data.response_func = response_function; \ - memcpy(data.pdu_list, pdus, sizeof(pdus)); \ g_test_add_data_func(name, &data, function); \ data.test_handler = test_hf_handler; \ } while (0) diff --git a/unit/test-hog.c b/unit/test-hog.c index 2a25d095e..778f08791 100644 --- a/unit/test-hog.c +++ b/unit/test-hog.c @@ -81,8 +81,7 @@ struct context { }; \ static struct test_data data; \ data.test_name = g_strdup(name); \ - data.pdu_list = g_malloc(sizeof(pdus)); \ - memcpy(data.pdu_list, pdus, sizeof(pdus)); \ + data.pdu_list = g_memdup(pdus, sizeof(pdus)); \ tester_add(name, &data, NULL, function, NULL); \ } while (0) diff --git a/unit/test-sdp.c b/unit/test-sdp.c index a89dbfca6..b4ef4d1ec 100644 --- a/unit/test-sdp.c +++ b/unit/test-sdp.c @@ -77,8 +77,7 @@ struct test_data { }; \ static struct test_data data; \ data.mtu = _mtu; \ - data.pdu_list = g_malloc(sizeof(pdus)); \ - memcpy(data.pdu_list, pdus, sizeof(pdus)); \ + data.pdu_list = g_memdup(pdus, sizeof(pdus)); \ g_test_add_data_func(name, &data, test_sdp); \ } while (0) diff --git a/unit/test-uhid.c b/unit/test-uhid.c index 85e135673..b48e0faa1 100644 --- a/unit/test-uhid.c +++ b/unit/test-uhid.c @@ -73,8 +73,7 @@ struct context { }; \ static struct test_data data; \ data.test_name = g_strdup(name); \ - data.pdu_list = g_malloc(sizeof(pdus)); \ - memcpy(data.pdu_list, pdus, sizeof(pdus)); \ + data.pdu_list = g_memdup(pdus, sizeof(pdus)); \ g_test_add_data_func(name, &data, function); \ } while (0) -- 2.47.3