From d36983e032e98545c3d90154b1d94605c73170c2 Mon Sep 17 00:00:00 2001 From: Roman Smirnov Date: Tue, 2 Jul 2024 16:15:06 +0300 Subject: [PATCH] gatt: add return value check of io_get_fd() to sock_io_read() It is necessary to add a return value check. Found with the SVACE static analysis tool. --- src/gatt-database.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/src/gatt-database.c b/src/gatt-database.c index 5756eb9d1..8472aac59 100644 --- a/src/gatt-database.c +++ b/src/gatt-database.c @@ -2598,6 +2598,11 @@ static bool sock_io_read(struct io *io, void *user_data) int fd = io_get_fd(io); ssize_t bytes_read; + if (fd < 0) { + error("io_get_fd() returned %d\n", fd); + return false; + } + bytes_read = read(fd, buf, sizeof(buf)); if (bytes_read <= 0) return false; -- 2.47.3