From c8a82f19c5c2ea1d0389b3be24231f87690ec29d Mon Sep 17 00:00:00 2001 From: Luiz Augusto von Dentz Date: Tue, 12 Aug 2025 17:17:05 -0400 Subject: [PATCH] mgmt-tester: Fix tests failing due to missing LL Privacy LL Privacy setting now depends on LE to be enabled first which was causing the following tests to fail, so this removes LL Privacy from the expected settings: Add Ext Advertising - Success 22 (LE -> off, Remove) Set Device ID - Power off and Power on Set Device ID - SSP off and Power on --- tools/mgmt-tester.c | 15 ++++++--------- 1 file changed, 6 insertions(+), 9 deletions(-) diff --git a/tools/mgmt-tester.c b/tools/mgmt-tester.c index c066ad6c3..ac27b85dd 100644 --- a/tools/mgmt-tester.c +++ b/tools/mgmt-tester.c @@ -1509,7 +1509,6 @@ static const char set_ssp_invalid_param[] = { 0x02 }; static const char set_ssp_garbage_param[] = { 0x01, 0x00 }; static const char set_ssp_settings_param_1[] = { 0xc0, 0x00, 0x00, 0x00 }; static const char set_ssp_settings_param_2[] = { 0xc1, 0x00, 0x00, 0x00 }; -static const char set_ssp_settings_param_3[] = { 0xc1, 0x00, 0x40, 0x00 }; static const char set_ssp_on_write_ssp_mode_param[] = { 0x01 }; static const struct generic_data set_ssp_on_success_test_1 = { @@ -6078,8 +6077,8 @@ static const struct generic_data set_dev_id_power_off_on = { .send_param = set_powered_on_param, .send_len = sizeof(set_powered_on_param), .expect_status = MGMT_STATUS_SUCCESS, - .expect_param = set_ssp_settings_param_3, - .expect_len = sizeof(set_ssp_settings_param_3), + .expect_param = set_ssp_settings_param_2, + .expect_len = sizeof(set_ssp_settings_param_2), .expect_settings_set = MGMT_SETTING_POWERED, .expect_hci_command = BT_HCI_CMD_WRITE_EXT_INQUIRY_RESPONSE, .expect_hci_param = write_eir_set_dev_id_success_1, @@ -6095,8 +6094,8 @@ static const struct generic_data set_dev_id_ssp_off_on = { .send_param = set_ssp_on_param, .send_len = sizeof(set_ssp_on_param), .expect_status = MGMT_STATUS_SUCCESS, - .expect_param = set_ssp_settings_param_3, - .expect_len = sizeof(set_ssp_settings_param_3), + .expect_param = set_ssp_settings_param_2, + .expect_len = sizeof(set_ssp_settings_param_2), .expect_hci_command = BT_HCI_CMD_WRITE_EXT_INQUIRY_RESPONSE, .expect_hci_param = write_eir_set_dev_id_success_1, .expect_hci_len = sizeof(write_eir_set_dev_id_success_1), @@ -8599,15 +8598,13 @@ static const struct generic_data add_ext_advertising_success_17 = { .expect_hci_len = sizeof(preset_connectable_off_ext_adv_param), }; -static const char set_le_settings_param_off_1[] = { 0x81, 0x00, 0x40, 0x00 }; - static const struct generic_data add_ext_advertising_le_off = { .send_opcode = MGMT_OP_SET_LE, .send_param = set_le_off_param, .send_len = sizeof(set_le_off_param), .expect_status = MGMT_STATUS_SUCCESS, - .expect_param = set_le_settings_param_off_1, - .expect_len = sizeof(set_le_settings_param_off_1), + .expect_param = set_le_settings_param_off, + .expect_len = sizeof(set_le_settings_param_off), .expect_alt_ev = MGMT_EV_ADVERTISING_REMOVED, .expect_alt_ev_param = advertising_instance1_param, .expect_alt_ev_len = sizeof(advertising_instance1_param), -- 2.47.3