From c81f9320357b0808dd4debebc687d26dc0be30ab Mon Sep 17 00:00:00 2001 From: Bastien Nocera Date: Fri, 10 May 2024 14:10:26 +0200 Subject: [PATCH] iso-tester: Fix fd leak Error: RESOURCE_LEAK (CWE-772): [#def63] [important] tools/iso-tester.c:1796:2: open_fn: Returning handle opened by "socket". tools/iso-tester.c:1796:2: var_assign: Assigning: "sk" = handle returned from "socket(31, 2053, 8)". tools/iso-tester.c:1807:3: leaked_handle: Handle variable "sk" going out of scope leaks the handle. 1805| if (!master_bdaddr) { 1806| tester_warn("No master bdaddr"); 1807|-> return -ENODEV; 1808| } 1809| --- tools/iso-tester.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/iso-tester.c b/tools/iso-tester.c index 046606068..d54fa56ec 100644 --- a/tools/iso-tester.c +++ b/tools/iso-tester.c @@ -1804,6 +1804,7 @@ static int create_iso_sock(struct test_data *data) master_bdaddr = hciemu_get_central_bdaddr(data->hciemu); if (!master_bdaddr) { tester_warn("No master bdaddr"); + close(sk); return -ENODEV; } -- 2.47.3