From bbeabca44a3da3e1efd8e57b0366bbb45aadbb5b Mon Sep 17 00:00:00 2001 From: Luiz Augusto von Dentz Date: Mon, 4 Apr 2022 13:15:18 -0700 Subject: [PATCH] gap: Don't attempt to read the appearance if already set Devices are unlikely to change appearance over time which is the reason why we cache then on the storage so this skips reading it on every reconnection. --- profiles/gap/gas.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/profiles/gap/gas.c b/profiles/gap/gas.c index ea3249be9..400818d67 100644 --- a/profiles/gap/gas.c +++ b/profiles/gap/gas.c @@ -142,6 +142,11 @@ static void read_appearance_cb(bool success, uint8_t att_ecode, static void handle_appearance(struct gas *gas, uint16_t value_handle) { + uint16_t value; + + if (!device_get_appearance(gas->device, &value)) + return; + if (!bt_gatt_client_read_value(gas->client, value_handle, read_appearance_cb, gas, NULL)) DBG("Failed to send request to read appearance"); -- 2.47.3