From b5b7e6203b9303b20751f4ef0ad2d6a01a671ae9 Mon Sep 17 00:00:00 2001 From: Dmitry Torokhov Date: Wed, 7 Apr 2021 15:33:47 -0700 Subject: [PATCH] input/hog-lib: do not silently ignore missing connection in read_char() Currently we silently ignore missing connection (attrib) in read_char(), but not in the other GATT interfaces (such as write_char, discover_desc, etc). The code should avoid calling read_char() when there is no active connection instead, and logging errors will help us trace the offenders. --- profiles/input/hog-lib.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/profiles/input/hog-lib.c b/profiles/input/hog-lib.c index ecd15ad73..3bbe42370 100644 --- a/profiles/input/hog-lib.c +++ b/profiles/input/hog-lib.c @@ -184,10 +184,6 @@ static void read_char(struct bt_hog *hog, GAttrib *attrib, uint16_t handle, struct gatt_request *req; unsigned int id; - /* Ignore if not connected */ - if (!attrib) - return; - req = create_request(hog, user_data); if (!req) return; -- 2.47.3