From a7032c97ef6c399eacc63bf0e18ac67da2d1356b Mon Sep 17 00:00:00 2001 From: Andrei Emeltchenko Date: Thu, 6 Feb 2014 16:22:42 +0200 Subject: [PATCH] android/haltest: Close file in case of error --- android/client/if-audio.c | 13 ++++++++++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/android/client/if-audio.c b/android/client/if-audio.c index db31c81ba..8c640a1f2 100644 --- a/android/client/if-audio.c +++ b/android/client/if-audio.c @@ -258,19 +258,26 @@ static void play_p(int argc, const char **argv) if (buffer_size == 0) { haltest_error("Invalid buffer size. Was stream_out opened?\n"); - return; + goto fail; } pthread_mutex_lock(&state_mutex); if (current_state != STATE_STOPPED) { haltest_error("Already playing or stream suspended!\n"); pthread_mutex_unlock(&state_mutex); - return; + goto fail; } pthread_mutex_unlock(&state_mutex); - if (pthread_create(&play_thread, NULL, playback_thread, in) != 0) + if (pthread_create(&play_thread, NULL, playback_thread, in) != 0) { haltest_error("Cannot create playback thread!\n"); + goto fail; + } + + return; +fail: + if (in) + fclose(in); } static void stop_p(int argc, const char **argv) -- 2.47.3