From a1c86eba31c4b60827d59af38320b4b8a71ce019 Mon Sep 17 00:00:00 2001 From: Luiz Augusto von Dentz Date: Thu, 25 Aug 2016 16:50:30 +0300 Subject: [PATCH] build: Fix checking result of sizeof instead of memcmp This can be easily spot when building with clang: emulator/smp.c:373:53: error: size argument in 'memcmp' call is a comparison [-Werror,-Wmemsize-comparison] if (memcmp(conn->pcnf, confirm, sizeof(conn->pcnf) != 0)) { tools/smp-tester.c:596:53: error: size argument in 'memcmp' call is a comparison [-Werror,-Wmemsize-comparison] if (memcmp(data->pcnf, confirm, sizeof(data->pcnf) != 0)) { --- emulator/smp.c | 2 +- tools/smp-tester.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/emulator/smp.c b/emulator/smp.c index 40836cfbb..c30de3666 100644 --- a/emulator/smp.c +++ b/emulator/smp.c @@ -370,7 +370,7 @@ static bool verify_random(struct smp_conn *conn, const uint8_t rnd[16]) conn->ra_type, conn->ra, confirm)) return false; - if (memcmp(conn->pcnf, confirm, sizeof(conn->pcnf) != 0)) { + if (memcmp(conn->pcnf, confirm, sizeof(conn->pcnf)) != 0) { printf("Confirmation values don't match\n"); return false; } diff --git a/tools/smp-tester.c b/tools/smp-tester.c index d24c9b2b4..90b091e04 100644 --- a/tools/smp-tester.c +++ b/tools/smp-tester.c @@ -593,7 +593,7 @@ static bool verify_random(const uint8_t rnd[16]) data->ra_type, data->ra, confirm)) return false; - if (memcmp(data->pcnf, confirm, sizeof(data->pcnf) != 0)) { + if (memcmp(data->pcnf, confirm, sizeof(data->pcnf)) != 0) { tester_warn("Confirmation values don't match"); return false; } -- 2.47.3