From 9886a7557b3cd2e744cfb5d12679228a4caea1aa Mon Sep 17 00:00:00 2001 From: Roman Smirnov Date: Fri, 28 Jun 2024 15:36:46 +0300 Subject: [PATCH] mcp: replace sprintf() with snprintf() in cb_track_duration() Use snprintf() instead of sprintf() to avoid buffer overflow. Found with the SVACE static analysis tool --- profiles/audio/mcp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/profiles/audio/mcp.c b/profiles/audio/mcp.c index 8d1b7588e..0a2991f20 100644 --- a/profiles/audio/mcp.c +++ b/profiles/audio/mcp.c @@ -169,7 +169,7 @@ static void cb_track_duration(struct bt_mcp *mcp, int32_t duration) unsigned char buf[10]; /* MCP defines duration is int32 but api takes it as uint32 */ - sprintf((char *)buf, "%d", duration); + snprintf((char *)buf, 10, "%d", duration); media_player_set_metadata(mp, NULL, "Duration", buf, sizeof(buf)); media_player_metadata_changed(mp); } -- 2.47.3