From 982b9c322e11fa86777eb21fa256176ace8f0736 Mon Sep 17 00:00:00 2001 From: Bharat Panda Date: Fri, 20 Mar 2015 12:05:08 +0530 Subject: [PATCH] obexd/pbap: Fix NULL check to avoid potential crash NULL pointer check for name is done before using the same. --- obexd/plugins/pbap.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/obexd/plugins/pbap.c b/obexd/plugins/pbap.c index cec5acd3f..f2f916622 100644 --- a/obexd/plugins/pbap.c +++ b/obexd/plugins/pbap.c @@ -728,6 +728,11 @@ static void *vobject_list_open(const char *name, int oflag, mode_t mode, int ret; void *request; + if (name == NULL) { + ret = -EBADR; + goto fail; + } + DBG("name %s context %p valid %d", name, context, pbap->cache.valid); if (oflag != O_RDONLY) { @@ -735,11 +740,6 @@ static void *vobject_list_open(const char *name, int oflag, mode_t mode, goto fail; } - if (name == NULL) { - ret = -EBADR; - goto fail; - } - /* PullvCardListing always get the contacts from the cache */ if (pbap->cache.valid) { -- 2.47.3