From 98078c12e677bd992cae5c41e239adbdf3a3a315 Mon Sep 17 00:00:00 2001 From: Szymon Janc Date: Thu, 5 Feb 2015 16:07:09 +0100 Subject: [PATCH] shared/hfp: Fix calling callback without result_pending set Always set pending_result before calling command callback. If response will be send from callback pending_result will be cleared by either hfp_gw_send_result or hfp_gw_send_error. --- src/shared/hfp.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/shared/hfp.c b/src/shared/hfp.c index 0ce312133..ea6494d7d 100644 --- a/src/shared/hfp.c +++ b/src/shared/hfp.c @@ -183,8 +183,8 @@ static void handle_unknown_at_command(struct hfp_gw *hfp, const char *data) { if (hfp->command_callback) { - hfp->command_callback(data, hfp->command_data); hfp->result_pending = true; + hfp->command_callback(data, hfp->command_data); } else { hfp_gw_send_result(hfp, HFP_RESULT_ERROR); } @@ -263,6 +263,7 @@ done: return true; } + hfp->result_pending = true; handler->callback(&context, type, handler->user_data); return true; -- 2.47.3