From 9672cf410f8bf5445df98b221f24c035664fec11 Mon Sep 17 00:00:00 2001 From: Bastien Nocera Date: Thu, 16 May 2024 11:03:11 +0200 Subject: [PATCH] test-runner: Fix uninitialised variable usage Error: UNINIT (CWE-457): [#def64] [important] tools/test-runner.c:701:2: var_decl: Declaring variable "envp" without initializer. tools/test-runner.c:739:3: uninit_use_in_call: Using uninitialized value "*envp" when calling "execve". 737| 738| if (pid == 0) { 739|-> execve(argv[0], argv, envp); 740| exit(EXIT_SUCCESS); 741| } --- tools/test-runner.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/test-runner.c b/tools/test-runner.c index ff5e19825..908327255 100644 --- a/tools/test-runner.c +++ b/tools/test-runner.c @@ -698,7 +698,7 @@ static const char *btvirt_table[] = { static pid_t start_btvirt(const char *home) { const char *btvirt = NULL; - char *argv[3], *envp[2]; + char *argv[3]; pid_t pid; int i; @@ -736,7 +736,7 @@ static pid_t start_btvirt(const char *home) } if (pid == 0) { - execve(argv[0], argv, envp); + execv(argv[0], argv); exit(EXIT_SUCCESS); } -- 2.47.3