From 95838efc07d34c6ac121c65daa3316bf50f0374f Mon Sep 17 00:00:00 2001 From: Luiz Augusto von Dentz Date: Mon, 11 Dec 2023 12:04:59 -0500 Subject: [PATCH] shared/vcp: Fix notification endianness 4db4d5fa1c4f ("shared/vcp: Fix endianness errors") does attempt to fix the endianness of stored volume offset but in the process it broke the notification since the value is no longer stored in the Bluetooth byte order (Little Endian) but instead in the cpu byte order which is then used in the notification as is, to fix this instead of notifying using the stored value it now uses a dedicated variable which does use the value from the request itself. --- src/shared/vcp.c | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/src/shared/vcp.c b/src/shared/vcp.c index 5d163266b..e3451fa2a 100644 --- a/src/shared/vcp.c +++ b/src/shared/vcp.c @@ -683,7 +683,7 @@ static uint8_t vocs_set_vol_offset(struct bt_vocs *vocs, struct bt_vcp *vcp, struct iovec *iov) { struct bt_vcp_db *vdb; - struct vol_offset_state *vstate; + struct vol_offset_state *vstate, state; struct bt_vocs_set_vol_off *req; DBG(vcp, "Set Volume Offset"); @@ -720,9 +720,13 @@ static uint8_t vocs_set_vol_offset(struct bt_vocs *vocs, struct bt_vcp *vcp, /* Increment Change Counter */ vstate->counter = -~vstate->counter; - gatt_db_attribute_notify(vdb->vocs->vos, (void *)vstate, - sizeof(struct vol_offset_state), + /* Notify change */ + state.vol_offset = req->set_vol_offset; + state.counter = vstate->counter; + + gatt_db_attribute_notify(vdb->vocs->vos, (void *)&state, sizeof(state), bt_vcp_get_att(vcp)); + return 0; } -- 2.47.3