From 94f6e7b17c507b325ca3aad58d83671fecb34e32 Mon Sep 17 00:00:00 2001 From: Anderson Lizardo Date: Fri, 24 Aug 2012 17:03:49 -0400 Subject: [PATCH] input: Fix signedness issue on POSIX error code usage By convention, error variables containing POSIX error code (usually called "err") are negative. This commit fixes a couple of places where positive values are expected. --- profiles/input/hog_device.c | 2 +- profiles/input/server.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/profiles/input/hog_device.c b/profiles/input/hog_device.c index 10c5a456c..f0caac8a1 100644 --- a/profiles/input/hog_device.c +++ b/profiles/input/hog_device.c @@ -570,7 +570,7 @@ static gboolean uhid_event_cb(GIOChannel *io, GIOCondition cond, bread = read(fd, &ev, sizeof(ev)); if (bread < 0) { int err = -errno; - DBG("uhid-dev read: %s(%d)", strerror(err), err); + DBG("uhid-dev read: %s(%d)", strerror(-err), -err); goto failed; } diff --git a/profiles/input/server.c b/profiles/input/server.c index 86e2ac8c1..8965c4e79 100644 --- a/profiles/input/server.c +++ b/profiles/input/server.c @@ -180,7 +180,7 @@ static void confirm_event_cb(GIOChannel *chan, gpointer user_data) ba2str(&src, addr); error("input: authorization for %s failed: %s (%d)", - addr, strerror(-ret), ret); + addr, strerror(-ret), -ret); g_io_channel_unref(server->confirm); server->confirm = NULL; -- 2.47.3