From 94a49c70822db9bbad54556fcf3bdede43cce601 Mon Sep 17 00:00:00 2001 From: Rafal Michalski Date: Mon, 13 Jun 2011 12:49:49 +0200 Subject: [PATCH] Fix invalid write to memory issue in A2DP module Under some circumstances (such as terminating bluetoothd during music is streamed) sep object may be destroyed (memory for sep object is internally freed, directly by "a2dp_unregister_sep") after invoking "media_endpoint_clear_configuration" (in "stream_state_changed"). It leads to invalid write issue (reported by valgrind) after assignment "sep->stream = NULL", since "sep" is "alias" pointer to sep object which is already out of date (memory for sep object has been already freed) This patch prevents from this issue by ensuring that assignment "sep->stream = NULL" would be executed when sep object certainly exists. --- audio/a2dp.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/audio/a2dp.c b/audio/a2dp.c index b4ec274e2..f3e7af30e 100644 --- a/audio/a2dp.c +++ b/audio/a2dp.c @@ -371,11 +371,10 @@ static void stream_state_changed(struct avdtp_stream *stream, sep->session = NULL; } - if (sep->endpoint) - media_endpoint_clear_configuration(sep->endpoint); - sep->stream = NULL; + if (sep->endpoint) + media_endpoint_clear_configuration(sep->endpoint); } static gboolean auto_config(gpointer data) -- 2.47.3