From 8f15296d8b3e6f2a42e7bc92fc2c9e6b218f360e Mon Sep 17 00:00:00 2001 From: Dmitry Torokhov Date: Wed, 7 Apr 2021 15:34:18 -0700 Subject: [PATCH] input/hog-lib: avoid scanning characteristics too early We need to have active connection to fully discover a HOG instance, and in the chain bt_hog_new()-> gatt_db_foreach_service()-> foreach_hog_service()-> hog_attach_instance() we have not set up hog->attrib yet. So let's skip calling foreach_hog_chrc() from hog_attach_instance(), especially since we will be calling bt_hog_attach() pretty much immediately after bt_hog_new(), and we will be discovering characteristics there anyway. --- profiles/input/hog-lib.c | 1 - 1 file changed, 1 deletion(-) diff --git a/profiles/input/hog-lib.c b/profiles/input/hog-lib.c index 0f83135a8..ecd15ad73 100644 --- a/profiles/input/hog-lib.c +++ b/profiles/input/hog-lib.c @@ -1458,7 +1458,6 @@ static void hog_attach_instance(struct bt_hog *hog, if (!hog->attr) { hog->attr = attr; - gatt_db_service_foreach_char(hog->attr, foreach_hog_chrc, hog); return; } -- 2.47.3