From 89a85ed6a82dca6f53fa82ad5049f907432c37bc Mon Sep 17 00:00:00 2001 From: Luiz Augusto von Dentz Date: Wed, 23 Oct 2013 13:16:17 +0300 Subject: [PATCH] android: Fix checking return of hal_ipc_cmd hal_ipc_cmd should never return negative values --- android/hal-hidhost.c | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/android/hal-hidhost.c b/android/hal-hidhost.c index a65f24418..a7af27a2e 100644 --- a/android/hal-hidhost.c +++ b/android/hal-hidhost.c @@ -263,6 +263,7 @@ static bt_status_t hh_send_data(bt_bdaddr_t *bd_addr, char *data) static bt_status_t hh_init(bthh_callbacks_t *callbacks) { struct hal_msg_cmd_register_module cmd; + DBG(""); /* store reference to user callbacks */ @@ -270,14 +271,8 @@ static bt_status_t hh_init(bthh_callbacks_t *callbacks) cmd.service_id = HAL_SERVICE_ID_HIDHOST; - if (hal_ipc_cmd(HAL_SERVICE_ID_CORE, HAL_MSG_OP_REGISTER_MODULE, - sizeof(cmd), &cmd, 0, NULL, NULL) < 0) { - error("Failed to register 'hidhost'' service"); - - return BT_STATUS_FAIL; - } - - return BT_STATUS_SUCCESS; + return hal_ipc_cmd(HAL_SERVICE_ID_CORE, HAL_MSG_OP_REGISTER_MODULE, + sizeof(cmd), &cmd, 0, NULL, NULL); } static void hh_cleanup(void) -- 2.47.3