From 84c4c3bedcfb65c27f54ffac452b66608498ba36 Mon Sep 17 00:00:00 2001 From: Szymon Janc Date: Wed, 13 Jun 2012 22:49:21 +0200 Subject: [PATCH] obexd: Fix dead assignments Values stored are never read. --- obexd/client/pbap.c | 2 +- obexd/plugins/filesystem.c | 2 +- obexd/plugins/pbap.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/obexd/client/pbap.c b/obexd/client/pbap.c index 4428c149f..48dbac1c0 100644 --- a/obexd/client/pbap.c +++ b/obexd/client/pbap.c @@ -520,7 +520,7 @@ static DBusMessage *pull_vcard_listing(struct pbap_data *pbap, p = fill_apparam(p, &count, MAXLISTCOUNT_TAG, MAXLISTCOUNT_LEN); offset = GUINT16_TO_BE(offset); - p = fill_apparam(p, &offset, LISTSTARTOFFSET_TAG, LISTSTARTOFFSET_LEN); + fill_apparam(p, &offset, LISTSTARTOFFSET_TAG, LISTSTARTOFFSET_LEN); request = pending_request_new(pbap, message); diff --git a/obexd/plugins/filesystem.c b/obexd/plugins/filesystem.c index 677df766c..e664fc506 100644 --- a/obexd/plugins/filesystem.c +++ b/obexd/plugins/filesystem.c @@ -604,7 +604,7 @@ ssize_t string_read(void *object, void *buf, size_t count) len = MIN(string->len, count); memcpy(buf, string->str, len); - string = g_string_erase(string, 0, len); + g_string_erase(string, 0, len); return len; } diff --git a/obexd/plugins/pbap.c b/obexd/plugins/pbap.c index c6d7cfc90..c7e792a4a 100644 --- a/obexd/plugins/pbap.c +++ b/obexd/plugins/pbap.c @@ -961,7 +961,7 @@ static ssize_t array_read(GByteArray *array, void *buf, size_t count) len = MIN(array->len, count); memcpy(buf, array->data, len); - array = g_byte_array_remove_range(array, 0, len); + g_byte_array_remove_range(array, 0, len); return len; } -- 2.47.3