From 82d40ad07594df2d6fc1f201c592482af0e56285 Mon Sep 17 00:00:00 2001 From: Andrei Emeltchenko Date: Mon, 31 Mar 2014 15:25:11 +0300 Subject: [PATCH] android/avrcp: Fix clang warning Check len before memcpy(). Fixes: ... android/avrcp-lib.c:885:3: warning: Null pointer passed as an argument to a 'nonnull' parameter memcpy(&ptr[4], text[i], len); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ... --- android/avrcp-lib.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/android/avrcp-lib.c b/android/avrcp-lib.c index ec5ffdb75..c01ccbb21 100644 --- a/android/avrcp-lib.c +++ b/android/avrcp-lib.c @@ -1964,7 +1964,10 @@ int avrcp_get_player_attribute_text_rsp(struct avrcp *session, ptr[0] = attrs[i]; put_be16(AVRCP_CHARSET_UTF8, &ptr[1]); ptr[3] = len; - memcpy(&ptr[4], text[i], len); + + if (len) + memcpy(&ptr[4], text[i], len); + ptr += 4 + len; length += 4 + len; } -- 2.47.3