From 7730ff4a3615d4dd6961d5296ee7aab06ce0d5cb Mon Sep 17 00:00:00 2001
From: Syam Sidhardhan <s.syam@samsung.com>
Date: Fri, 14 Sep 2012 21:40:10 +0530
Subject: [PATCH] gstavdtpsink: Free the D-Bus error on reply failure

If D-Bus error is set we should free it.
---
 audio/gstavdtpsink.c | 15 ++++++++++-----
 1 file changed, 10 insertions(+), 5 deletions(-)

diff --git a/audio/gstavdtpsink.c b/audio/gstavdtpsink.c
index ffaed7fbe..601791001 100644
--- a/audio/gstavdtpsink.c
+++ b/audio/gstavdtpsink.c
@@ -786,13 +786,19 @@ static gboolean gst_avdtp_sink_transport_get_properties(GstAvdtpSink *self)
 	msg = dbus_message_new_method_call("org.bluez", self->transport,
 						"org.bluez.MediaTransport",
 						"GetProperties");
+	if (!msg) {
+		GST_ERROR_OBJECT(self, "D-Bus Memory allocation failed");
+		return FALSE;
+	}
+
 	reply = dbus_connection_send_with_reply_and_block(self->data->conn,
 							msg, -1, &err);
+	dbus_message_unref(msg);
 
-	if (dbus_error_is_set(&err) || reply == NULL) {
-		GST_ERROR_OBJECT(self, "Failed to get transport properties: %s",
-					err.message);
-		goto fail;
+	if (dbus_error_is_set(&err)) {
+		GST_ERROR_OBJECT(self, "GetProperties failed: %s", err.message);
+		dbus_error_free(&err);
+		return FALSE;
 	}
 
 	if (!dbus_message_iter_init(reply, &arg_i)) {
@@ -824,7 +830,6 @@ static gboolean gst_avdtp_sink_transport_get_properties(GstAvdtpSink *self)
 	return gst_avdtp_sink_update_caps(self);
 
 fail:
-	dbus_message_unref(msg);
 	dbus_message_unref(reply);
 	return FALSE;
 
-- 
2.47.3