From 72b02df3b2b40a3ac38832e2e80a16eb6b3bef04 Mon Sep 17 00:00:00 2001 From: Alex Studer Date: Fri, 12 Sep 2025 14:20:34 -0400 Subject: [PATCH] profiles/audio/a2dp: Clear suspend timer on A2DP stream free When an A2DP stream is created in start_ind, a timer is set, suspending the AVDTP stream if there have been no users within 5 seconds. However, if the AVDTP stream transitions to the IDLE state before the timer fires, the A2DP stream is freed without the timer being cleared. This meant that when the timer fired, it tried to suspend a stream with a pointer that was previously freed and so segfaulted. This commit fixes that by ensuring that suspend_timer is cleared before freeing the A2DP stream. This was causing random segfaults when connecting my Sony WH-1000XM5 headphones. --- profiles/audio/a2dp.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/profiles/audio/a2dp.c b/profiles/audio/a2dp.c index 6661a95d2..d8f24eaeb 100644 --- a/profiles/audio/a2dp.c +++ b/profiles/audio/a2dp.c @@ -636,6 +636,11 @@ static void a2dp_stream_free(void *data) { struct a2dp_stream *stream = data; + if (stream->suspend_timer) { + timeout_remove(stream->suspend_timer); + stream->suspend_timer = 0; + } + avdtp_unref(stream->session); free(stream); } -- 2.47.3