From 721e40e2a2637b52bc4e0c72d440854abec9b306 Mon Sep 17 00:00:00 2001 From: Jakub Tyszkowski Date: Tue, 16 Dec 2014 13:02:36 +0100 Subject: [PATCH] android/gatt: Fix embedded services not responsing to some requests For application attributes this is triggered when application sends response but for embedded ones we need to trigger this manually. As in prepare and execute write requests handlers, we don't know if it is embedded or application attribute so we should try sending processed request responses if there are any. --- android/gatt.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/android/gatt.c b/android/gatt.c index ce55b2619..08811f875 100644 --- a/android/gatt.c +++ b/android/gatt.c @@ -4413,6 +4413,9 @@ static void send_dev_complete_response(struct gatt_device *device, uint16_t len = 0; uint8_t error = 0; + if (queue_isempty(device->pending_requests)) + return; + if (queue_find(device->pending_requests, match_pending_dev_request, NULL)) { DBG("Still pending requests"); @@ -6512,6 +6515,8 @@ static uint8_t write_prep_request(const uint8_t *cmd, uint16_t cmd_len, return ATT_ECODE_UNLIKELY; } + send_dev_complete_response(dev, cmd[0]); + return 0; } @@ -6571,6 +6576,7 @@ static uint8_t write_execute_request(const uint8_t *cmd, uint16_t cmd_len, } queue_foreach(app_connections, send_server_write_execute_notify, &ev); + send_dev_complete_response(dev, cmd[0]); return 0; } -- 2.47.3