From 4cd67264c36dca10ab64608efa94f02556abdc03 Mon Sep 17 00:00:00 2001 From: Johan Hedberg Date: Tue, 7 Jul 2015 22:20:33 +0300 Subject: [PATCH] client: Fix potential array overflow --- client/gatt.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/client/gatt.c b/client/gatt.c index 737eceafc..0a3adb8c4 100644 --- a/client/gatt.c +++ b/client/gatt.c @@ -421,7 +421,7 @@ static void write_attribute(GDBusProxy *proxy, char *arg) struct iovec iov; uint8_t value[512]; char *entry; - int i; + unsigned int i; for (i = 0; (entry = strsep(&arg, " \t")) != NULL; i++) { long int val; @@ -430,7 +430,7 @@ static void write_attribute(GDBusProxy *proxy, char *arg) if (*entry == '\0') continue; - if (i > 512) { + if (i >= G_N_ELEMENTS(value)) { rl_printf("Too much data\n"); return; } -- 2.47.3