From 4a10293051f43792fe340c493b5e794b55a7bc99 Mon Sep 17 00:00:00 2001 From: Sonny Sasaka Date: Wed, 3 Jun 2020 10:56:00 -0700 Subject: [PATCH] shared/util: Fix undefined behavior of left shift When left-shifting 1, we should be explicit that it is an unsigned 1. --- src/shared/util.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/shared/util.c b/src/shared/util.c index 330a0722a..3b976fa16 100644 --- a/src/shared/util.c +++ b/src/shared/util.c @@ -140,7 +140,7 @@ uint8_t util_get_uid(unsigned int *bitmap, uint8_t max) if (!id || id > max) return 0; - *bitmap |= 1 << (id - 1); + *bitmap |= 1u << (id - 1); return id; } @@ -151,7 +151,7 @@ void util_clear_uid(unsigned int *bitmap, uint8_t id) if (!id) return; - *bitmap &= ~(1 << (id - 1)); + *bitmap &= ~(1u << (id - 1)); } static const struct { -- 2.47.3