From 3f2406997f30e06d910427c7b7c675d69e628c39 Mon Sep 17 00:00:00 2001 From: Miao-chen Chou Date: Wed, 16 Sep 2020 15:34:53 -0700 Subject: [PATCH] sixaxis: Fix crash caused by return of udev_device_get_property_value This adds a NULL check before calling sscanf(). --- plugins/sixaxis.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/plugins/sixaxis.c b/plugins/sixaxis.c index 939fed759..996f85dd6 100644 --- a/plugins/sixaxis.c +++ b/plugins/sixaxis.c @@ -411,7 +411,7 @@ get_pairing_type_for_device(struct udev_device *udevice, uint16_t *bus, hid_id = udev_device_get_property_value(hid_parent, "HID_ID"); - if (sscanf(hid_id, "%hx:%hx:%hx", bus, &vid, &pid) != 3) + if (!hid_id || sscanf(hid_id, "%hx:%hx:%hx", bus, &vid, &pid) != 3) return NULL; cp = get_pairing(vid, pid); -- 2.47.3