From 24c568a3b6899d0c8dcfc920c5536bf63515ca78 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Fr=C3=A9d=C3=A9ric=20Danis?= Date: Thu, 2 Oct 2025 18:11:19 +0200 Subject: [PATCH] shared/hfp: Fix issues found by codacy Move debug string after check of hfp pointer. Add missing argument in debug trace. Signed-off-by: Luiz Augusto von Dentz --- src/shared/hfp.c | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/src/shared/hfp.c b/src/shared/hfp.c index 133bff248..94adccada 100644 --- a/src/shared/hfp.c +++ b/src/shared/hfp.c @@ -2391,11 +2391,11 @@ bool hfp_hf_session_register(struct hfp_hf *hfp, bool hfp_hf_session(struct hfp_hf *hfp) { - DBG(hfp, ""); - if (!hfp) return false; + DBG(hfp, ""); + if (!hfp_hf_register(hfp, slc_brsf_cb, "+BRSF", hfp, NULL)) return false; @@ -2407,15 +2407,15 @@ const char *hfp_hf_call_get_number(struct hfp_hf *hfp, uint id) { struct hf_call *call; - DBG(hfp, ""); - if (!hfp) - return false; + return NULL; + + DBG(hfp, ""); call = queue_find(hfp->calls, call_id_match, UINT_TO_PTR(id)); if (!call) { DBG(hfp, "hf: no call with id: %u", id); - return false; + return NULL; } return call->line_id; @@ -2427,11 +2427,11 @@ bool hfp_hf_call_answer(struct hfp_hf *hfp, uint id, { struct hf_call *call; - DBG(hfp, ""); - if (!hfp) return false; + DBG(hfp, ""); + call = queue_find(hfp->calls, call_id_match, UINT_TO_PTR(id)); if (!call) { DBG(hfp, "hf: no call with id: %u", id); @@ -2440,7 +2440,7 @@ bool hfp_hf_call_answer(struct hfp_hf *hfp, uint id, if (call->status != CALL_STATUS_INCOMING) { DBG(hfp, "hf: %d not in incoming call state: %u", - call->status); + id, call->status); return false; } @@ -2453,11 +2453,11 @@ bool hfp_hf_call_hangup(struct hfp_hf *hfp, uint id, { struct hf_call *call; - DBG(hfp, ""); - if (!hfp) return false; + DBG(hfp, ""); + call = queue_find(hfp->calls, call_id_match, UINT_TO_PTR(id)); if (!call) { DBG(hfp, "hf: no call with id: %u", id); -- 2.47.3