From 1f949a098250c5c7998a3471241251bd0916c56c Mon Sep 17 00:00:00 2001 From: Andrei Emeltchenko Date: Thu, 13 Mar 2014 14:31:57 +0200 Subject: [PATCH] android/handsfree: Check service class is not zero Fixes static analyzers NULL dereference warnings. The similar check is done in src/device.c in line 2959. --- android/handsfree.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/android/handsfree.c b/android/handsfree.c index 7dfc6dc69..36dd32d17 100644 --- a/android/handsfree.c +++ b/android/handsfree.c @@ -1396,7 +1396,7 @@ static void sdp_hsp_search_cb(sdp_list_t *recs, int err, gpointer data) goto fail; } - if (sdp_get_service_classes(recs->data, &classes) < 0) { + if (sdp_get_service_classes(recs->data, &classes) < 0 || !classes) { error("handsfree: unable to get service classes from record"); goto fail; } @@ -1486,7 +1486,7 @@ static void sdp_hfp_search_cb(sdp_list_t *recs, int err, gpointer data) return; } - if (sdp_get_service_classes(recs->data, &classes) < 0) { + if (sdp_get_service_classes(recs->data, &classes) < 0 || !classes) { error("handsfree: unable to get service classes from record"); goto fail; } -- 2.47.3