From 16e1f86a1e10fa9784749bde7cdd16668c98a666 Mon Sep 17 00:00:00 2001 From: Luiz Augusto von Dentz Date: Fri, 11 Nov 2011 16:29:06 +0200 Subject: [PATCH] gobex: make connection id check less strict MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit OBEX spec says: Only the first packet in the request needs to contain the Connection Id header... If a Connection Id header is received with an invalid connection identifier, it is recommended that the operation be rejected with the response code (0xD3) “Service Unavailable”. Since not all requests packets need to contain Connection Id header we should only try to validate it in case a header is received. Reported by Hendrik Sattler --- gobex/gobex.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gobex/gobex.c b/gobex/gobex.c index 8a23485eb..784030459 100644 --- a/gobex/gobex.c +++ b/gobex/gobex.c @@ -694,7 +694,7 @@ static gboolean check_connid(GObex *obex, GObexPacket *pkt) hdr = g_obex_packet_get_header(pkt, G_OBEX_HDR_CONNECTION); if (hdr == NULL) - return FALSE; + return TRUE; g_obex_header_get_uint32(hdr, &id); -- 2.47.3