From 13568564b1ef30ccd14812af2b393f6dfc02b4b1 Mon Sep 17 00:00:00 2001 From: Lucas De Marchi Date: Tue, 5 Jul 2011 17:24:46 -0300 Subject: [PATCH] avrcp: remove unused dbus reply message Fix leak of dbus messages being created but not unreferenced after method returns. --- audio/control.c | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/audio/control.c b/audio/control.c index defbbc86d..c3ef737fd 100644 --- a/audio/control.c +++ b/audio/control.c @@ -1045,13 +1045,8 @@ static DBusMessage *volume_up(DBusConnection *conn, DBusMessage *msg, { struct audio_device *device = data; struct control *control = device->control; - DBusMessage *reply; int err; - reply = dbus_message_new_method_return(msg); - if (!reply) - return NULL; - if (control->state != AVCTP_STATE_CONNECTED) return btd_error_not_connected(msg); @@ -1070,13 +1065,8 @@ static DBusMessage *volume_down(DBusConnection *conn, DBusMessage *msg, { struct audio_device *device = data; struct control *control = device->control; - DBusMessage *reply; int err; - reply = dbus_message_new_method_return(msg); - if (!reply) - return NULL; - if (control->state != AVCTP_STATE_CONNECTED) return btd_error_not_connected(msg); -- 2.47.3