From 097f46d93dab8336a9c70e1f12a12aa8c97cc2db Mon Sep 17 00:00:00 2001 From: Szymon Janc Date: Fri, 2 Mar 2012 15:58:36 +0100 Subject: [PATCH] SAP: Make PADDING4 macro a bit more robust Bitwise operations are done before arithmetic operations and this might cause undesired results if macro is called with parameter of form x+y. --- sap/server.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sap/server.c b/sap/server.c index b8aa8a5c9..b5abd70fb 100644 --- a/sap/server.c +++ b/sap/server.c @@ -49,7 +49,7 @@ #define SAP_UUID "0000112D-0000-1000-8000-00805F9B34FB" #define SAP_SERVER_CHANNEL 8 -#define PADDING4(x) ((4 - (x & 0x03)) & 0x03) +#define PADDING4(x) ((4 - ((x) & 0x03)) & 0x03) #define PARAMETER_SIZE(x) (sizeof(struct sap_parameter) + x + PADDING4(x)) #define SAP_NO_REQ 0xFF -- 2.47.3