diff --git a/android/avrcp-lib.c b/android/avrcp-lib.c
index 587c6ee..29b2935 100644
--- a/android/avrcp-lib.c
+++ b/android/avrcp-lib.c
uint8_t params[0];
} __attribute__ ((packed));
+struct list_values_req {
+ uint8_t attr;
+} __attribute__ ((packed));
+
+struct list_values_rsp {
+ uint8_t number;
+ uint8_t params[0];
+} __attribute__ ((packed));
+
struct avrcp_control_handler {
uint8_t id;
uint8_t code;
void *user_data)
{
struct avrcp_player *player = user_data;
+ struct list_values_req *req;
DBG("");
- if (!params || params_len != 1)
+ if (!params || params_len != sizeof(*req))
return -EINVAL;
- if (params[0] > AVRCP_ATTRIBUTE_LAST ||
- params[0] == AVRCP_ATTRIBUTE_ILEGAL)
+ req = (void *) params;
+ if (req->attr > AVRCP_ATTRIBUTE_LAST ||
+ req->attr == AVRCP_ATTRIBUTE_ILEGAL)
return -EINVAL;
if (!player->ind || !player->ind->list_values)
return -ENOSYS;
- return player->ind->list_values(session, transaction, params[0],
+ return player->ind->list_values(session, transaction, req->attr,
player->user_data);
}
struct avrcp *session = user_data;
struct avrcp_player *player = session->player;
struct avrcp_header *pdu;
+ struct list_values_rsp *rsp;
uint8_t number = 0;
uint8_t *values = NULL;
int err;
goto done;
}
- number = pdu->params[0];
- if (number > 0)
- values = &pdu->params[1];
+ if (pdu->params_len < sizeof(*rsp)) {
+ err = -EPROTO;
+ goto done;
+ }
+
+ rsp = (void *) pdu->params;
+
+ if (rsp->number > 0) {
+ number = rsp->number;
+ values = rsp->params;
+ }
err = 0;