diff --git a/android/gatt.c b/android/gatt.c
index 46dc7f6..c14f789 100644
--- a/android/gatt.c
+++ b/android/gatt.c
uint8_t *value;
int value_len;
- permissions = gatt_db_get_attribute_permissions(gatt_db,
- resp_data->handle);
+ if (!gatt_db_get_attribute_permissions(gatt_db, resp_data->handle,
+ &permissions)) {
+ resp_data->error = ATT_ECODE_ATTR_NOT_FOUND;
+ resp_data->state = REQUEST_DONE;
+ return;
+ }
/*
* Check if it is attribute we didn't declare permissions, like service
if (!len)
return;
- permissions = gatt_db_get_attribute_permissions(gatt_db, handle);
+ if (!gatt_db_get_attribute_permissions(gatt_db, handle, &permissions))
+ return;
+
if (check_device_permissions(dev, cmd[0], permissions))
return;
len = dec_signed_write_cmd(cmd, cmd_len, &handle, value, &vlen, s);
- permissions = gatt_db_get_attribute_permissions(gatt_db, handle);
+ if (!gatt_db_get_attribute_permissions(gatt_db, handle, &permissions))
+ return;
+
if (check_device_permissions(dev, cmd[0], permissions))
return;
if (!len)
return ATT_ECODE_INVALID_PDU;
- permissions = gatt_db_get_attribute_permissions(gatt_db, handle);
+ if (!gatt_db_get_attribute_permissions(gatt_db, handle, &permissions))
+ return ATT_ECODE_ATTR_NOT_FOUND;
error = check_device_permissions(dev, cmd[0], permissions);
if (error)
if (!len)
return ATT_ECODE_INVALID_PDU;
- permissions = gatt_db_get_attribute_permissions(gatt_db, handle);
+ if (!gatt_db_get_attribute_permissions(gatt_db, handle, &permissions))
+ return ATT_ECODE_ATTR_NOT_FOUND;
error = check_device_permissions(dev, cmd[0], permissions);
if (error)
diff --git a/src/shared/gatt-db.c b/src/shared/gatt-db.c
index 998e93e..c11c5d1 100644
--- a/src/shared/gatt-db.c
+++ b/src/shared/gatt-db.c
return service->attributes[0]->handle + service->num_handles - 1;
}
-uint32_t gatt_db_get_attribute_permissions(struct gatt_db *db, uint16_t handle)
+bool gatt_db_get_attribute_permissions(struct gatt_db *db, uint16_t handle,
+ uint32_t *permissions)
{
struct gatt_db_attribute *attribute;
struct gatt_db_service *service;
service = queue_find(db->services, find_service_for_handle,
INT_TO_PTR(handle));
if (!service)
- return 0;
+ return false;
service_handle = service->attributes[0]->handle;
*/
attribute = service->attributes[handle - service_handle];
if (!attribute)
- return 0;
+ return false;
+
+ *permissions = attribute->permissions;
+ return true;
- return attribute->permissions;
}
diff --git a/src/shared/gatt-db.h b/src/shared/gatt-db.h
index f2f2f4d..a88f637 100644
--- a/src/shared/gatt-db.h
+++ b/src/shared/gatt-db.h
uint16_t gatt_db_get_end_handle(struct gatt_db *db, uint16_t handle);
-uint32_t gatt_db_get_attribute_permissions(struct gatt_db *db, uint16_t handle);
+bool gatt_db_get_attribute_permissions(struct gatt_db *db, uint16_t handle,
+ uint32_t *permissions);