Diff between 25cafb36daf00ca66cf2bce40a09f23a3a7aa085 and 322a1de42e05e7b357b97af55a42eadc624b39f5

Changed Files

File Additions Deletions Status
android/gatt.c +28 -12 modified

Full Patch

diff --git a/android/gatt.c b/android/gatt.c
index 06ae5cd..e97677d 100644
--- a/android/gatt.c
+++ b/android/gatt.c
@@ -1024,6 +1024,33 @@ static void hal_srvc_id_to_element_id(const struct hal_gatt_srvc_id *from,
 	bt_uuid128_create(&to->uuid, uuid128);
 }
 
+static bool find_service(int32_t conn_id, struct element_id *service_id,
+				struct gatt_device **dev, struct service **srvc)
+{
+	struct gatt_device *device;
+	struct service *service;
+
+	device = queue_find(conn_list, match_dev_by_conn_id,
+							INT_TO_PTR(conn_id));
+	if (!device) {
+		error("gatt: conn_id=%d not found", conn_id);
+		return false;
+	}
+
+	service = queue_find(device->services, match_srvc_by_element_id,
+								service_id);
+	if (!service) {
+		error("gatt: Service with inst_id: %d not found",
+							service_id->instance);
+		return false;
+	}
+
+	*dev = device;
+	*srvc = service;
+
+	return true;
+}
+
 static void handle_client_get_characteristic(const void *buf, uint16_t len)
 {
 	const struct hal_cmd_gatt_client_get_characteristic *cmd = buf;
@@ -1043,19 +1070,8 @@ static void handle_client_get_characteristic(const void *buf, uint16_t len)
 		return;
 	}
 
-	dev = queue_find(conn_list, match_dev_by_conn_id,
-						INT_TO_PTR(cmd->conn_id));
-	if (!dev) {
-		error("gatt: conn_id=%d not found", cmd->conn_id);
-		status = HAL_STATUS_FAILED;
-		goto done;
-	}
-
 	hal_srvc_id_to_element_id(&cmd->srvc_id, &match_id);
-	srvc = queue_find(dev->services, match_srvc_by_element_id, &match_id);
-	if (!srvc) {
-		error("gatt: Service with inst_id: %d not found",
-							match_id.instance);
+	if (!find_service(cmd->conn_id, &match_id, &dev, &srvc)) {
 		status = HAL_STATUS_FAILED;
 		goto done;
 	}