| e88fe5f9 |
shared/gatt-client: Omit valid errors for primary discovery
BT_ATT_ERROR_ATTRIBUTE_NOT_FOUND shall not cause anything to be printed
since it is a valid response and just mark the end of primary discovery. |
Luiz Augusto von Dentz |
7 years ago |
1 file, +3, -3 |
| 9e3fa053 |
shared/gatt-server: Fix crash on read multiple
When read multiple includes external characteristic, call to
gatt_db_attribute_read's complete callback is asynchronous.
Fix following crash:
Use of uninitialised value of size 8
at 0x49718A: read_multiple_complete_cb (gatt-server.c:994)
by 0x498999: pending_read_result (gatt-db.c:136)
by 0x49A84B: gatt_db_attribute_read_result (gatt-db.c:1787)
by 0x451F4C: read_reply_cb (gatt-database.c:1712)
by 0x48B221: method_call_reply (client.c:972)
by 0x53AB601: ??? (in /usr/lib64/libdbus-1.so.3.19.3)
by 0x53AEF7E: dbus_connection_dispatch (in /usr/lib64/libdbus-1.so.3.19.3)
by 0x486FEF: message_dispatch (mainloop.c:72)
by 0x50CB576: ??? (in /usr/lib64/libglib-2.0.so.0.5400.3)
by 0x50CEB76: g_main_context_dispatch (in /usr/lib64/libglib-2.0.so.0.5400.3)
by 0x50CEF1F: ??? (in /usr/lib64/libglib-2.0.so.0.5400.3)
by 0x50CF231: g_main_loop_run (in /usr/lib64/libglib-2.0.so.0.5400.3)
Invalid read of size 8
at 0x49718A: read_multiple_complete_cb (gatt-server.c:994)
by 0x498999: pending_read_result (gatt-db.c:136)
by 0x49A84B: gatt_db_attribute_read_result (gatt-db.c:1787)
by 0x451F4C: read_reply_cb (gatt-database.c:1712)
by 0x48B221: method_call_reply (client.c:972)
by 0x53AB601: ??? (in /usr/lib64/libdbus-1.so.3.19.3)
by 0x53AEF7E: dbus_connection_dispatch (in /usr/lib64/libdbus-1.so.3.19.3)
by 0x486FEF: message_dispatch (mainloop.c:72)
by 0x50CB576: ??? (in /usr/lib64/libglib-2.0.so.0.5400.3)
by 0x50CEB76: g_main_context_dispatch (in /usr/lib64/libglib-2.0.so.0.5400.3)
by 0x50CEF1F: ??? (in /usr/lib64/libglib-2.0.so.0.5400.3)
by 0x50CF231: g_main_loop_run (in /usr/lib64/libglib-2.0.so.0.5400.3)
Address 0x8 is not stack'd, malloc'd or (recently) free'd |
Szymon Janc |
7 years ago |
1 file, +22, -22 |
| a097cb07 |
tools/bluetooth-player: Add item-generator for change-folder |
ERAMOTO Masaya |
7 years ago |
1 file, +2, -1 |
| a9cf2502 |
tools/bluetooth-player: Merge cmd_play{,_item}() |
ERAMOTO Masaya |
7 years ago |
1 file, +12, -23 |
| 848d1d22 |
Release 5.49 |
Marcel Holtmann |
7 years ago |
2 files, +15, -1 |
| a1a7f093 |
avctp: Fix crash when disconnecting
When disconnecting the channel queue shall not be destroyed before
freeeing all requests including those that already have been processed
otherwise the following crash may happen:
4 errors in context 2 of 103:
Invalid read of size 4
at 0x12A5C2: control_req_destroy (avctp.c:762)
by 0x12A539: pending_destroy (avctp.c:517)
by 0x48A0D48: g_slist_foreach (in /usr/lib/libglib-2.0.so.0.3600.0)
by 0x12A77B: avctp_channel_destroy (avctp.c:553)
by 0x12A801: avctp_disconnected (avctp.c:570)
by 0x12A0F1: control_disconnect (control.c:134)
by 0x1306B9: avrcp_disconnect (avrcp.c:4471)
by 0x17DAE9: btd_service_disconnect (service.c:307)
by 0x18437D: dev_disconn_service (device.c:1405)
by 0x48A0D48: g_slist_foreach (in /usr/lib/libglib-2.0.so.0.3600.0)
by 0x187D87: device_request_disconnect (device.c:1437)
by 0x187EC6: dev_disconnect (device.c:1522)
Address 0x4fde068 is 0 bytes inside a block of size 16 free'd
at 0x48252B3: free (vg_replace_malloc.c:446)
by 0x4888172: g_free (in /usr/lib/libglib-2.0.so.0.3600.0)
by 0x12AB64: avctp_queue_destroy (avctp.c:537)
by 0x48A0D48: g_slist_foreach (in /usr/lib/libglib-2.0.so.0.3600.0)
by 0x48A0D91: g_slist_free_full (in /usr/lib/libglib-2.0.so.0.3600.0)
by 0x12A75E: avctp_channel_destroy (avctp.c:552)
by 0x12A801: avctp_disconnected (avctp.c:570)
by 0x12A0F1: control_disconnect (control.c:134)
by 0x1306B9: avrcp_disconnect (avrcp.c:4471)
by 0x17DAE9: btd_service_disconnect (service.c:307)
by 0x18437D: dev_disconn_service (device.c:1405)
by 0x48A0D48: g_slist_foreach (in /usr/lib/libglib-2.0.so.0.3600.0) |
Luiz Augusto von Dentz |
7 years ago |
1 file, +1, -1 |
| c8bacaff |
build: Include Mesh JSON files unconditionally in EXTRA_DIST
We always want the JSON files to be part of the generated tarball, and
not just when --enable-mesh has been given. |
Johan Hedberg |
7 years ago |
1 file, +1, -1 |
| 5fdcfa51 |
shared/shell: Fix memory leak of wordexp with we_offs
This sets the we_offs variable to zero before do wordfree(). Since it
frees from the elements of the we_wordv array pointed to by the we_offs
variable, memory leak occurs as below:
101 bytes in 1 blocks are definitely lost in loss record 122 of 184
at 0x4C2FA3F: malloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
by 0x4C31D84: realloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
by 0x56E7CD2: w_addchar (wordexp.c:104)
by 0x56E7CD2: parse_dquote (wordexp.c:2200)
by 0x56E7CD2: wordexp (wordexp.c:2349)
by 0x13A6A5: parse_args (shell.c:262)
by 0x13A94D: cmd_exec (shell.c:313)
by 0x13A94D: menu_exec (shell.c:375)
by 0x13AEA4: shell_exec (shell.c:418)
by 0x13BBF1: rl_handler (shell.c:563)
by 0x53C8D72: rl_callback_read_char (in /lib/x86_64-linux-gnu/libreadline.so.7.0)
by 0x13ACE0: input_read (shell.c:1018)
by 0x13C90A: watch_callback (io-glib.c:170)
by 0x4E86E24: g_main_context_dispatch (in /lib/x86_64-linux-gnu/libglib-2.0.so.0.5400.1)
by 0x4E871EF: ??? (in /lib/x86_64-linux-gnu/libglib-2.0.so.0.5400.1)
117 (16 direct, 101 indirect) bytes in 1 blocks are definitely lost in loss record 125 of 184
at 0x4C31D2F: realloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
by 0x56E81C3: w_addword (wordexp.c:182)
by 0x56E81C3: wordexp (wordexp.c:2447)
by 0x13A6A5: parse_args (shell.c:262)
by 0x13B55A: args_completion (shell.c:656)
by 0x13B55A: menu_completion (shell.c:695)
by 0x13B836: shell_completion (shell.c:723)
by 0x53B98B6: ??? (in /lib/x86_64-linux-gnu/libreadline.so.7.0)
by 0x53B9A99: rl_complete_internal (in /lib/x86_64-linux-gnu/libreadline.so.7.0)
by 0x53B02EE: _rl_dispatch_subseq (in /lib/x86_64-linux-gnu/libreadline.so.7.0)
by 0x53B07B5: readline_internal_char (in /lib/x86_64-linux-gnu/libreadline.so.7.0)
by 0x53C8F84: rl_callback_read_char (in /lib/x86_64-linux-gnu/libreadline.so.7.0)
by 0x13ACE0: input_read (shell.c:1018)
by 0x13C90A: watch_callback (io-glib.c:170) |
ERAMOTO Masaya |
7 years ago |
1 file, +6, -0 |
| a25dcec6 |
shared/shell: Fix memory leak when parsing args
When running the command having mandatory arguments, memory leak occurs
as below:
1 bytes in 1 blocks are definitely lost in loss record 2 of 184
at 0x4C2FB0F: malloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
by 0x5679C99: strdup (strdup.c:42)
by 0x13A976: cmd_exec (shell.c:327)
by 0x13A976: menu_exec (shell.c:375)
by 0x13AEA4: shell_exec (shell.c:418)
by 0x13BBF1: rl_handler (shell.c:563)
by 0x53C8D72: rl_callback_read_char (in /lib/x86_64-linux-gnu/libreadline.so.7.0)
by 0x13ACE0: input_read (shell.c:1018)
by 0x13C90A: watch_callback (io-glib.c:170)
by 0x4E86E24: g_main_context_dispatch (in /lib/x86_64-linux-gnu/libglib-2.0.so.0.5400.1)
by 0x4E871EF: ??? (in /lib/x86_64-linux-gnu/libglib-2.0.so.0.5400.1)
by 0x4E87501: g_main_loop_run (in /lib/x86_64-linux-gnu/libglib-2.0.so.0.5400.1)
by 0x13D244: mainloop_run (mainloop-glib.c:73)
7 bytes in 1 blocks are definitely lost in loss record 12 of 184
at 0x4C2FB0F: malloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
by 0x5679C99: strdup (strdup.c:42)
by 0x139EEA: strdelimit (util.c:991)
by 0x13B66A: args_completion (shell.c:668)
by 0x13B66A: menu_completion (shell.c:695)
by 0x13B836: shell_completion (shell.c:723)
by 0x53B98B6: ??? (in /lib/x86_64-linux-gnu/libreadline.so.7.0)
by 0x53B9A99: rl_complete_internal (in /lib/x86_64-linux-gnu/libreadline.so.7.0)
by 0x53B02EE: _rl_dispatch_subseq (in /lib/x86_64-linux-gnu/libreadline.so.7.0)
by 0x53B07B5: readline_internal_char (in /lib/x86_64-linux-gnu/libreadline.so.7.0)
by 0x53C8F84: rl_callback_read_char (in /lib/x86_64-linux-gnu/libreadline.so.7.0)
by 0x13ACE0: input_read (shell.c:1018)
by 0x13C90A: watch_callback (io-glib.c:170)
9 bytes in 1 blocks are definitely lost in loss record 21 of 184
at 0x4C2FB0F: malloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
by 0x5679C99: strdup (strdup.c:42)
by 0x13B53F: args_completion (shell.c:654)
by 0x13B53F: menu_completion (shell.c:695)
by 0x13B836: shell_completion (shell.c:723)
by 0x53B98B6: ??? (in /lib/x86_64-linux-gnu/libreadline.so.7.0)
by 0x53B9A99: rl_complete_internal (in /lib/x86_64-linux-gnu/libreadline.so.7.0)
by 0x53B02EE: _rl_dispatch_subseq (in /lib/x86_64-linux-gnu/libreadline.so.7.0)
by 0x53B07B5: readline_internal_char (in /lib/x86_64-linux-gnu/libreadline.so.7.0)
by 0x53C8F84: rl_callback_read_char (in /lib/x86_64-linux-gnu/libreadline.so.7.0)
by 0x13ACE0: input_read (shell.c:1018)
by 0x13C90A: watch_callback (io-glib.c:170)
by 0x4E86E24: g_main_context_dispatch (in /lib/x86_64-linux-gnu/libglib-2.0.so.0.5400.1)
9 bytes in 1 blocks are definitely lost in loss record 22 of 184
at 0x4C2FB0F: malloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
by 0x5679CE9: strndup (strndup.c:43)
by 0x13A9EB: cmd_exec (shell.c:301)
by 0x13A9EB: menu_exec (shell.c:375)
by 0x13AEA4: shell_exec (shell.c:418)
by 0x13BBF1: rl_handler (shell.c:563)
by 0x53C8D72: rl_callback_read_char (in /lib/x86_64-linux-gnu/libreadline.so.7.0)
by 0x13ACE0: input_read (shell.c:1018)
by 0x13C90A: watch_callback (io-glib.c:170)
by 0x4E86E24: g_main_context_dispatch (in /lib/x86_64-linux-gnu/libglib-2.0.so.0.5400.1)
by 0x4E871EF: ??? (in /lib/x86_64-linux-gnu/libglib-2.0.so.0.5400.1)
by 0x4E87501: g_main_loop_run (in /lib/x86_64-linux-gnu/libglib-2.0.so.0.5400.1)
by 0x13D244: mainloop_run (mainloop-glib.c:73) |
ERAMOTO Masaya |
7 years ago |
1 file, +11, -1 |
| 169aa558 |
device: Fix missing Paired property change on non-bonded device
If device is paired but not bonded than Paired property should be
also updated when device is disconnected. |
Szymon Janc |
7 years ago |
1 file, +10, -1 |
| 7a345dde |
Fix storage for adapters without public address
Since those have adapter folder prefixed with "static-" this needs
to be taken into account when storing data. |
Szymon Janc |
7 years ago |
3 files, +54, -60 |
| 5b890a19 |
advertising: Fix crash when if client invalidate property
If a property is invalidated the iter is set to NULL which should be
checked and properly reset. |
Luiz Augusto von Dentz |
7 years ago |
1 file, +54, -0 |
| 32bcd5a3 |
advertising: Fix creating another mgmt instance
adapter already instanciate a instance of mgmt so just reuse that
instead of creating a new one. |
Luiz Augusto von Dentz |
7 years ago |
3 files, +11, -9 |
| dfd5144e |
mesh: Add sample JSON files to EXTRA_DIST
This adds mesh/local_node.json and mesh/prov_db.json samples
to be included with dist tarball. |
Inga Stotland |
7 years ago |
1 file, +2, -0 |
| feddc824 |
Remove obsolete Debian notes from HACKING
The HACKING document says that Debian's automake version doesn't satisfy
the automake >= 1.10 requirement, but this is no longer true. The
automake version in Debian 8 (oldstable) is 1.14 and the version in
Debian 9 (stable) is 1.15. |
David Frey |
7 years ago |
1 file, +1, -10 |
| 6d8260cf |
device: Fix bearer selection with single mode controller
If remote device is dual mode and advertises without "BR/EDR flag
not supported" set than device is marked as supporting BR/EDR
even if controller is doing LE only. This results in bluetoothd
trying to connect over BR/EDR since this is prefered transport
if none is connected.
Fix this by checking if adapter supports specified technology
before doing heuristic transport selection. |
Szymon Janc |
7 years ago |
3 files, +10, -1 |
| ea072a63 |
tools/btpclient: Add connect device command
This patch adds support for connect device command. |
Grzegorz Kolodziejczyk |
7 years ago |
1 file, +84, -2 |
| caf7d2aa |
tools/btpclient: Add identity resolve event
This patch adds identity resolve event handler. |
Grzegorz Kolodziejczyk |
7 years ago |
1 file, +50, -1 |
| 73ff4f44 |
tools/btpclient: Add solicit uuid16 service list support for ad
This patch adds support to get/set solicit uuid16 service list in
advertising data. |
Grzegorz Kolodziejczyk |
7 years ago |
1 file, +35, -0 |
| 2aee4893 |
tools/btpclient: Check if dev is connected in device found ev routine
Device may be connected while device found event is generated thus thus
btp should generate additional device connected event also. |
Grzegorz Kolodziejczyk |
7 years ago |
1 file, +23, -9 |
| 1cf57a43 |
tools/btpclient: Add passkey confirm event
This patch adds support for send passkey confirm event when requested. |
Grzegorz Kolodziejczyk |
7 years ago |
1 file, +34, -4 |
| 704b2973 |
tools/btpclient: Add btp disconnect handler
This patch adds btp disconnect handler to btp client. |
Grzegorz Kolodziejczyk |
7 years ago |
1 file, +8, -0 |
| 9273cf2c |
tools/btpclient: Remove btp unsupported auth request call
BTP don't support authorization request event. |
Grzegorz Kolodziejczyk |
7 years ago |
1 file, +4, -34 |
| 0f14575d |
tools/btpclient: Add support for including tx-power to ad
This patch allows to set tx-power in advertising data. |
Grzegorz Kolodziejczyk |
7 years ago |
1 file, +7, -0 |
| 846cd115 |
tools/btpclient: Fix setting supported includes includes
Included values should be string type instead of address of pointer to
string. |
Grzegorz Kolodziejczyk |
7 years ago |
1 file, +3, -3 |
| ae589a34 |
tools/bluetooth-player: Fix lines going beyond 80 columns |
Luiz Augusto von Dentz |
7 years ago |
1 file, +2, -1 |
| 6e559855 |
tools/obexctl: mesh: Fix lines going beyond 80 columns |
Luiz Augusto von Dentz |
7 years ago |
1 file, +2, -1 |
| 480ff696 |
mesh: Fix lines going beyond 80 columns |
Luiz Augusto von Dentz |
7 years ago |
4 files, +24, -16 |
| 41465ce5 |
client: Fix lines going beyond 80 columns |
Luiz Augusto von Dentz |
7 years ago |
2 files, +22, -12 |
| 093d42d3 |
dbus-common: Remove unused functions |
ERAMOTO Masaya |
7 years ago |
3 files, +4, -90 |
| b81f6b3c |
unit/test-gdbus-client: Use g_dbus_dict_append_entry() |
ERAMOTO Masaya |
7 years ago |
1 file, +3, -35 |
| 477575bc |
tools/bluetooth-player: Use g_dbus_dict_append_entry() |
ERAMOTO Masaya |
7 years ago |
1 file, +3, -35 |
| b169f28b |
tools/obexctl: Use g_dbus_dict_append_entry() |
ERAMOTO Masaya |
7 years ago |
1 file, +2, -34 |
| 3b4008d0 |
mesh: Use g_dbus_dict_append_{entry,array}() |
ERAMOTO Masaya |
7 years ago |
1 file, +8, -92 |
| 23736599 |
client: Use g_dbus_dict_append_*() |
ERAMOTO Masaya |
7 years ago |
2 files, +11, -147 |
| 53f064d5 |
obexd: Remove unused source/header files for dbus
Due to using g_dbus_emit_property_changed() and g_dbus_get_properties(),
obex_dbus_signal_property_changed() is unused since commit 96063756
("obex-client: Rename org.bluez.obex.Transfer to Transfer1"), and
OBC_PROPERTIES_ARRAY_SIGNATURE macro is unused since commit 3eadc034
("obex-client: Make use of g_dbus_get_properties to get transfer properties"). |
ERAMOTO Masaya |
7 years ago |
7 files, +0, -147 |
| 2bb53924 |
obexd: Use g_dbus_dict_append_entry() |
ERAMOTO Masaya |
7 years ago |
3 files, +9, -42 |
| abcffedf |
gdbus: Introduce functions appending to dbus message |
ERAMOTO Masaya |
7 years ago |
2 files, +106, -38 |
| 6523d168 |
tools/btmgmt: Port to use bt_shell
This replaces the direct usage of readline with bt_shell. |
Luiz Augusto von Dentz |
7 years ago |
1 file, +534, -998 |
| c214c5e5 |
shared/shell: Fix parsing of mandatory arguments
In certain cases the arguments may no start with the mandatory commands
such as when the command handler expects getopt arguments first. |
Luiz Augusto von Dentz |
7 years ago |
1 file, +14, -3 |
| 1c3282e1 |
shared/shell: Add bt_shell_usage
bt_shell_usage can be used to print the usage of the current command
in execution. |
Luiz Augusto von Dentz |
7 years ago |
2 files, +15, -0 |
| 5d24fe74 |
mesh/meshctl: Quit when done with command
This ensures that the commands don't stay hanging since bt_shell no
longer quits immediatelly after executing a command. |
Luiz Augusto von Dentz |
7 years ago |
3 files, +202, -91 |
| b01d6c27 |
tools/obexctl: Quit when done with command
This ensures that the commands don't stay hanging since bt_shell no
longer quits immediatelly after executing a command. |
Luiz Augusto von Dentz |
7 years ago |
1 file, +148, -81 |
| 487acb2a |
tools/bluetooth-player: Quit when done with command
This ensures that the commands don't stay hanging since bt_shell no
longer quits immediatelly after executing a command. |
Luiz Augusto von Dentz |
7 years ago |
1 file, +102, -64 |
| 936ad5ef |
client: Quit when done with command
This ensures that the commands don't stay hanging since bt_shell no
longer quits immediatelly after executing a command. |
Luiz Augusto von Dentz |
7 years ago |
4 files, +242, -120 |
| ac04719e |
shared/shell: Allow executing submenu commands
This makes it possible to execute submenu commands directly from the
main menu by using the format <submenu>.<command>:
[bluetooth]# advertise.uuids 0x1820
[bluetooth]# advertise.name blah
[bluetooth]# advertise on
Advertising object registered
UUID: Internet Protocol Support(0x1820)
Tx Power: off
LocalName: blah
Apperance: off |
Luiz Augusto von Dentz |
7 years ago |
1 file, +33, -2 |
| 0c2900e5 |
shared/shell: Disable readline while in noninteractive mode
User shall not be able to interact with the shell while in
noninteractive mode. |
Luiz Augusto von Dentz |
7 years ago |
1 file, +21, -4 |
| deae158e |
shared/shell: Disable bt_shell_prompt_input in noninteractive mode
Only the input given as argument shall be processed, all the rest shall
be ignored. |
Luiz Augusto von Dentz |
7 years ago |
1 file, +3, -0 |
| f718b35b |
shared/shell: Fix not handling sort options
getopt_long index is only valid for long options. |
Luiz Augusto von Dentz |
7 years ago |
1 file, +8, -1 |
| 9cafbbb1 |
shared/shell: Do not quit immediatelly on noninteractive mode
The command handler shall be able to tell when it is done by calling
bt_shell_noninteractive_quit. |
Luiz Augusto von Dentz |
7 years ago |
1 file, +1, -4 |