| cb3088b5 |
mesh: Debug output clean up
This changes l_info() to l_debug() for recurring cases and
removes some excessive debug output. |
Inga Stotland |
5 years ago |
6 files, +60, -135 |
| c0509b12 |
mesh: Helper packet print should depend on debug setting
This changes the utility function print_packet() to check if
daemon is running in debug mode. |
Inga Stotland |
5 years ago |
3 files, +14, -1 |
| 2a0ae829 |
a2dp: Fix double free in load_remote_sep
This patch fixes a double free condition in load_remote_sep. Value is
freed, then the inner loop is broken, but the rest of the outer loop
will attempt to free value again. |
Alain Michaud |
5 years ago |
1 file, +0, -1 |
| 390c2b08 |
a2dp: Fix ref counting bug of setup_unref
In a2dp_reconfig, setup is ref-counted by cb_data. However, in the fail
label setup is unref-ed but cb_data is not cleared. This may cause
double unref in the future if cb_data gets executed. Instead, we should
do setup_cb_free to clear cb_data and unref setup. |
Sonny Sasaka |
5 years ago |
1 file, +1, -1 |
| 8486b4cd |
adapter: Fix not removing client from discovery list
If command MGMT_OP_START_DISCOVERY fails we reply with btd_error_busy
but we don't remove the client from the list which would prevent the
client to start it once again. |
Luiz Augusto von Dentz |
5 years ago |
1 file, +113, -112 |
| ba91d0ad |
avrcp: Don't attempt to load settings if on volume changed is supported
If only volume changed is supported that means the player cannot really
indicate track/metadata changes so don't attempt to read them. |
Luiz Augusto von Dentz |
5 years ago |
1 file, +4, -0 |
| b7fe84c4 |
avrcp: Fix always requesting player settings for category 1
Player Application settings is not mandatory for category 1 so instead
of always listing the settings the code now checks if
AVRCP_FEATURE_PLAYER_SETTINGS is enabled. |
Luiz Augusto von Dentz |
5 years ago |
1 file, +2, -1 |
| 7f779641 |
shared/shell: don't hook io_hup on non-interactive
When we are in non-interactive mode (data.mode == 1), we should not
terminate the mainloop when stdin is disconnected.
For example, in bash, the following command would terminate immediately
without any output.
: | btmgmt info |
Stimim Chen |
5 years ago |
1 file, +3, -3 |
| 92876b24 |
advertising: Fix advertising flags
When an instance wants to force being discoverable the code shall
actually check if the adapter is in general disverable mode already and
if not set BR/EDR as not supported so that devices scanning don't
assume BR/EDR PHY is connectable when in fact it isn't. |
Luiz Augusto von Dentz |
5 years ago |
1 file, +6, -3 |
| d317e8e6 |
emulator: Use master settings for CIS params
The slave will be the first to respond with CIS Estabished but only the
master has the CIG params set so this switch to master so parameters are
proper. |
Luiz Augusto von Dentz |
5 years ago |
1 file, +5, -2 |
| ba4289c7 |
mesh: Destroy PB-ADV queue when provisioning done |
Brian Gix |
5 years ago |
1 file, +5, -0 |
| c80f88bd |
mesh: Fix leaked message reference |
Brian Gix |
5 years ago |
1 file, +2, -1 |
| 90841721 |
mesh: Fix leaked mesh_net allocation |
Brian Gix |
5 years ago |
1 file, +0, -2 |
| 29d73773 |
mesh: Fix using uninitialized bytes
Fixes two problems found with static analysis |
Brian Gix |
5 years ago |
2 files, +3, -0 |
| ebed46f0 |
mesh: Clean up Join() method
This consolidates various places where a pending response
to Join() is created and makes sure that l_dus_message_unref()
is called correctly. |
Inga Stotland |
5 years ago |
1 file, +22, -27 |
| 9dd9cba0 |
mesh: Fix memory leak in Create, Import & Attach methods
This ensures that every time l_dbus_message_ref() is used to preserve
a message for a pending method reply, there is a matching call to
l_dbus_message_unref(). |
Inga Stotland |
5 years ago |
1 file, +4, -0 |
| 7a500717 |
mesh: Clean up Attach() method call
This consolidates error return form one place: off a callback
with unsuccessful status. |
Inga Stotland |
5 years ago |
3 files, +16, -29 |
| 1b7d8795 |
mesh: Clean up Import() method call
This removes unnecessary failing conditions in Import() call and
simplifies iterations through "flags" dictionary. |
Inga Stotland |
5 years ago |
3 files, +9, -29 |
| dedc3cb2 |
mesh: Create a queue of pending requests in mesh_init()
This removes unnnecessary checking for queue existence every time
either Attach(), Create() or Import() methods are called. |
Inga Stotland |
5 years ago |
1 file, +4, -10 |
| b0adb615 |
mesh: Remove unused function prototypes from node.h |
Inga Stotland |
5 years ago |
1 file, +0, -2 |
| 7cdc215f |
mesh: Add finalization of a newly created node
When a new node is created as a result of successful completion
of either Join() or Create() or Import() methods and has been
confirmed via successful token delivery to the application,
clean up node's D-Bus resources (application path, element paths, etc)
that have been gathered during the initial GetMAnagedObjects() call.
Also, remove the agent instance associaed with the new node.
These resources will be re-populated after the Attach() call
verifies the node's integrity. |
Inga Stotland |
5 years ago |
3 files, +28, -16 |
| 7eca3bec |
mesh: Remove agent when freeing node's dynamic resources
This adds clean up of node's agent instance when node's dynamic
resources are freed. |
Inga Stotland |
5 years ago |
1 file, +1, -0 |
| f5fcab32 |
mesh: Free allocated agent in mesh_remove_agent()
This adds previously missing call to free memory allocated
for agent structure. |
Inga Stotland |
5 years ago |
1 file, +4, -6 |
| 8afaf5e9 |
mesh: Remove unused structure member
This removes unused "agent" member from join_data structure. |
Inga Stotland |
5 years ago |
1 file, +0, -3 |
| 1450819e |
emulator: Don't require ACL connection for Setup ISO Data Path
LE Setup ISO Data Path can be used even before the ACL handle exists
when master since Set CIG Parameters will respond with ISO handle it
can then be used to setup the data path in advance of ACL connection. |
Luiz Augusto von Dentz |
5 years ago |
1 file, +1, -1 |
| 440b07fa |
test/example-advertisement: Fix include_tx_power
Adding the Tx Power Level is no longer done via IncludeTxPower, but via
the tx-power value in the Includes array. The previous code did not
throw an error, but neither led to the insertion of the value. As a
result of this change, include_tx_power now adds the Tx Power Level
again. |
Alvar Penning |
5 years ago |
1 file, +3, -3 |
| 58f2fcdc |
doc/settings-storage: Update documentation of Endpoints
Add documentation of DelayReporting storage as that has been added to
the cache. |
Luiz Augusto von Dentz |
5 years ago |
1 file, +4, -3 |
| e5e5ad9f |
a2dp: Store Delay Reporting capability
This stores Delay Reporting capability so it is properly restored when
loading from cache. |
Luiz Augusto von Dentz |
5 years ago |
3 files, +50, -14 |
| 18c90914 |
doc/media-api: Add documentation for DelayReporting
The code was expecting the endpoint to expose
MediaEndpoint.DelayReporting property in order to expose
MediaTransport.Delay property. |
Luiz Augusto von Dentz |
5 years ago |
1 file, +4, -0 |
| adfbafe9 |
a2dp: Fix caching endpoints for unknown version
Don't cache the capabilities of endpoints which the version is unknown
since so capabilities may not be available in such case. |
Luiz Augusto von Dentz |
5 years ago |
3 files, +16, -3 |
| 0e8ed1f2 |
mesh: Fix double-free
This fixes a double-free error when destroying the NVM storage of a mesh node.
Cleanly handle two distinct scenarios:
1. When the node is being deleted at runtime. This causes release of
both dynamic memory and NVM storage.
2. During shutdown, we release dynamic memory only. |
Brian Gix |
5 years ago |
3 files, +9, -18 |
| 5b653695 |
lib: Update company identifiers |
Marcel Holtmann |
5 years ago |
1 file, +41, -3 |
| e85c65c1 |
doc: Add information about management version 1.17 |
Marcel Holtmann |
5 years ago |
1 file, +6, -1 |
| e5bb5fa8 |
HACKING: Mention disabling SELinux
Running bluetoothd from the build directory I noticed that as soon as
a bluetooth audio device was connect, bluetoothd would be disconnected
from dbus and print
Disconnected from D-Bus. Exiting.
Luiz Augusto von Dentz suggested trying with SELinux disabled and that
solved the problem.
This patch just documents how to disable SELinux before running
bluetoothd from the build directory. I would love to say more about
why that is needed, but could not find anything on the audit log. |
Rafael Ávila de Espíndola |
5 years ago |
1 file, +3, -0 |
| a106a3ae |
doc/advertisement-monitor-api: Rename methods and shorten the preset strings
This renames RegisterApplication/UnregisterApplication to
RegisterMonitor/UnregisterMonitor and shortens the strings used in some
properties. |
Miao-chen Chou |
5 years ago |
1 file, +4, -4 |
| 9382afca |
hog: Set vendor, product and version for all instances
Set the the correct vendor and product ids for all UHID/HoG
devices when they are unknown at HoG creation time.
Before this change, when connecting a BT device with multiple HoG
services for the first time, only the first HoG instance's vendor,
product and version fields would be set by the DIS callback. This meant
that all HoG instances except the first would be left with unset values
and their UHID devices would then be created with '0000:0000' as their
vendor:product ids. |
Haakon Drews |
5 years ago |
1 file, +9, -0 |
| de492ac8 |
emulator: Fix not reporting LE Set Default PHY as supported
LE Set Default PHY (Octet 35 - Bit 5) is in fact supported. |
Luiz Augusto von Dentz |
5 years ago |
1 file, +1, -0 |
| 8496a438 |
build: Move --enable-hid2hci later in the list options |
Marcel Holtmann |
5 years ago |
1 file, +5, -5 |
| 36607067 |
build: Enable the hid2hci tool for developers by default |
Marcel Holtmann |
5 years ago |
1 file, +1, -0 |
| 15e8fbfd |
build: Add an option to explicitly enable hid2hci
hid2hci is no longer a common use. This patch changes the default to not
build and install hid2hci and provide a configure flag --enable-hid2hci
to explicitly enable it. |
Sonny Sasaka |
5 years ago |
1 file, +3, -1 |
| 2cd067b8 |
mesh: Fix segfault caused by re-enabling of HCI controller
This fixes the crash that occurs when a controller used by bluetooth-meshd
is removed and then added back again.
Also, correctly restart scanning when the controller is re-enabled.
Backtrace:
0x00005618e754d040 in ?? ()
0x00005618e6e12d9a in io_ready_callback () at mesh/mesh.c:174
0x00005618e6e3d2c8 in l_queue_foreach () at ell/queue.c:441
0x00005618e6e37927 in request_complete () at src/shared/mgmt.c:261 |
Inga Stotland |
5 years ago |
2 files, +87, -57 |
| d18cb97b |
mesh: Fix valgrind memory leak warnings
These warnings are caused by not completely freeing memory allocations
at shutdown, and are not serious, but they make valgrind output cleaner. |
Brian Gix |
5 years ago |
6 files, +25, -2 |
| cc0719ce |
mesh: Fix valgrind memory leaks
These memory leaks are ones that will compound over time with node
creation and deletion. |
Brian Gix |
5 years ago |
3 files, +13, -9 |
| a51871bd |
mesh: Remove redundant call to save node configuration
This removes a redundant call to save node configuration in
add_local_node(): there is a number of unconditional calls to
mesh_config_write_<some_node_Setting>() within this function
which would result in the node configuration being saved implicitly. |
Inga Stotland |
5 years ago |
1 file, +0, -2 |
| 8a382262 |
mesh: Allow updating CID, PID, VID & CRPL on node attach
This allows to update settings of the following composition fields
when an existing node (application) attaches to the daemon:
Company ID (CID), Product ID (PID), Versioin ID (VID),
CRPL (replay protection depth) |
Inga Stotland |
5 years ago |
3 files, +53, -0 |
| b91f6f0b |
mesh: Avoid saving duplicate fields in node config
This modifies miscellaneous utility functions in mesh-config-json.c:
when writing a new value to a node configuration file, delete
the existing field containing an old value first. |
Inga Stotland |
5 years ago |
1 file, +14, -10 |
| 17dc8d1f |
test: Fix payload and model opcode packing in test-mesh
Use correct packing of multi-byte values in message payload bytearray.
For example, a 2-byte opcode 0x8204 is packed as 0x82 0x04, i.e. in
natural order.
Add transaction ID parameter to "set" commands of generic On/Off
model. Server will ignore the identical commands with the same
transaction ID, source and destination during a timeout period
of 6 seconds. |
Inga Stotland |
5 years ago |
1 file, +69, -25 |
| 572f0eb5 |
emulator: Fix response to LE Setup ISO Data Path
LE Setup ISO Data Path expects the connection handle to be part of the
response. |
Luiz Augusto von Dentz |
5 years ago |
1 file, +9, -6 |
| 81b3f4e6 |
monitor: Fix parsing of LE Setup ISO Data Path response
LE Setup ISO Data Path response actually contains the handle in addition
to the status:
> HCI Event: Command Complete (0x0e) plen 6
LE Setup Isochronous Data Path (0x08|0x006e) ncmd 1
Status: Success (0x00)
Handle: 44 |
Luiz Augusto von Dentz |
5 years ago |
2 files, +20, -1 |
| f52def15 |
tools/btgatt-client: Add option to set BT_SECURITY_FIPS
Needed for GAP/SEC/SEM/BI-10-C. |
Łukasz Rymanowski |
5 years ago |
1 file, +4, -2 |