| e65494e3 |
mesh: Fix memory leaks
The dir variable needs to be closed before leaving. |
Steve Grubb |
4 years ago |
1 file, +3, -1 |
| d6fc849f |
monitor: Fix possible crash of rfcomm packet
When RFCOMM_TEST_EA returns false, btmon assumes packet data has at
least 5 bytes long. If that assumption fails, btmon could crash when
trying to read the next byte.
This patch fix it by checking the remaining size before reading the last
byte.
Reviewed-by: apusaka@chromium.org |
Yun-Hao Chung |
4 years ago |
1 file, +3, -0 |
| 6d43ca44 |
btmgmt: Fix enable adding irk when turining privacy on
Unable to add the IRK in btmgmt when need to be updated. The option is
enabled now. |
Sathish Narasimman |
4 years ago |
1 file, +1, -1 |
| 4bc2a223 |
shared/shell: Print help info for individual commands
For menus with long list of entries, it is useful to be able invoke
help message for an individual entry to look up command description and
synopsis.
Can be invoked by entering "<command> help" or "<command> --help". |
Inga Stotland |
4 years ago |
1 file, +10, -0 |
| 022eda58 |
btdev: Fix crashing if ISO link is in fact a BIS
BIS doesn't not have necessarily needs a link if there is no sync in
place. |
Luiz Augusto von Dentz |
4 years ago |
1 file, +2, -1 |
| 4e7780d0 |
client/advertising: Add support for setting min/max intervals
This adds support for setting MinInterval/MaxInterval. |
Luiz Augusto von Dentz |
4 years ago |
3 files, +108, -0 |
| 5657a511 |
mesh: Add missing "storage" option to help menu
This adds a previously missing entry for "storage" option
when printing the daemon usage info. |
Inga Stotland |
4 years ago |
1 file, +2, -1 |
| d8397fe2 |
config: Change the config option for manpages
The current config option for manpages provided by the configure.ac
alwasys enables the manpages whether 'enable-manpages' option is
specified or not. To clarify the expected behavior, this patch changes
the manpages option to 'disable-manpages' so the manpages are alwasy
enabled unless the '--disable-manpages' option is specified. |
Tedd Ho-Jeong An |
4 years ago |
1 file, +4, -4 |
| db40060a |
config: Show error if rst2man not found when manpages are enabled
This patch adds a check if the conversion tool is installed when the
manpages is enabled, and show error if it is not installed. |
Tedd Ho-Jeong An |
4 years ago |
1 file, +3, -0 |
| fa57cb68 |
monitor: Remove Pygments dependency from manpage
This patch removes the Pygments dependency from btmon .rst file.
When the code-block type is specified, the rst2man throws a warning
asking for Pygments package. |
Tedd Ho-Jeong An |
4 years ago |
1 file, +2, -2 |
| be73408f |
btdev: Mark LE Periodic Advertising bit as supported
This enables LE Periodic Advertising bit on LE Read Local Supported
Features:
> HCI Event: Command Complete (0x0e) plen 12
LE Read Local Supported Features (0x08|0x0003) ncmd 1
Status: Success (0x00)
Features: 0x00 0x39 0x00 0xf0 0x01 0x00 0x00 0x00
LE 2M PHY
LE Coded PHY
LE Extended Advertising
LE Periodic Advertising
Connected Isochronous Stream - Master
Connected Isochronous Stream - Slave
Isochronous Broadcaster
Synchronized Receiver
Isochronous Channels (Host Support) |
Luiz Augusto von Dentz |
4 years ago |
1 file, +1, -0 |
| 2a4f9ddc |
build: Add generated manpages to distribute list
This patch adds generated manpages to the distribution list. |
Tedd Ho-Jeong An |
4 years ago |
1 file, +2, -1 |
| 3ca24567 |
gitignore: Add generated files to the ignore list
This patch adds generated files like manpages and binaries to the
ignore list so it won't show with 'git status'. |
Tedd Ho-Jeong An |
4 years ago |
1 file, +14, -2 |
| f02e15d3 |
build: Make test-gobex* depend on OBEX flag
If obex is disabled in the config, running gobex test is unnecessary.
This patch skips gobex tests if obex is disabled.
Reviewed-by: Miao-chen Chou <mcchou@chromium.org> |
Archie Pusaka |
4 years ago |
1 file, +2, -0 |
| 10400c77 |
unit/gobex: remove timer only when it's not removed yet
There are instances where timer is removed because timeout has
occurred, yet we still remove it again by the end of the test. This
causes double removal and prints ugly messages which obscures the
real culprit.
Reviewed-by: Miao-chen Chou <mcchou@chromium.org> |
Archie Pusaka |
4 years ago |
4 files, +476, -367 |
| 9ad67264 |
doc/mgmt-api - Add a new error code for HCI status 0x3e
We want to retry the pairing when HCI status 0x3e (Connection failed to
established/Synchronization timeout) is returned from the controller.
This is to add a new MGMT error code so that we can catch this 0x3e
failure and issue a retry in the user space.
Reviewed-by: Abhishek Pandit-Subedi <abhishekpandit@chromium.org> |
Yu Liu |
4 years ago |
1 file, +2, -0 |
| 6a4248be |
monitor/avdtp: Fix decoding of reject type
Reject type was not being decoded, so this remove the early return and
leave the callback to decode it:
< ACL Data TX: Handle 42 flags 0x00 dlen 8
Channel: 64 len 4 [PSM 25 mode Basic (0x00)] {chan 1}
AVDTP: Set Configuration (0x03) Response Reject (0x03) type 0x00 label 2 nosp 0
Service Category: Reserved (0x00)
Error code: BAD_ACP_SEID (0x12) |
Luiz Augusto von Dentz |
4 years ago |
1 file, +0, -4 |
| e2b0f0d8 |
avrcp: Fix not checking if params_len match number of received bytes
This makes sure the number of bytes in the params_len matches the
remaining bytes received so the code don't end up accessing invalid
memory. |
Luiz Augusto von Dentz |
4 years ago |
1 file, +8, -0 |
| 7a80d209 |
avdtp: Fix accepting invalid/malformed capabilities
Check if capabilities are valid before attempting to copy them. |
Luiz Augusto von Dentz |
4 years ago |
1 file, +36, -20 |
| 7b26cfe5 |
checkpatch: ignore SPDX license header check
This patch adds the rule to ignore the SPDX license header check. |
Tedd Ho-Jeong An |
4 years ago |
1 file, +1, -0 |
| 6552b572 |
tools: Convert manpages to rst format
This patch converts existing manpages in tools into the reStructuredText
format. |
Tedd Ho-Jeong An |
4 years ago |
25 files, +1400, -1451 |
| 1835be72 |
src: Convert manpage to rst format
This patch converts the existing manpage for bluetoothd into
reStructuredText format. |
Tedd Ho-Jeong An |
4 years ago |
4 files, +89, -65 |
| b66f406e |
monitor: Convert manpage to rst format
This patch adds support to convert reStructuredText formatted btmon
manpage to manpage with rst2man tool. |
Tedd Ho-Jeong An |
4 years ago |
5 files, +189, -40 |
| c0cae925 |
build: Fix manpage enable flag
This patch fixes the manpages installation with --enable-manpages option
so the manpages are not installed by default if the option is not set
during the configuration. |
Tedd Ho-Jeong An |
4 years ago |
2 files, +28, -24 |
| b0557796 |
Build: Add missing ELL headers and sources
The recent change in ELL included the header file tls.h which didn't
included in the BlueZ. This patch adds a series of missing ELL headers
and sources to align with the change in ELL. |
Tedd Ho-Jeong An |
4 years ago |
1 file, +14, -2 |
| d9fdbedf |
build: Create directory for ell/useful.h |
Marcel Holtmann |
4 years ago |
1 file, +1, -0 |
| 4cd4880f |
mesh: Fix net_key_confirm parameter declaration |
Marcel Holtmann |
4 years ago |
1 file, +1, -1 |
| 4d9150b2 |
mesh: Fix network_id parameter declaration |
Marcel Holtmann |
4 years ago |
2 files, +2, -2 |
| 957e79ac |
tools/mgmt-tester: Fix to support emulator spec 5.2
This patch updates the check for supported spec by the BT emulator to
support HCI spec 5.2 |
Tedd Ho-Jeong An |
4 years ago |
1 file, +4, -4 |
| a160909c |
tools/tester-runner: enable enhanced credit flow control mode
This patch enables enhanced credit flow control mode for l2cap. |
Tedd Ho-Jeong An |
4 years ago |
1 file, +1, -0 |
| 99552812 |
emulator/btdev: Add missing commands
This patch adds missing commands HCI_Read_RSSI and
HCI_Read_Transmit_Power_Level commands. |
Tedd Ho-Jeong An |
4 years ago |
1 file, +37, -0 |
| b80bdee6 |
shared/timeout-ell: Fix timeout_add() implementation
Since timeout_add() expects the timeout in milliseconds, the correct
ELL primitive to call is l_timeout_create_ms() |
Inga Stotland |
4 years ago |
1 file, +1, -1 |
| fba79d57 |
device: Reply to connect request if SDP search failed
SDP request can be initiated during BR/EDR connection. This fixes a
missing reply to the method call to prevent generic error message for
no reply.
The following test steps were performed:
(1) Put Bose QC35 into pairing mode, start scanning on bluetoothctl
(2) Turn off the headphones and connect to the headphones
(3) Verify that error should returns immediately to bluetoothctl |
Miao-chen Chou |
4 years ago |
1 file, +12, -0 |
| cfeaa687 |
monitor: Add Intel read supported features command
< HCI Command: Intel Read Supported Features (0x3f|0x00a6) plen 1
Page: 0x01
> HCI Event: Command Complete (0x0e) plen 22
Intel Read Supported Features (0x3f|0x00a6) ncmd 1
Status: Success (0x00)
Page: 0x01
Max Pages: 0x02
Supported Features:
1f 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................ |
Tedd Ho-Jeong An |
4 years ago |
1 file, +24, -0 |
| 7c3ca2a6 |
gatt: Either notify or indicate, do not do both
AcquireNotify and StartNotify starts notifications and/or indications
by whether the characteristic supports them. Before this patch, if both
were supported, Bluez would try to start both simultaneously. This
patch changes this behavior so if both are supported, only
notifications are started. Test cases have also be updated accordingly. |
Curtis Maves |
4 years ago |
2 files, +34, -19 |
| b2e75916 |
tools/mgmt-tester: Add param check callback for LE Set Adv Params
The interval_min and interval_max in LE Set Advertising Parameters
command are changed/updated often whenever the values are tuned in the
kernel, and it causes some tests failure.
This patch adds a parameter check callback for LE Set Advertising
Parameters command to ignore the interval_min and interval_max
parameters. |
Tedd Ho-Jeong An |
4 years ago |
1 file, +34, -0 |
| 47bdb909 |
tools/mgmt-tester: Add callback routine for validating the parameter
This patch adds a callback routine for validating the received HCI
parameter, so it can customize to compare the parameters instead of
memcmp the full length. |
Tedd Ho-Jeong An |
4 years ago |
1 file, +7, -1 |
| d9bc4021 |
tools/mesh-cfgtest: Non-iteractive test for mesh
This adds a non-interactive test to excercise different datapaths in
bluetooth-meshd. The test cases utilize D-Bus based mesh APIs, e.g.,
to create a new network, import a node, import NetKey, import a remote
node. |
Inga Stotland |
4 years ago |
4 files, +1484, -5 |
| c4cfcf08 |
mesh: Add unit test IO
This adds a new type of mesh IO that is used for non-interactive testing.
The new io option can be specified on command line as:
--io unit:<socket_name>
When the bluetooth-meshd daemon starts with the "unit" IO type,
the daemon opens a socket (fd to open is provided after "unit:"
in <socket_name>). The communication with the daemon is done either
through the loop-back using mesh DBus-based APIs or the specified
named socket. |
Brian Gix |
4 years ago |
6 files, +582, -17 |
| 9be85f86 |
mesh: Add Provisioning Confirmation validity check
Validate generated and received confirmation data is unique during
provisioning. |
Brian Gix |
4 years ago |
2 files, +19, -2 |
| b5b7e620 |
input/hog-lib: do not silently ignore missing connection in read_char()
Currently we silently ignore missing connection (attrib) in read_char(),
but not in the other GATT interfaces (such as write_char, discover_desc,
etc). The code should avoid calling read_char() when there is no active
connection instead, and logging errors will help us trace the offenders. |
Dmitry Torokhov |
4 years ago |
1 file, +0, -4 |
| 8f15296d |
input/hog-lib: avoid scanning characteristics too early
We need to have active connection to fully discover a HOG instance,
and in the chain
bt_hog_new()->
gatt_db_foreach_service()->
foreach_hog_service()->
hog_attach_instance()
we have not set up hog->attrib yet. So let's skip calling
foreach_hog_chrc() from hog_attach_instance(), especially since
we will be calling bt_hog_attach() pretty much immediately after
bt_hog_new(), and we will be discovering characteristics there anyway. |
Dmitry Torokhov |
4 years ago |
1 file, +0, -1 |
| d971ca5c |
input/hog-lib: add error handling when calling into gatt
When calling gatt_write_char(), gatt_read_char(), etc, id == 0 indicates
error. Let's recognize this fact and log it instead of queueing request
that will never be completed. |
Dmitry Torokhov |
4 years ago |
1 file, +48, -29 |
| a3fa743e |
btdev: Fix invalid BIG Complete event
Fields were not being initialized properly and no connection was
created so other commands using the same handle wouldn't work. |
Luiz Augusto von Dentz |
4 years ago |
1 file, +23, -5 |
| 44b82b95 |
emulator: Add Create BIG command in emulator
This adds support for Create BIG command HCI
command in emulator. These changes are needed for
making the emulator useful for testing
LE Audio broadcast feature. |
Keyur Parekh |
4 years ago |
1 file, +30, -3 |
| a2d34c61 |
tools: Print list of controller capabilities |
Marcel Holtmann |
4 years ago |
1 file, +37, -1 |
| 2e4397ac |
Release 5.58 |
Marcel Holtmann |
4 years ago |
2 files, +4, -1 |
| e291f4f9 |
doc/mgmt-api - Return connection direction in Device Connected Event
When an MGMT_EV_DEVICE_CONNECTED event is reported back to the user
space we will set the flags to tell if the established connection is
outbound or not. This is useful for the user space to log better metrics
and error messages.
Reviewed-by: Miao-chen Chou <mcchou@chromium.org>
Reviewed-by: Alain Michaud <alainm@chromium.org> |
Yu Liu |
4 years ago |
1 file, +2, -0 |
| fc0875a4 |
obex: Fix warnings cause by using of deprecated APIs
obexd/src/main.c: In function 'main':
obexd/src/main.c:237:13: warning: Deprecated pre-processor symbol
237 | if (g_thread_supported() == FALSE)
| ^~~~~~~~~~~~~~~~~~~~~~~
obexd/src/main.c:238:3: warning: 'g_thread_init' is deprecated
[-Wdeprecated-declarations]
238 | g_thread_init(NULL);
| ^~~~~~~~~~~~~
In file included from /usr/include/glib-2.0/glib.h:111,
from obexd/src/main.c:31:
/usr/include/glib-2.0/glib/deprecated/gthread.h:261:10: note: declared here
261 | void g_thread_init (gpointer vtable);
| ^~~~~~~~~~~~~ |
Luiz Augusto von Dentz |
4 years ago |
2 files, +0, -6 |
| 808be93a |
Release 5.57 |
Marcel Holtmann |
4 years ago |
2 files, +6, -1 |