| 9ee79f67 |
doc: Inclusive language update
Update the docs to reflect the changes for the other inclusive
language updates.
Signed-off-by: Marcel Holtmann <marcel@holtmann.org> |
Archie Pusaka |
4 years ago |
2 files, +4, -4 |
| b21e1124 |
unit/mesh: Inclusive language changes
According to
https://specificationrefs.bluetooth.com/language-mapping/Appropriate_Language_Mapping_Table.pdf
"flooding" is the preferred term.
Signed-off-by: Marcel Holtmann <marcel@holtmann.org> |
Archie Pusaka |
4 years ago |
1 file, +2, -2 |
| 09f87c80 |
mesh: Inclusive language changes
According to
https://specificationrefs.bluetooth.com/language-mapping/Appropriate_Language_Mapping_Table.pdf
"flooding", "accept list", and "reject list" are the preferred terms.
Signed-off-by: Marcel Holtmann <marcel@holtmann.org> |
Archie Pusaka |
4 years ago |
3 files, +25, -25 |
| 28a5c476 |
client: Inclusive language changes
Use "parent" to describe dbus hierarchy.
Signed-off-by: Marcel Holtmann <marcel@holtmann.org> |
Archie Pusaka |
4 years ago |
1 file, +3, -3 |
| 7dd00605 |
src: Inclusive language changes
BT core spec 5.3 promotes the usage of inclusive languages.
This CL replaces some terms with the more appropriate counterparts,
such as "central", "peripheral", "accept list", and "reject list".
Note that some suggestions come from
https://specificationrefs.bluetooth.com/language-mapping/Appropriate_Language_Mapping_Table.pdf
Also use "primary" to refer the global mgmt struct.
Signed-off-by: Marcel Holtmann <marcel@holtmann.org> |
Archie Pusaka |
4 years ago |
10 files, +76, -73 |
| d2117700 |
profiles: Inclusive language changes
BT core spec 5.3 promotes the usage of inclusive languages.
This CL replaces some terms with the more appropriate counterparts,
such as "central" and "peripheral".
Signed-off-by: Marcel Holtmann <marcel@holtmann.org> |
Archie Pusaka |
4 years ago |
4 files, +17, -17 |
| e5af955e |
plugins/sixaxis: Inclusive language changes
BT core spec 5.3 promotes the usage of inclusive languages.
This CL uses "central" as it is deemed to be more appropriate.
Signed-off-by: Marcel Holtmann <marcel@holtmann.org> |
Archie Pusaka |
4 years ago |
1 file, +22, -22 |
| 9509056e |
tools: Deprecate some input parameters to align with inclusive language
Some input parameter names are not appropriate and needs to be
updated. However, doing so might cause friction with the current
workflow and documents.
This patch deprecates the inappropriate names and replaces them with
the more appropriate substitutes, while still keeping the old terms
usable to not break the workflow of users.
Signed-off-by: Marcel Holtmann <marcel@holtmann.org> |
Archie Pusaka |
4 years ago |
4 files, +78, -64 |
| 43f547d7 |
tools: Inclusive language changes
BT core spec 5.3 promotes the usage of inclusive languages.
This CL replaces some terms with the more appropriate counterparts,
such as "central", "peripheral", "accept list", "reject list", and
"temporary link key". Note that some suggestions come from
https://specificationrefs.bluetooth.com/language-mapping/Appropriate_Language_Mapping_Table.pdf
Signed-off-by: Marcel Holtmann <marcel@holtmann.org> |
Archie Pusaka |
4 years ago |
34 files, +439, -389 |
| 048f2ac0 |
emulator: Inclusive language changes
BT core spec 5.3 promotes the usage of inclusive languages.
This CL replaces some terms with the more appropriate counterparts,
such as "central", "peripheral", and "accept list".
Signed-off-by: Marcel Holtmann <marcel@holtmann.org> |
Archie Pusaka |
4 years ago |
11 files, +164, -163 |
| 7582f360 |
monitor: Inclusive language changes
BT core spec 5.3 promotes the usage of inclusive languages.
This CL replaces some terms with the more appropriate counterparts,
such as "central", "peripheral", "link key", and "accept list"
Signed-off-by: Marcel Holtmann <marcel@holtmann.org> |
Archie Pusaka |
4 years ago |
13 files, +400, -390 |
| a777d7d5 |
btio: Inclusive language changes
BT core spec 5.3 promotes the usage of inclusive languages.
This CL uses "central" as it is deemed to be more appropriate.
Signed-off-by: Marcel Holtmann <marcel@holtmann.org> |
Archie Pusaka |
4 years ago |
7 files, +30, -30 |
| b7d6a7d2 |
lib: Inclusive language changes
BT core spec 5.3 promotes the usage of inclusive languages.
This CL replaces some terms with the more appropriate counterparts,
such as "central", "peripheral", and "accept list".
Signed-off-by: Marcel Holtmann <marcel@holtmann.org> |
Archie Pusaka |
4 years ago |
6 files, +29, -21 |
| 62182e0f |
media: Add media_player prefix for callback
This adds media_player prefix to callback so it is inline with pause
which now uses such callback due to possible clash with libc
definition. |
Luiz Augusto von Dentz |
4 years ago |
1 file, +35, -33 |
| 415af69b |
media: Fix build with glibc >= 2.34
pause() is defined in glibc since the very early times; it appears in
upstream commit 28f540f45bba (initial import) in 1995 [0].
Bluez has been defining a function named pause() for ages too, since
commit caab74c97542 (media: Implement new callbacks for pass-through
operations) in 2013 [1]
With the recent bump to glibc 2.34.xxx, the build now fails because the
two pause() clash:
profiles/audio/media.c:1284:13: error: conflicting types for 'pause'
1284 | static bool pause(void *user_data)
| ^~~~~
In file included from /tmp/instance-0/output-1/per-package/bluez5_utils/host/s390x-buildroot-linux-gnu/sysroot/usr/include/bits/sigstksz.h:24,
from /tmp/instance-0/output-1/per-package/bluez5_utils/host/s390x-buildroot-linux-gnu/sysroot/usr/include/signal.h:328,
from /tmp/instance-0/output-1/per-package/bluez5_utils/host/bin/../s390x-buildroot-linux-gnu/sysroot/usr/include/glib-2.0/glib/gbacktrace.h:36,
from /tmp/instance-0/output-1/per-package/bluez5_utils/host/bin/../s390x-buildroot-linux-gnu/sysroot/usr/include/glib-2.0/glib.h:34,
from profiles/audio/media.c:21:
/tmp/instance-0/output-1/per-package/bluez5_utils/host/s390x-buildroot-linux-gnu/sysroot/usr/include/unistd.h:489:12: note: previous declaration of 'pause' was here
489 | extern int pause (void);
| ^~~~~
The culprit is indeed glibc 2.34, as can be seen in this result matrix:
\ bluez5_utils
glibc \ 5.60 | 5.61
-------\-------+--------
2.33 | OK | OK
-------+-------+--------
2.34 | KO | KO
The underlying reason that pause() is now causing issues with glibc 2.34
is not obvious: glibc is a big beast, and finding such issues is not
easy. However, we can see that the pause() provided by NPTL has been
dropped in favour of the generic one, so maybe this is causing symbol
visibility or weakness to change or something...
We fix that by renaming the local pause() in bluez5_utils with a
namespace-prefix, like some other functions there already have.
Fixes:
- http://autobuild.buildroot.org/results/c4fbface34be8815838fd7201621d7a8fddd32c5
- http://autobuild.buildroot.org/results/62b88740f19fbe4a1ad7959dc141d539eb88c1f8
[0] https://sourceware.org/git/?p=glibc.git;a=commit;h=28f540f45bbacd939bfd07f213bcad2bf730b1bf
[1] https://github.com/bluez/bluez/commit/caab74c97542a56b591f0b16b44ab6ba4b40f0f5 |
Fabrice Fontaine |
4 years ago |
1 file, +2, -2 |
| b9c3504d |
tools: userchan-tester: Add test case for the closing channel
This patch adds a test casse for checking the controller power state
after closing the user channel.
When the user channel is closed, the controller should be powered down
state. |
Tedd Ho-Jeong An |
4 years ago |
1 file, +69, -0 |
| 86e7b3e7 |
lib: Fix variable-length array declarations in hci structures
Use of zero as the size for arrays as the last element of a structure
is a GNU C extension, which as of GCC 10 produces diagnostics when
values in the extended array are referenced. Switch to the C99
standard idiom for flexible array members, already in use in a few
other headers. |
Peter A. Bigot |
4 years ago |
1 file, +8, -8 |
| dbb3af61 |
admin: Fix double free
Fixes the following double free which happen due to exit calling
btd_unregister_adapter_driver:
Invalid read of size 8
at 0x1CDA97: queue_foreach (queue.c:198)
by 0x1318B8: admin_policy_remove (admin.c:591)
by 0x18982A: plugin_cleanup (plugin.c:217)
by 0x12E3FD: main (main.c:1214)
Address 0x547ffb8 is 8 bytes inside a block of size 32 free'd
at 0x483A9F5: free (vg_replace_malloc.c:538)
by 0x1318CB: admin_policy_remove (admin.c:592)
by 0x18F416: unload_driver (adapter.c:7215)
by 0x496F50F: g_slist_foreach (in /usr/lib64/libglib-2.0.so.0.6600.8)
by 0x131988: admin_exit (admin.c:623)
by 0x18982A: plugin_cleanup (plugin.c:217)
by 0x12E3FD: main (main.c:1214)
Block was alloc'd at
at 0x4839809: malloc (vg_replace_malloc.c:307)
by 0x1CDE1E: btd_malloc (util.c:33)
by 0x1CD83D: queue_new (queue.c:47)
by 0x13150D: admin_init (admin.c:614)
by 0x18966B: plugin_init (plugin.c:187)
by 0x12E358: main (main.c:1198) |
Luiz Augusto von Dentz |
4 years ago |
1 file, +1, -1 |
| 36e4ce90 |
admin: Fix leaking uuids loads from storage
This fixes the following trace:
8 bytes in 1 blocks are definitely lost in loss record 27 of 274
at 0x4839809: malloc (vg_replace_malloc.c:307)
by 0x495BBB8: g_malloc (in /usr/lib64/libglib-2.0.so.0.6600.8)
by 0x494C024: g_key_file_get_string_list (in /usr/lib64/libglib-2.0.so.0.6600.8)
by 0x131ECD: key_file_load_service_allowlist (admin.c:294)
by 0x131ECD: load_policy_settings (admin.c:346)
by 0x131ECD: admin_policy_adapter_probe (admin.c:497)
by 0x18F554: probe_driver (adapter.c:4858)
by 0x19DF5A: load_drivers (adapter.c:4873)
by 0x19DF5A: adapter_register (adapter.c:8975)
by 0x19DF5A: read_info_complete (adapter.c:9791)
by 0x1CE831: request_complete (mgmt.c:264)
by 0x1CF7D4: can_read_data (mgmt.c:356)
by 0x1DE634: watch_callback (io-glib.c:157)
by 0x4953A9E: g_main_context_dispatch (in /usr/lib64/libglib-2.0.so.0.6600.8)
by 0x49A5A97: ??? (in /usr/lib64/libglib-2.0.so.0.6600.8)
by 0x4953162: g_main_loop_run (in /usr/lib64/libglib-2.0.so.0.6600.8) |
Luiz Augusto von Dentz |
4 years ago |
1 file, +6, -3 |
| f7eb887f |
policy: Use btd_service_is_initiator
Instead of using BTD_SERVICE_STATE_CONNECTING use
btd_service_is_initiator to determine if the service initiated the
connection and then proceed to connect other service immediately.
Fixes: https://github.com/bluez/bluez/issues/205 |
Luiz Augusto von Dentz |
4 years ago |
1 file, +3, -3 |
| 2db4d977 |
service: Add btd_service_is_initiator
Since BTD_SERVICE_STATE_CONNECTING is being used for both initiator and
responder case it is no longer possible to use the state distint when
the service connection was initiated locally or not, so to fix this a
new flag is introduce to track when btd_service_connect has been
called. |
Luiz Augusto von Dentz |
4 years ago |
2 files, +11, -0 |
| 98f27a2b |
sco-tester: Add tests for sending data
This adds tests for sending data over the socket. |
Luiz Augusto von Dentz |
4 years ago |
1 file, +27, -0 |
| b22dc8ac |
plugins/admin: create admin_policy_settings if not exists
If admin_policy_settings is not found when loading, we should create one
instead of printing error.
Reviewed-by: Shyh-In Hwang <josephsih@chromium.org>
Reviewed-by: Miao-chen Chou <mcchou@chromium.org> |
Yun-Hao Chung |
4 years ago |
1 file, +3, -7 |
| bf88ab83 |
plugins/admin: add adapter_remove handler
Currently admin doesn't handle adapter removed callbacks, which causes
interfaces AdminPolicySet1 and AdminPolicyStatus1 not being
unregistered, which in turns causes these interfaces can not be
re-registered once adapter is back.
This adds handler for adapter_remove.
Reviewed-by: Shyh-In Hwang <josephsih@chromium.org>
Reviewed-by: Miao-chen Chou <mcchou@chromium.org> |
Yun-Hao Chung |
4 years ago |
1 file, +28, -7 |
| fa117b63 |
tools/mgmt-tester: Update exp feature testcase
This patch updates the experimental feature test case with the recently
added "codec offload" feature. |
Tedd Ho-Jeong An |
4 years ago |
1 file, +5, -1 |
| ad3f9e33 |
shared/util: Update UUID database with LE Audio services
This updates UUID database with the values from assigned numbers for LE
Audio services. |
Luiz Augusto von Dentz |
4 years ago |
1 file, +83, -1 |
| 56b1e7ef |
shared/util: Add conversion function for 24 bits
This adds get/put 24 bits variants. |
Luiz Augusto von Dentz |
4 years ago |
1 file, +26, -0 |
| cec1ef63 |
adv_monitor: Clear any running DeviceLost timers on power down
This patch clears any running Adv Monitor DeviceLost timers on bt power
down. It'll also invoke DeviceLost event if the device is already found
and is being tracked for the DeviceLost event.
Verified this by adding a monitor using bluetoothctl and confirming that
the DeviceLost event is getting triggered for already found device in
case of bt power down.
Reviewed-by: mcchou@google.com |
Manish Mandlik |
4 years ago |
3 files, +55, -0 |
| 8c0c82c9 |
adapter: Enable codec offload when Experimental is set
This enables codec offload experimental feature if its UUIDs has been
enabled by main.conf:Experimental or -E has been passed in the command
line. |
Luiz Augusto von Dentz |
4 years ago |
1 file, +42, -0 |
| 3c7823a1 |
main.conf: Allow passing a list of UUIDs to Experimental
This allows the user to enable a subset of the experimental features to
be enabled instead of all of them and also change -E to work in the same
way so a list of UUIDs can also be given at the command line. |
Luiz Augusto von Dentz |
4 years ago |
4 files, +169, -60 |
| b84f294c |
client: Add support for printing ExperimentalFeatures property
Thid adds support to show command to print ExperimentalFeatures property:
[bluetooth]# show
Controller ...
Experimental: BlueZ Experimental LL p.. (15c0a148-c273-11ea-b3de-0242ac130004) |
Luiz Augusto von Dentz |
4 years ago |
1 file, +28, -5 |
| f37cfbcf |
adapter: Implement ExperimentalFeatures property
This implements ExperimentalFeatures property which indicates the list
of UUIDs that represents the experimental features currently enabled. |
Luiz Augusto von Dentz |
4 years ago |
1 file, +109, -40 |
| a5616cfe |
adapter-api: Add ExperimentalFeatures property
This adds ExperimentalFeatures property which indicates what
experimental features are currently enabled. |
Luiz Augusto von Dentz |
4 years ago |
1 file, +5, -0 |
| 90da323c |
tools/sco-tester: add a test case for offload SCO connect
Add a test case for offload SCO connect with codec type set to mSBC |
Kiran K |
4 years ago |
1 file, +49, -0 |
| c20caffc |
tools/sco-tester: Add a test case for setting offload codec
Add a test case to set codec for HFP offload use case |
Kiran K |
4 years ago |
1 file, +40, -0 |
| 984e364d |
tools/sco-tester: add test cases to get offload codecs
Add a test case to query offload codecs supported over sco |
Kiran K |
4 years ago |
2 files, +91, -3 |
| 055000ad |
avdtp: use separate local SEID pool for each adapter
Local SEIDs are currently allocated from a pool that is common for all
adapters. However, AVDTP spec v1.3, sec 4.10 states "To prevent
conflicts, the scope of the SEID shall be both device-local and
connection-local. The application is responsible for assigning a SEID,
which is not in use on the connection to the same peer device." In
practice, registering the same media application for multiple adapters
can result to running out of SEIDs, even though the spec does not
require SEIDs to be unique across adapters.
To fix this, have a2dp_server own the SEID pool and pass it to avdtp
functions. Currently, a2dp_server is the only one that registers local
SEPs, and its correspondence to adapters is unique, so it can own the
pool. |
Pauli Virtanen |
4 years ago |
3 files, +22, -13 |
| 0d09a5d3 |
shared/util: use 64-bit bitmap in util_get/clear_uid
The util_get/clear_uid functions use int type for bitmap, and are used
e.g. for SEID allocation. However, valid SEIDs are in range 1 to 0x3E
(AVDTP spec v1.3, 8.20.1), and 8*sizeof(int) is often smaller than 0x3E.
The function is also used in src/advertising.c, but an explicit maximum
value is always provided, so growing the bitmap size is safe there.
Use 64-bit bitmap instead, to be able to cover the valid range. |
Pauli Virtanen |
4 years ago |
6 files, +13, -15 |
| 64e7ce42 |
shared/shell: don't allow completion fallback
When using bluetoothctl, if the user enters a quotation mark before
pressing tab, the completion handler falls back to the shell's handler
which ends up printing the current folder's file content. This behavior
is never desired in bt_shell's menu.
This was verified by typing " then tab-tab before and after the change as
been made to confirm the desired behavior and verified that all other
argument completions (such as address completion) continues to function. |
Alain Michaud |
4 years ago |
1 file, +2, -3 |
| 8891babc |
monitor: Fix calculation of RFCOMM length
Byte order is assumed to be big endian instead of little endian. |
Luiz Augusto von Dentz |
4 years ago |
1 file, +1, -1 |
| 355d06b3 |
plugin/admin: fix set empty allowlist no persistence issue
This patch fixes a bug when setting empty service allowlist, the
allowlist sets successfully but it fails to be stored in the file.
Reviewed-by: Miao-chen Chou <mcchou@chromium.org> |
Yun-Hao Chung |
4 years ago |
1 file, +6, -1 |
| fc77feb0 |
btmgmt: add non-interactive quit on read-sysconfig
This fixes the erros that read-sysconfig doesn't exit in non-interactive
mode.
Reviewed-by: Archie Pusaka <apusaka@chromium.org> |
Yun-Hao Chung |
4 years ago |
1 file, +3, -2 |
| bed35475 |
tools/mgmt-tester: add a exp feature to Read Exp Feature - Success
This patch adds a new quality report feature to the
"Read Exp Feature - Success" test. |
Joseph Hwang |
4 years ago |
1 file, +5, -1 |
| 588b1533 |
test-runner: Enable bluetoothd debug when running with -d
This enable bluetoothd debug when running with -d. |
Luiz Augusto von Dentz |
4 years ago |
1 file, +6, -5 |
| 1cbe923e |
device: set le_state.svc_resolved = false in gatt_cache_cleanup()
When the GATT cache is cleared, there is no longer a list of GATT
services, so we need to set le_state.svc_resolved = false so that
the next time the device connects, it will enumerate the services
again.
This partially fixes an issue where the UUIDs D-Bus property was empty
after scanning, connecting, disconnecting and scanning again when
[GATT] Cache = yes is set in main.conf.
Issue: https://github.com/bluez/bluez/issues/192
Suggested-by: Luiz Augusto von Dentz <luiz.dentz@gmail.com> |
David Lechner |
4 years ago |
1 file, +1, -0 |
| c731508e |
device: clear eir_uuids list on disconnect
The eir_uuids list contains GATT service UUIDs from advertising data.
The device may advertise different UUIDs each time it is scanned and
connected, so the list needs to be cleared when the device disconnects.
This partially fixes an issue where the UUIDs D-Bus property is empty
after scanning, connecting, disconnecting and scanning again when
[GATT] Cache = yes is set in main.conf.
Issue: https://github.com/bluez/bluez/issues/192 |
David Lechner |
4 years ago |
1 file, +3, -0 |
| cb85f71b |
gatt: Do not always attempt to connect EATT immediately
Wait the bt_gatt_client becomes ready (has performed service discovery)
before attempting to connect EATT when acting as peripheral/acceptor
since the central/initiator might actually attempt to connect EATT
channels in the same way which can potentially cause a collisions. |
Luiz Augusto von Dentz |
4 years ago |
3 files, +44, -38 |
| e6f2ce8a |
shared/att: Fix attempting to send Exchange MTU on EATT bearer
EATT bearer shall use the L2CAP signalling for negotiating the MTU
size. |
Luiz Augusto von Dentz |
4 years ago |
1 file, +8, -1 |
| 809db88e |
shared/att: Fix accepting Exchange MTU on EATT bearer
If remote send Exchange MTU it shall fail as the MTU negotiation shall
happen over L2CAP signalling not ATT for those channels. |
Luiz Augusto von Dentz |
4 years ago |
1 file, +2, -1 |
| 3c66567b |
device: Remove GATT Attribute when device is removed
This makes the GATT Attribute cache to be removed when device is removed
just like SDP ServiceRecords.
Fixes: https://github.com/bluez/bluez/issues/191 |
Luiz Augusto von Dentz |
4 years ago |
1 file, +1, -0 |