| ddec3358 |
tester.config: Add missing drivers
This adds missing config options to enable all drivers which is required
in order to catch build problem with github CI workflow. |
Luiz Augusto von Dentz |
6 months ago |
1 file, +10, -0 |
| b0a1386f |
iso-tester: add tests for BT_PKT_SEQNUM
Add test
ISO Receive Packet Seqnum - Success |
Pauli Virtanen |
6 months ago |
1 file, +78, -2 |
| 9e117ebe |
lib: add BT_PKT_SEQNUM and BT_SCM_PKT_SEQNUM
Socket options and CMSG identifier for ISO packet sequence numbers. |
Pauli Virtanen |
6 months ago |
1 file, +4, -0 |
| db061936 |
lib: tools: remove POLL_ERRQUEUE
This experimental feature did not land to mainline kernel, and probably
would need to be done differently.
Remove defines and tests for it. |
Pauli Virtanen |
6 months ago |
3 files, +1, -130 |
| 893a47e5 |
doc: explain SCO and L2CAP timestamping related socket features
Add explanations and examples for SCO and L2CAP timestamping-related
features. |
Pauli Virtanen |
6 months ago |
2 files, +330, -4 |
| 468c5877 |
monitor: Add sequence number and SDU length to ISO packets
This prints sequence number and SDU length of ISO packets:
> ISO Data RX: Handle 2304 SN 48 flags 0x02 dlen 64 slen 60 |
Luiz Augusto von Dentz |
6 months ago |
2 files, +37, -15 |
| 806dd732 |
build: Fix typo in configure option help string |
Bastien Nocera |
6 months ago |
1 file, +1, -1 |
| 47a4c73c |
avdtp: fix not adding stream to global streams list
stream_new() shall be used to create new avdtp_stream, so that they can
be found from global list.
Fix one case where it was not used. Fixes crash when unregistering lsep
and then disconnecting, due to stream for the removed lsep not being
cleaned up when SEP is freed.
Fixes: https://github.com/bluez/bluez/issues/1325 |
Pauli Virtanen |
6 months ago |
1 file, +1, -4 |
| 1c6f080d |
obexd: Remove --enable-threads option
Threading support is always enabled in dbus since version 1.8 released
in 2014:
• libdbus always behaves as if dbus_threads_init_default() had been called
(thread-safety by default)
so remove the obsolete option.
Note that we also require glib 2.36, which is newer than the version of
glib with GThread support built-in:
[Since 2.32]
This function is no longer necessary. The GLib threading system is
automatically initialized at the start of your program. |
Bastien Nocera |
6 months ago |
3 files, +0, -20 |
| 784607f8 |
btio: Fix coding style
Fix going over 80 columns. |
Luiz Augusto von Dentz |
6 months ago |
1 file, +2, -2 |
| 24a32742 |
shared/util: Introduce strnlenutf8
This introduces strnlenutf8 which works similarly to strnlen but return
only the number of valid bytes of UTF-8 encoded string then replace the
other copies of similar code. |
Luiz Augusto von Dentz |
6 months ago |
2 files, +17, -37 |
| 09212f9d |
obexd/client: fix err condition causing memleak
transfer_open returns 0 if an error occurs, condition corrected. |
Ismagil Iskakov |
6 months ago |
1 file, +1, -1 |
| 9432bfe8 |
src/shared: add nullity checks
Check util_iov_pull_mem where iov len is not verified
beforehand. Check vcp_get_vcs for NULL.
These changes are based on other usages where those
checks exist. |
Ismagil Iskakov |
6 months ago |
2 files, +26, -0 |
| 77932f2d |
profiles/audio: add nullity checks
Cover bass_setup unsuccessful search and btd_device_get_service.
This change is motivated by the other usages where checks for
NULL exist. |
Ismagil Iskakov |
6 months ago |
3 files, +48, -13 |
| 80a6b91d |
btio: fix range validation of security level
Arrays inside l2cap_set_lm/rfcomm_set_lm functions are of size 4,
but the bounds check allows the value 4 for 'level'. |
Ismagil Iskakov |
6 months ago |
1 file, +6, -0 |
| a3824b4a |
mesh: use '0x1' rathen than 'true' for bit operations
Although 'true' expands to 1, it feels more natural using '0x1' (or '1')
when performing masking or bit shifting operations. |
Christian Eggers |
6 months ago |
3 files, +7, -7 |
| 4e5a3a80 |
mesh: remove unneeded casts to bool
The result of these expression is already of type 'bool'. |
Christian Eggers |
6 months ago |
5 files, +8, -8 |
| e2950631 |
mesh: prov: cleanup header
Most stuff in this file isn't been used. |
Christian Eggers |
6 months ago |
1 file, +0, -116 |
| 6ef0f297 |
mesh: node: remove dead function prototype
node_init_from_storage() has been made static (and renamed) in commit
7cafe5fd7cc8 ("mesh: Manage node config directory in mesh-config"). |
Christian Eggers |
6 months ago |
1 file, +0, -2 |
| 41b4b531 |
mesh: net-keys: remove dead function prototype
net_key_snb_compose() has been made static (and renamed) in commit
5ba57cf85140 ("mesh: Add Tx/Rx support of Mesh Private Beacons"). |
Christian Eggers |
6 months ago |
1 file, +0, -2 |
| 0cb00fce |
mesh: net-keys: introduce BEACON_LEN_SNB, BEACON_LEN_MPB, BEACON_LEN_MAX
Lets introduce symbolic names before spreading these magic numbers over
more locations. |
Christian Eggers |
6 months ago |
2 files, +12, -9 |
| 2d9afa11 |
mesh: net: remove obsolete struct net_key
'struct net_key' has been introduced in commmit 37ebf9eb0bf9 ("mesh:
Upper and Lower mesh transport") and became superseded in commit
994932b740c7 ("mesh: Refactor friend.c and net.c for central key DB"). |
Christian Eggers |
6 months ago |
1 file, +0, -8 |
| d40ed08f |
mesh: model: remove dead function prototype
mesh_model_cfg_blk() has been added in commit 6fbc4c83e134 ("mesh:
Header files for mesh access layer and utilities"), but an
implementation has never existed. |
Christian Eggers |
6 months ago |
1 file, +0, -1 |
| 806aa9de |
mesh: mesh-io-mgmt: Fix NULL pointer dereference
Don't try to dereference 'pvt' if it's NULL. |
Christian Eggers |
6 months ago |
1 file, +2, -1 |
| 797b330b |
mesh: mesh-config: remove dead function prototype
mesh_config_write_address() has been added in commit 78668a02d6c4
("mesh: Change mesh_db prefix to mesh_config"), but an implementation
has never existed. |
Christian Eggers |
6 months ago |
1 file, +0, -1 |
| 2d012a2f |
mesh: friend: remove dead function declarations
The implementations for these functions have been removed in commit
f246d31a7752 ("mesh: Friendship clean-up and rewrite"). |
Christian Eggers |
6 months ago |
1 file, +0, -16 |
| e1b26471 |
mesh: crypto: remove unused function parameter
The 'relay' parameter isn't used by mesh_crypto_packet_build(). |
Christian Eggers |
6 months ago |
4 files, +12, -17 |
| 441f0539 |
mesh: crypto: remove dead function declaration
The implementation of mesh_aes_ecb_one() has been removed in commit
dfed4839463f ("mesh: Convert crypto to use ELL wrappers"). |
Christian Eggers |
6 months ago |
1 file, +0, -2 |
| 9ed79eed |
shared/shell: Fix not running pre_run on MODE_NON_INTERACTIVE
If a command is given to be run in non-interactive mode the code would
not attempt to execute .pre_run first since some (sub)menus requires that
in order to properly initialize things.
Fixes: https://github.com/bluez/bluez/issues/1394
Fixes: https://github.com/bluez/bluez/issues/1317 |
Luiz Augusto von Dentz |
6 months ago |
1 file, +24, -11 |
| 004518d0 |
unit/test-eir: Add name encoding tests
This ensures that device name encode with UTF-16, ISO-2022-JP or with
an incorrect character in UTF-8 string are truncated correctly. |
Frédéric Danis |
6 months ago |
1 file, +50, -0 |
| 4cedd8d1 |
shared/ad: Use strtoutf8 for name
Truncate the string to first character before invalid UTF-8 one
instead of replacing non ascii characters by spaces. |
Frédéric Danis |
6 months ago |
1 file, +1, -6 |
| 218db700 |
eir: Use strtoutf8 for device names
Truncate the string to first character before invalid UTF-8 one
instead of replacing non ascii characters by spaces. |
Frédéric Danis |
6 months ago |
1 file, +1, -10 |
| a0387d66 |
audio/gap: Use strtoutf8 for GAP device name
Truncate the string to first character before invalid UTF-8 one
instead of replacing non ascii characters by spaces. |
Frédéric Danis |
6 months ago |
1 file, +1, -10 |
| a8f59849 |
audio/mcp: Use strtoutf8 for player name and track title
Truncate the string to first character before invalid UTF-8 one
instead of replacing non ascii characters by spaces. |
Frédéric Danis |
6 months ago |
1 file, +1, -10 |
| 89079f2c |
audio/avrcp: Fix crash with invalid UTF-8 item name
As stated in AVRCP 1.6.2 chapter 6.10.2.3 Media element item, for the
Displayable Name Length property, the target device may truncate the
item name:
Length of Displayable Name in octets. The name shall be limited such
that a response to a GetFolderItems containing one media player item
fits within the maximum size of PDU which can be received by the CT.
This truncatation may occur in the middle of a multi-byte character,
at least with Samsung Music app, which triggers a DBus assertion and
crashes bluetoothd:
profiles/audio/player.c:media_folder_create_item() Din Dhal Jaye
Haye with lyrics | "दिन ढल जाए
हाय" गाने के बो� type audio uid 1
profiles/audio/player.c:media_folder_create_item()
/org/bluez/hci0/dev_24_24_B7_11_82_6C/player0/NowPlaying/item1
profiles/audio/player.c:media_player_set_metadata() Title: Din Dhal
Jaye Haye with lyrics | "दिन ढल जाए हाय"
गाने के बोल | Guide | Dev Anand, Waheeda Rehman
…
arguments to dbus_message_iter_append_basic() were incorrect,
assertion "_dbus_check_is_valid_utf8 (*string_p)" failed in
file dbus-message.c line 2775.
This is normally a bug in some application using the D-Bus library. |
Frédéric Danis |
6 months ago |
1 file, +3, -1 |
| 0440ca68 |
shared/util: Add strtoutf8 function
This adds the strtoutf8 function that truncate a string before the
first non UTF-8 character.
This truncation is done in place. |
Frédéric Danis |
6 months ago |
2 files, +43, -0 |
| a7e0747e |
plugin: fix args order
According to other functions and arguments usage, the
case with external_plugin_init seems to be erroneous. |
Ismagil Iskakov |
6 months ago |
1 file, +1, -1 |
| a2d7be18 |
isotest: remove repeating conditions |
Ismagil Iskakov |
6 months ago |
1 file, +3, -3 |
| 47ffe608 |
src/shared: move null checks before dereferencing |
Ismagil Iskakov |
6 months ago |
2 files, +12, -5 |
| f6dcd1d2 |
shared/bap: fix memleak |
Ismagil Iskakov |
6 months ago |
1 file, +3, -2 |
| c1d4c478 |
bap: fix memleak of bt_bap
Make failure branches deallocate memory before leaving. |
Ismagil Iskakov |
6 months ago |
1 file, +14, -10 |
| a5d517dd |
build: Remove deleted files from .gitignore
As all the android support was removed in
f0512114aacf ("Remove android support"). |
Bastien Nocera |
6 months ago |
1 file, +0, -11 |
| f3db585b |
build: Remove deleted configure option
Remove this option now that that the supporting code has been
removed, fixes a configure warning:
configure: WARNING: unrecognized options: --enable-android
Fixes: f0512114aacf ("Remove android support") |
Bastien Nocera |
6 months ago |
1 file, +0, -1 |
| 18cbebbc |
midi: Fix debug string |
Bastien Nocera |
6 months ago |
1 file, +2, -2 |
| 9fb0e002 |
doc: Fix extra word in doc string |
Bastien Nocera |
6 months ago |
1 file, +1, -1 |
| be8c031b |
obexd/client: prevent double freeing
image_properties_complete_cb frees 'contents' after a failure.
However obc_transfer_get_contents does it beforehand. |
Ismagil Iskakov |
6 months ago |
1 file, +1, -0 |
| 42f89165 |
tools: Fix typos
Found using codespell. |
Bastien Nocera |
6 months ago |
26 files, +64, -55 |
| de69e5a3 |
unit: Fix typos
Found using codespell. |
Bastien Nocera |
6 months ago |
2 files, +3, -3 |
| 32e3d635 |
test: Fix typos
Found using codespell. |
Bastien Nocera |
6 months ago |
1 file, +1, -1 |
| f019d067 |
shared: Fix typos
Found using codespell. |
Bastien Nocera |
6 months ago |
9 files, +14, -14 |