| 2eb218ab |
obexd: Fix problem with multiple emails in vcard
Previously only one email appeared in generated vcard, even if contact
had defined multiple email addresses in contact data.
Changed vcard struct and phonebook-tracker pull_contacts func to support
multiple emails. |
Radoslaw Jablonski |
13 years ago |
3 files, +78, -35 |
| 22edcd65 |
obexd: fix misuse of OBEX_SetCustomData/OBEX_GetCustomData
Those function should only be used in case of custom transport which is
not the case since we are using fd transport here.
To fix that it now uses OBEX_SetUserData/OBEX_GetUserData which are not
associate with any transport in particular. |
Luiz Augusto von Dentz |
13 years ago |
2 files, +2, -2 |
| 9e5acca9 |
obexd: Fix aborting capability scripts making them zombies processes
When using G_SPAWN_DO_NOT_REAP_CHILD the watch cannot be removed since it
basically replaces the use of waitpid which does prevent the child
process to became 'zombie' when terminated, a more detailed explanation
can be found in waitpid manpage. |
Luiz Augusto von Dentz |
13 years ago |
1 file, +18, -10 |
| 8ba0070e |
obexd: Fix problem with filling ADR with unneeded semicolons
Previously in a phonebook pull request ADR was filled with six
semicolons when contact address entry was empty in phonebook. This
patch fixes this problem. Address is send as an empty string. |
Lukasz Pawlik |
13 years ago |
1 file, +25, -0 |
| 30b2d059 |
obexd: Fix SyncEvolution to use a non-reserved RFCOMM channel
RFCOMM channel 16 is reserved for MAP, so use 19 instead. |
Johan Hedberg |
13 years ago |
1 file, +1, -1 |
| ec9cb090 |
obexd: Add support for FAX number in phonebook-tracker.c
Previously all fax numbers were treated as home phone numbers. Now
fetching fax field as additional column in tracker query. Data from this
column is filled as phone number with FAX type set. All pull queries are
modified that way to suport fax number type. |
Radoslaw Jablonski |
13 years ago |
1 file, +101, -28 |
| e2f4885b |
obexd: Fix unnecessary checking for empty phones list
Removed not needed anymore checking for empty list of phone numbers. |
Radoslaw Jablonski |
13 years ago |
1 file, +0, -5 |
| c05735df |
obexd: Fix empty contact in missed calls problem
Fixed problem with tracker queries for calls history - previously call
without contact in phonebook was missing in some scenario for pull
requests. |
Radoslaw Jablonski |
13 years ago |
1 file, +4, -24 |
| ca5d2090 |
obexd: Fix format string warnings for g_dbus_create_error
This patch fixes gcc warnings for "format not a string literal and no
format arguments". |
Johan Hedberg |
13 years ago |
3 files, +10, -10 |
| 14e16da5 |
obexd: ebook backend: separate concatenated vcards with \r\n.
The END:VCARD is not ended with \r\n for single vcards.
In a phonebook pull request vcards are concatenated as one
big blob. Carkits seem to choke on the fact that an END:VCARD
is directly followed by BEGIN:VCARD without \r\n separation.
(as observed by many n900 users). |
Marcel Mol |
13 years ago |
1 file, +3, -0 |
| 7a2e03b4 |
obexd: Use enum from vcard.h for phone types
Removed redundant declarations for phone types. Now using values from
phonebook_number_type declared in vcard.h. |
Radoslaw Jablonski |
13 years ago |
1 file, +2, -4 |
| bc190b6e |
obexd: Fix a memory leak when adding contacts to the result |
Vinicius Costa Gomes |
13 years ago |
1 file, +1, -0 |
| 402eb678 |
obexd: Fix multiple phone number problem in pull vcard
This fixes problem with pull vcard when contact has more than one home
or work number defined in tracker - more than one VCARD was generated in
response for pull vcard request. This was caused by nature of the data
retrieved from tracker - contact with multiple numbers set was returned
as many entries with identical id. Previously VCARDs was generated on
the fly - now added contact-data caching and checking for contact id.
VCARD is now generated when all responses of tracker were processed -
and only one vcard is returned for one contact entry. |
Radoslaw Jablonski |
13 years ago |
1 file, +109, -21 |
| e5018a74 |
obexd: Fix multiple phone numbers problem in vcard-listing
This fixes displaying problem in vcard-listing when contact had multiple
home or work phone set(one contact was displayed more than one time in
vcard-listing. Now query is changed and additional entries are omitted. |
Radoslaw Jablonski |
13 years ago |
1 file, +1, -1 |
| c85c0907 |
obexd: Fix build when using --enable-nokia-backup |
Luiz Augusto von Dentz |
13 years ago |
1 file, +1, -1 |
| 14d11b28 |
obexd: Fix NULL checking for pbap_get
Fixed NULL checking for name parameter - it shouldn't be there because
handling for NULL name for some cases is already below. Also passing path
which is NULL further makes no sense for PBAP so leaving with -EBADR if
that kind of situation occurs after generating path. |
Radoslaw Jablonski |
13 years ago |
1 file, +4, -1 |
| 5d7835ea |
obexd: Fix NULL check for name param
Added NULL checking for "name" param in pbap_open_* functions. If on
this level this variable will be NULL, then setting -EBADR error code
and ending function. This fixes many obexd crashes. |
Radoslaw Jablonski |
13 years ago |
1 file, +12, -2 |
| 698e3edc |
obexd: ebook backend: return all TEL attribs from vCard as strings
evcard_to_string() only took one TEL attrib from a vCard. But multiple
TEL attribs are supported. This patch will convert all TEL attribs to
strings. |
Marcel Mol |
13 years ago |
1 file, +17, -8 |
| 40ffcc15 |
obexd: Fix vcard filter setting
The bits for VCARD version 2.1 and version 3.0 were wrong: in case of
2.1 the FN bit was on and for 3.0 it is off. The comment states that 3.0
needs FN while 2.1 does not. This patch fixes that. |
Marcel Mol |
13 years ago |
1 file, +1, -1 |
| 1759d715 |
obexd: Make sure errors are reported properly to applications
Error message were most of the time empty.
Thanks for Vitja Makarov <vitja.makarov@gmail.com> for reporting this. |
Luiz Augusto von Dentz |
13 years ago |
5 files, +86, -50 |
| 37e6b49f |
obexd: Fix minor comment typos & indents |
Marcel Mol |
13 years ago |
2 files, +2, -2 |
| f9158801 |
obexd: Fix return value checking of e_book_async_get_contacts
phonebook_create_cache() failed because checking the return value
e_book_async_get_contacts() was wrong. This would lead to a core dump as
the data was freed but was still used in the callbacks. |
Marcel Mol |
13 years ago |
1 file, +1, -1 |
| 27906878 |
obexd: Fix not closing socket when connection attempt fails
When connection attempt fails the socket were left opened as it is not
assigned to the session, also when the connection does succeed the socket
is closed twice when the session is removed.
To fix those issues session now holds a reference to the GIOChannel
returned bt bt_io_connect so that the connection can properly close when
releasing, in addiction to that it also is marked to not close the socket
when the connection succeeds so that when removing the session it doesn't
close the socket twice.
Thanks for Vitja Makarov <vitja.makarov@gmail.com> for reporting this. |
Luiz Augusto von Dentz |
13 years ago |
2 files, +26, -15 |
| ef84cfa6 |
obexd: Fix de-registering PBAP drivers on init failure scenarios
Unwind the driver registration/phonebook initialization stack on pbap
plugin init failure scenarios. |
Tom Counihan |
13 years ago |
1 file, +20, -5 |
| 9c3dda9c |
obexd: Fix query for VCARD listing (work phone issue)
Fixed tracker query for VCARD listing - previously contacts with only
work phone filled were missing in query result (and in vcard listing).
Now if mobile/home phone number is not available, then trying to get
work phone number. |
Radoslaw Jablonski |
13 years ago |
1 file, +4, -0 |
| ddc034fc |
obexd: Fix problem with incoming calls query
After making some incoming, outgoing, missed calls, history lists of them
(ich, och, mch) are stored on device. In current implementation queries
towards tracker for incoming calls include also missed calls.
So list for incoming calls displayed on paired BT headset/carkit screen
(e.g. BH-903, CK-200) also contains numbers from missed calls list.
To block adding missed calls list numbers to incoming calls there should
be added info that incoming call is in fact only answered call. So macros
additionally include info: "nmo:isAnswered true ." Without this, missed
calls was treated as incoming calls. |
Radoslaw Jablonski |
13 years ago |
1 file, +4, -2 |
| 4e199d8d |
obexd: fix possible buffer overflow
When checking if driver matches target or who sizes were not being
verified which can cause invalid accesses when the received target size
is bigger than driver's target size.
To fix this memncmp0 was introduced to takes both sizes and compares them
before calling memcmp. |
Luiz Augusto von Dentz |
13 years ago |
4 files, +12, -7 |
| bb30d009 |
obexd: reuse code when reading buffered data
This should also improve speed since now file transfer also tries to read
all buffered data before continue, so each progress will probably be
around the MTU size rather than buffer size. |
Luiz Augusto von Dentz |
13 years ago |
1 file, +36, -34 |
| 6953eee7 |
obexd: fix crash when resetting a session with no service
A service driver may not be selected when resetting the session so it can
be NULL and thus need to be verified before checking the existence of
.reset callback. |
Luiz Augusto von Dentz |
13 years ago |
1 file, +1, -1 |
| b0285ab4 |
obexd: Add mode option for L2CAP sockets to the BtIO API
Some profiles like MCAP or HDP need set an specific L2CAP configuraton
such as Streaming, ERTM or another else. This patch enables the BtIO API
to set the mode for L2CAP socket options. |
Santiago Carot-Nemesio |
13 years ago |
2 files, +14, -6 |
| 88302aea |
obexd: Fix empty 'N:' parameter handling for vCards
Bluetooth PBAP specification expects for call history listing that the
parameter N: shall be empty when we cannot retrieve personal data from
PSE phone book. Some devices (e.g. Nokia BH-903) have problems when
unnecessary characters occur after N:. The list of dialed/incoming calls
on the carkit becomes then useless since the carkit shows only blank
lines and it's impossible to determine who made call.
In previous version unnecessary semicolons were added after N:("N:;;;;")
to represent empty name. Now if none of the contact fields is
available, then adding real empty "N:" parameter (without semicolons). |
Radoslaw Jablonski |
13 years ago |
1 file, +34, -0 |
| dbdf44bd |
obexd: fix DBusPendingCall handle leak |
Rajeev Kuthiravattath |
13 years ago |
1 file, +12, -10 |
| 27997122 |
obexd: add debug for read stream |
Luiz Augusto von Dentz |
13 years ago |
1 file, +5, -1 |
| 8c427af9 |
obexd: Add variable target size support to obex_mime_type_driver_find()
Targets for mime type drivers are not always fixed to TARGET_SIZE.
(fix started by Pierre Ossman) |
Marcel Mol |
13 years ago |
7 files, +26, -8 |
| 15130f0c |
obexd: fix not reading all buffered data |
Luiz Augusto von Dentz |
13 years ago |
1 file, +17, -10 |
| c57a8d82 |
obexd: Fix crash when processing OBEX_EV_PROGRESS
This crash can be observed when running codenomicon PBAP tests. |
Luiz Augusto von Dentz |
13 years ago |
1 file, +1, -1 |
| 8a504f04 |
obexd: fix strerr option |
Luiz Augusto von Dentz |
13 years ago |
1 file, +1, -1 |
| d85b3cd6 |
obexd: fix not calling driver .reset when resetting session
.reset should be called in all situation that the session is reset,
including when there is a socket HUP/ERR, so that the driver has a chance
to cleanup properly.
In addiction to that this should also fix not removing files when
incomplete/aborted by checking the status when resetting the session. |
Luiz Augusto von Dentz |
13 years ago |
1 file, +13, -15 |
| cf7c5062 |
obexd: More cleanup for the logging code |
Marcel Holtmann |
13 years ago |
4 files, +20, -22 |
| 8f04e6a2 |
obexd: fix use of log_ prefix |
Luiz Augusto von Dentz |
13 years ago |
3 files, +152, -153 |
| c6bfc33a |
obexd: fix codestyle |
Luiz Augusto von Dentz |
13 years ago |
1 file, +1, -1 |
| 885ce762 |
obexd: fix not cancelling request in case of error |
Luiz Augusto von Dentz |
13 years ago |
1 file, +3, -3 |
| 1b0d95cd |
obexd: print response codes |
Luiz Augusto von Dentz |
13 years ago |
2 files, +13, -0 |
| 9880d103 |
obexd: improve tracking of capability scripts |
Luiz Augusto von Dentz |
13 years ago |
1 file, +20, -4 |
| 2e28322a |
obexd: Make sure vcards attributes are in the same order as mentioned in the spec
Some carkits (nokia ck-600) seems to be picky about the ordering of the
attributes so that they have to be as mentioned in the spec:
vCard 2.1 order VERSION, N and TEL
vCard 3.0 order VERSION, N,FN and TEL |
Luiz Augusto von Dentz |
13 years ago |
1 file, +6, -6 |
| dea41fe5 |
obexd: Fix security requirements for legacy devices (< 2.1)
Make use of security low so that services like opp do not request bonding
when connecting to legacy devices. |
Luiz Augusto von Dentz |
13 years ago |
1 file, +1, -0 |
| fd3ec867 |
obexd: Fix fixed strings not having the const modifier |
Vinicius Costa Gomes |
13 years ago |
1 file, +1, -1 |
| 63efd107 |
obexd: fix use of uninitialized variable for object size
By default it is now assigned to OBJECT_SIZE_UNKNOWN so the plugins are
only necessary to change its size if they really know the size of object. |
Luiz Augusto von Dentz |
13 years ago |
3 files, +1, -13 |
| 512b6c03 |
obexd: fix not handling all possible errors accordingly
Reuse os_set_response whenever possible to handle errors consistently |
Luiz Augusto von Dentz |
13 years ago |
1 file, +13, -45 |
| f2c052aa |
obexd: fix crash when driver doesn't implement .remove |
Luiz Augusto von Dentz |
13 years ago |
1 file, +2, -1 |