| 49db95b2 |
obexd: Fix obexd crash for empty listing invalid cache
This fixes obexd crash in 3-way calling scenario when filtered listing
response is empty. Valid cache and empty pbap buffer mean that cache was
already attempted to be created within a single session, but no data was
available. Hence, it is not notified and no such file error returned.
Such avoids clearing and creating a new cache operations for each incoming
call, which is one of possible solution to fix this bug. It can be
extensive for large phone books. New cache is not created within current
obex session or unless path is changed. |
Dmitriy Paliy |
13 years ago |
1 file, +9, -0 |
| b7cacc36 |
obexd: Remove unnecessary empty line in phonebook-tracker |
Radoslaw Jablonski |
13 years ago |
1 file, +0, -1 |
| 6c359041 |
obexd: Fix status problem after pulling empty call history
Problem with "OK" status after pulling phonebook for empty call history
(cch) is fixed by this patch. Previously "OK" status was received even
for empty (as it normally does for non-empty) call history and now
"Not Found" status is received in case when there is no call event. |
Rafal Michalski |
13 years ago |
1 file, +1, -1 |
| e2b74c4b |
obexd: Fix possible invalid read
==3229== Invalid read of size 4
==3229== at 0x1D218: obex_object_set_io_flags (in /usr/lib/obex/obexd)
==3229== Address 0x4c95e9c is 4 bytes inside a block of size 8 free'd
==3229== at 0x4833E98: free (vg_replace_malloc.c:366)
==3229== by 0x4910D23: g_free (gmem.c:191)
==3229== by 0x492B8EF: g_slist_remove (gslist.c:441)
==3229== by 0x1D15B: ??? (in /usr/lib/obex/obexd) |
Luiz Augusto von Dentz |
13 years ago |
1 file, +3, -1 |
| f4febbbd |
obexd: Fix not setting proper errors when canceling suspended requests |
Luiz Augusto von Dentz |
13 years ago |
1 file, +3, -2 |
| 972f88aa |
obexd: Make use of transfer->err to store transfer errors |
Luiz Augusto von Dentz |
13 years ago |
1 file, +5, -5 |
| 9af3fedc |
obexd: Fix regression when formatting timestamps from tracker
Tracker format user delimiters like '-' and ':' which need to be keep in
order to sscanf to work. |
Luiz Augusto von Dentz |
13 years ago |
1 file, +6, -3 |
| a92b74f0 |
obexd: Fix plugin define |
Marcel Holtmann |
13 years ago |
1 file, +1, -1 |
| a9c668bd |
obexd: Type conversion in read and write obex streams
Integer types in obex_write_stream and obex_read_stream shell be the
same as those returned by read and write function prototypes of
obex_mime_type_driver. |
Dmitriy Paliy |
13 years ago |
1 file, +4, -4 |
| 14f09b2e |
obexd: Fix not responding Not Found for filtered vcard-listing
In this case entries may be found but it still may not match the filter
criteria. |
Luiz Augusto von Dentz |
13 years ago |
1 file, +6, -6 |
| 2f90eed8 |
obexd: Code cleanup: unnecessary operation and typo removed
Code cleanup: unnecessary operation 'return len;' removed and typo in
comments immidiately to immediately corrected. |
Dmitriy Paliy |
13 years ago |
1 file, +1, -2 |
| eb83291e |
obexd: Fix not responding Not Found when no entry is found
Accourding to PBAP spec PSE must reply Not Found when:
"The function was recognized and all the parameters are proper, but the
vCard handle or the phone book object could not be found." |
Luiz Augusto von Dentz |
13 years ago |
2 files, +24, -3 |
| 41d54f42 |
obexd: Fix X-IRMC-CALL-DATETIME format
Use the format suggested in the spec:
"For instance, a call that was missed on March 20th, 2005 at 10 am would
be stamped: X-IRMC-CALL-DATETIME;MISSED:20050320T100000" |
Luiz Augusto von Dentz |
13 years ago |
1 file, +2, -2 |
| e634250d |
obexd: Fix suspend stream on opening if no data
Fix write to stream and suspend it immidiately if there is no data
available. |
Dmitriy Paliy |
13 years ago |
1 file, +13, -1 |
| cf333570 |
obexd: Fix regression on suspend on opening
This fixes regression on suspend on opening when obex_write_stream
returns length of buffer, which is treated as error response
afterwards. |
Dmitriy Paliy |
13 years ago |
1 file, +1, -1 |
| 956f0bb6 |
obexd: Fix possible use of uninitialized variables
Using uninitialized value "hi" and "flags" in call to function
"OBEX_ObjectAddHeader". |
Luiz Augusto von Dentz |
13 years ago |
1 file, +3, -0 |
| fc5c1214 |
obexd: Fix process pending request if transfer canceled
If the call to the Request method of the obex client agent returns
with an error (for example if the transfer is rejected), call
function session_terminate_transfer instead of unregister_transfer
to both unregister the transfer and handle the pending request. |
Daniel Orstadius |
13 years ago |
1 file, +11, -1 |
| 7d3708f9 |
obexd: Fix dead statement
Cannot reach dead statement "(*os->driver->close)(object);" |
Luiz Augusto von Dentz |
13 years ago |
1 file, +1, -7 |
| 4a54d91c |
obexd: Fix possible NULL pointer deference
Variable "transfer" tracked as NULL was passed to function
"transfer_unregister" that dereferences it. |
Luiz Augusto von Dentz |
13 years ago |
1 file, +2, -4 |
| 8103daff |
obexd: Fix possible NULL pointer deference
Variable "os->driver" tracked as NULL. |
Luiz Augusto von Dentz |
13 years ago |
1 file, +3, -1 |
| 2e7fca91 |
obexd: Fix memory leaks in phonebook-tracker module
Memory, pointed by pointers home_addr and work_addr, is allocated
temporarily and not freed. Only duplicates of this memory (made after
invoking add_address function) are freed later. |
Rafal Michalski |
13 years ago |
1 file, +3, -0 |
| cf1c33d6 |
obexd: Change "websiteUrl" query field to more general
"websiteUrl" query field is replaced by more general "url" because
previously web address wasn't downloaded in each case. |
Rafal Michalski |
13 years ago |
1 file, +6, -6 |
| 9fcc33bf |
obexd: Fix not detecting errors on small files
Make use of gw_obex_xfer_close instead of gw_obex_xfer_flush since the
former not only flushes the remaining data but also wait for the response
catching errors that gw_obex_xfer_flush doesn't. |
Luiz Augusto von Dentz |
13 years ago |
1 file, +1, -1 |
| 2f3a6e03 |
obexd: Fix emitting TransferCompleted twice
This is caused by REQDONE and latter disconnect generating duplicate
signals in case of opp.
To fix this now we check if the object is valid before proceeding. |
Luiz Augusto von Dentz |
13 years ago |
1 file, +2, -1 |
| 2285b59c |
obexd: Bind cch call log with phonebook
After incoming/missed/outgoing call is done by/to number from phonebook
then combined call history will be shown with data about caller -
downloaded in vCard structure. |
Rafal Michalski |
13 years ago |
1 file, +66, -1 |
| ee8fe4da |
obexd: Bind och call log with phonebook
After outgoing call is done to number from phonebook then outgoing call
history will be shown with data about caller - downloaded in vCard
structure. |
Rafal Michalski |
13 years ago |
1 file, +33, -1 |
| f9444f2f |
obexd: Bind ich call log with phonebook
After incoming call is done by number from phonebook then incoming call
history will be shown with data about caller - downloaded in vCard
structure. |
Rafal Michalski |
13 years ago |
1 file, +36, -2 |
| e1431b8e |
obexd: Change default type of call from call log
Previously after downloading call log all calls had HOME type as default.
Now this type is OTHER - it will be used when connection is made
with number which is out of phonebook. To solve this issue extending
number of columns and queries of database was needed especially
(one field in database query was added). |
Rafal Michalski |
13 years ago |
2 files, +40, -104 |
| 8702ac21 |
obexd: Fix not detecting errors when transferring the last part of the buffer
The last part has to be flushed in order to sent the remaining buffer as
a obex packet and detect possible errors. |
Luiz Augusto von Dentz |
13 years ago |
1 file, +3, -1 |
| 283e770d |
obexd: Fix problem with double number in call log
Previously after downloading call log there was two times the same number
for call binded with phonebook - one HOME/WORK type and second OTHER type
in downloaded vCard structure. Now there is only one number with proper
type (HOME or WORK). |
Rafal Michalski |
13 years ago |
2 files, +16, -3 |
| 0008e04e |
obexd: Bind mch call log with phonebook
After missed call is done by number from phonebook then missed call
history will be shown with data about caller - downloaded in vCard
structure. |
Rafal Michalski |
13 years ago |
1 file, +36, -2 |
| 80656964 |
obexd: Add handling of TITLE contact's field in vCard
After pulling contacts this field wasn't presented in downloaded vCard
structure in spite of that it existed (not empty). Now it shows downloaded
TITLE field (using database query). |
Rafal Michalski |
13 years ago |
3 files, +17, -11 |
| 8ae389be |
obexd: Replace void * with gpointer
To make it consistent with bluez btio.c. |
Zhenhua Zhang |
13 years ago |
2 files, +17, -17 |
| f2c7d3f7 |
obexd: Remove blank line at EOF |
Zhenhua Zhang |
13 years ago |
1 file, +0, -1 |
| f68787fc |
obexd: Remove role field from ORG tag
Previously role field was under ORG tag. Now it's single field under
ROLE tag. |
Rafal Michalski |
13 years ago |
3 files, +8, -8 |
| 6681d72e |
obexd: Fix handling of UID contact's field in vCard
Previously invalid field was assigned to uid data. To solve this
problem extending number of columns and queries of database was needed
especially (one field in database query was added). |
Rafal Michalski |
13 years ago |
1 file, +13, -13 |
| 22da0a23 |
obexd: Fix problem with phonebook size
This patch fix problem with phonebook size during phonebook
pull request. Now obexd "combine" the raw results from tracker DB
to match with that what phonebook pull returns. |
Lukasz Pawlik |
13 years ago |
1 file, +6, -7 |
| 49fb6264 |
obexd: Add handling of UID contact's field in vCard
After pulling contacts this field wasn't presented in downloaded vCard
structure in spite of that it existed (not empty). Now it shows downloaded
UID (using database query). |
Rafal Michalski |
13 years ago |
3 files, +6, -0 |
| c20efca4 |
obexd: Add handling for more than one address in vCard
After pulling contacts only fields (pobox, extended, street, locality,
region, postal, country) of one address were present in downloaded vCard
structure (under ADR tag) in spite of that there can be more adresses
stored on phonebook. To solve this problem extending number of columns and
queries of database was needed especially. Distinguish between two types
of address (HOME and WORK) is supported. |
Rafal Michalski |
13 years ago |
3 files, +167, -30 |
| 2cad9386 |
obexd: Fix over 80 column lines |
Johan Hedberg |
13 years ago |
1 file, +10, -6 |
| a6c78208 |
obexd: Fix handling empty fields in vCards
Previously even mandatory TEL field was not printed in vCard if it was
empty. This patch fix this. Now tag TEL will be printed if phone number
is not set in phonebook. This patch also fix handling category string
for vCards in version 2.1 for url field. |
Lukasz Pawlik |
13 years ago |
1 file, +36, -18 |
| 82dbd7cb |
obexd: Fix issues with emails category
Previously all emails sent during phonebook pull had the same
category INTERNET. Now email are sent with valid category name
(INTERNET;HOME or INTERNET;WORK) |
Lukasz Pawlik |
13 years ago |
3 files, +74, -21 |
| 1dbd947a |
obexd: Fix issues caused by multiple dependencies on phonebook.c
Previously only PBAP depended on phonebook.c. Now IrMC Sync also depends
on it. That means that phonebook_init and phonebook_exit need to be able
to handle multiple calls or else memory leaks and double-free's are
likely. This patch adds safeguards for this to the _init and _exit
functions that need it. |
Johan Hedberg |
13 years ago |
2 files, +8, -0 |
| 916d09bf |
obexd: Merge address fields into a single field
So far in code all seven address fields (pobox, extended, street,
locality, region, postal, country) was represented separately. In the
vCard structure address is represented by one field so all mentioned
fields can be merged into a single field. |
Rafal Michalski |
13 years ago |
3 files, +20, -39 |
| 58d56b7b |
obexd: Seperate btio.[ch] into btio directory
Seperate btio.[ch] from src directory to btio sub-folder. |
Zhenhua Zhang |
13 years ago |
2 files, +0, -1396 |
| 740e5a5a |
obexd: Remove dup VCard2.1 SDP format for OPP
OPP SDP record appears to have a duplicate entry for
Supported Formats List. |
Tom Counihan |
13 years ago |
1 file, +0, -1 |
| 565c1e1b |
obexd: Add handling of ORG contact's fields handled in VCARD structure
After pulling contacts these fields weren't present in downloaded
VCARD structure in spite of that these fields existed (not empty).
This patch adds handling of fields grouped under ORG tag.
To solve this problem extending number of columns and queries of database
was needed especially. Of course fields mentioned above were added to
phonebook_contact structure as char * type to save gained data. |
Rafal Michalski |
13 years ago |
3 files, +60, -11 |
| 6417a2c2 |
obexd: Add handling of single contact's fields handled in VCARD structure
After pulling contacts these fields weren't present in downloaded
VCARD structure in spite of that these fields existed (not empty).
This patch adds handling of fields: BDAY, NICKNAME, URL, PHOTO
To solve this problem extending number of columns and queries of database
was needed especially. Displaying these fields is done by genaral
functions: vcard_printf_tag, vcard_printf_slash_tag.
Of course fields mentioned above were added to phonebook_contact structure
as char * type to save gained data. |
Rafal Michalski |
13 years ago |
3 files, +95, -6 |
| e33cf832 |
obexd: Sort IrMC after PBAP |
Marcel Holtmann |
13 years ago |
2 files, +4, -4 |
| 0939e19c |
obexd: IrMC sync server support
A reasonable working IrMC SYNC server (only full phonebook sync support)
Support for cal and note by just returning nothing. |
Marcel Mol |
13 years ago |
3 files, +525, -2 |